handle global Flags #28

New Issue

lunny · 2019-05-02T05:57:50Z

lunny commented

2019-05-02 05:57:50 +00:00

While trying to solve #12 with PR #15 several options were discussed.
To move the discussion out of the PR and summarize the available options I create this issue.

The short summary of the problem #12 pointed out is that the current CLI lib does not inherit global flags into several subcommands (see https://github.com/urfave/cli/issues/585)

The currently available options are:

switching to Cobra a different CLI lib (suggested by @noerw )
creating global flags and use append() to merge subcommand flags with global flags (suggested by @techknowlogick )

To compare both options I created a branch in my fork for each of them:

Cobra: #27
current cli: #26

Author: @root360-AndreasUlm While trying to solve #12 with PR #15 several options were discussed. To move the discussion out of the PR and summarize the available options I create this issue. The short summary of the problem #12 pointed out is that the current CLI lib does not inherit global flags into several subcommands (see https://github.com/urfave/cli/issues/585) The currently available options are: - switching to Cobra a different CLI lib (suggested by @noerw ) - creating global flags and use append() to merge subcommand flags with global flags (suggested by @techknowlogick ) To compare both options I created a branch in my fork for each of them: - Cobra: #27 - current cli: #26

lunny commented

2019-05-02 06:02:48 +00:00

Author: @root360-AndreasUlm

After implementing #26 I found this solution to be easier and the workaround seems to work quite well.
The switch to Cobra will take more time.

Author: @root360-AndreasUlm After implementing #26 I found this solution to be easier and the workaround seems to work quite well. The switch to Cobra will take more time.

lunny commented

2019-05-02 14:11:10 +00:00

Author: @lunny

@root360-AndreasUlm I think #26 is easier for review.

Author: @lunny @root360-AndreasUlm I think #26 is easier for review.

lunny commented

2019-05-02 14:15:05 +00:00

Author: @root360-AndreasUlm

@lunny then let's go with #26.
I'll close #15 and #27.

Author: @root360-AndreasUlm @lunny then let's go with #26. I'll close #15 and #27.

lunny added the

kind

enhancement

label 2019-06-09 13:37:22 +00:00

noerw commented

2019-10-25 11:59:00 +00:00

Now that #39 is merged, we should be able to close this.

Note though, that the following is not possible anymore:

tea -r gitea/tea issues

Is this intentional? This syntax to me has the best ergonomics for command iteration

Now that #39 is merged, we should be able to close this. Note though, that the following is not possible anymore: ``` tea -r gitea/tea issues ``` Is this intentional? This syntax to me has the best ergonomics for command iteration

6543 commented

2019-10-25 21:49:14 +00:00