Refactor error handling #295

New Issue

noerw · 2020-12-14T05:35:08Z

noerw commented

2020-12-14 05:35:08 +00:00

There's quite a lot of log.Fatal() in the code base, even though we have facilities to pass errors all the way up.
We should have a single error handler.

There's quite a lot of `log.Fatal()` in the code base, even though we have facilities to pass errors all the way up. We should have a single error handler.

👍 1

noerw added the

kind

refactor

label 2020-12-14 05:35:08 +00:00

6543 added this to the v0.7.0 milestone 2020-12-14 10:29:48 +00:00

noerw commented

2020-12-15 11:33:08 +00:00

While at it, we can introduce proper error codes (at least for common cases like 404 etc).
urfave/cli has facilities for this (cli.Exit(msg, code)).
Question is: Is it okay to introduce cli dependency in modules/tasks for this? @6543

While at it, we can introduce proper error codes (at least for common cases like 404 etc). urfave/cli has facilities for this (`cli.Exit(msg, code)`). Question is: Is it okay to introduce `cli` dependency in `modules/tasks` for this? @6543

6543 commented

2020-12-15 16:31:40 +00:00