gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add interactive mode for tea issue create #302

Merged
6543 merged 4 commits from YakoYakoYokuYoku/tea:interactive-issue into master 2020-12-14 20:05:32 +00:00
Conversation 0 Commits 4 Files Changed 5 +142 -64
YakoYakoYokuYoku commented 2020-12-14 18:16:25 +00:00
Contributor
Copy Link

Fixes #228.
Created #301 from my console.

Fixes #228. Created #301 from my console.
👍 1 ❤️ 1
YakoYakoYokuYoku added 1 commit 2020-12-14 18:16:25 +00:00
Implement interactive issue creation 
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
8cb5aebf21
noerw requested changes 2020-12-14 18:24:55 +00:00
Dismissed
noerw left a comment
Member
Copy Link

great work! only a small nit

great work! only a small nit
modules/utils/prompts.go Outdated
@ -0,0 +11,4 @@
"github.com/AlecAivazis/survey/v2"
)
func PromptRepoSlug(defaultOwner, defaultRepo string) (owner, repo string, err error) {
noerw commented 2020-12-14 18:22:09 +00:00
Member
Copy Link

I'd put this into modules/interact/prompts.go

I'd put this into `modules/interact/prompts.go`
YakoYakoYokuYoku marked this conversation as resolved
YakoYakoYokuYoku added 1 commit 2020-12-14 18:26:55 +00:00
Comment PromptRepoSlug
All checks were successful
continuous-integration/drone/pr Build is passing
Details
5a34362591
YakoYakoYokuYoku added 1 commit 2020-12-14 18:34:48 +00:00
Move PromptRepoSlug to the right place
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1b59e8a45e
YakoYakoYokuYoku requested review from noerw 2020-12-14 18:37:34 +00:00
noerw added the
kind
feature
 label 2020-12-14 18:37:40 +00:00
noerw added this to the v0.7.0 milestone 2020-12-14 18:37:43 +00:00
noerw approved these changes 2020-12-14 18:38:10 +00:00
Dismissed
khmarbaise approved these changes 2020-12-14 18:49:15 +00:00
Dismissed
6543 reviewed 2020-12-14 19:14:12 +00:00
Dismissed
modules/interact/prompts.go Outdated
@ -16,1 +19,4 @@
}
// PromptRepoSlug interactively prompts for a Gitea repository or returns the current one
func PromptRepoSlug(defaultOwner, defaultRepo string) (owner, repo string, err error) {
6543 commented 2020-12-14 19:14:12 +00:00
Owner
Copy Link

do we have to export it?

do we have to export it?
6543 commented 2020-12-14 19:15:02 +00:00
Owner
Copy Link

@YakoYakoYokuYoku nice work, just one nit

exporting this function is not needed if it is only used in the same module

@YakoYakoYokuYoku nice work, just one nit exporting this function is not needed if it is only used in the same module
YakoYakoYokuYoku commented 2020-12-14 19:25:00 +00:00
Author
Contributor
Copy Link

Gotcha

Gotcha
YakoYakoYokuYoku marked this conversation as resolved
YakoYakoYokuYoku added 1 commit 2020-12-14 19:27:40 +00:00
Hide promptRepoSlug
All checks were successful
continuous-integration/drone/pr Build is passing
Details
817631fbf2
6543 approved these changes 2020-12-14 20:05:03 +00:00
Dismissed
6543 merged commit b9f5ba0702 into master 2020-12-14 20:05:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#302
No description provided.
Delete Branch "YakoYakoYokuYoku/tea:interactive-issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?