gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add interactive mode for tea milestone create #310

Merged
6543 merged 4 commits from YakoYakoYokuYoku/tea:interactive-ms into master 2020-12-17 18:50:08 +00:00
Conversation 10 Commits 4 Files Changed 6 +146 -18
YakoYakoYokuYoku commented 2020-12-17 13:54:28 +00:00
Contributor
Copy Link

Fixes #245.

Fixes #245.
YakoYakoYokuYoku added 1 commit 2020-12-17 13:54:29 +00:00
Implement interactive milestone creation 
Signed-off-by: Martin Reboredo <yakoyoku@gmail.com>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
52641083c9
noerw reviewed 2020-12-17 13:58:36 +00:00
Dismissed
modules/task/milestone_create.go Outdated
@ -0,0 +18,4 @@
// title is required
if len(title) == 0 {
fmt.Printf("Title is required\n")
noerw commented 2020-12-17 13:58:36 +00:00
Member
Copy Link

return fmt.Errorf("Title is required")

`return fmt.Errorf("Title is required")`
YakoYakoYokuYoku marked this conversation as resolved
noerw changed title from Add interactive mode for `tea issue create` to Add interactive mode for `tea milestone create` 2020-12-17 13:58:50 +00:00
noerw added the
kind
feature
 label 2020-12-17 13:58:57 +00:00
noerw commented 2020-12-17 14:03:32 +00:00
Member
Copy Link

Thanks ?
Do you plan to ask for the deadline as well? That would be great as it prepares for #303

Thanks ? Do you plan to ask for the deadline as well? That would be great as it prepares for #303
noerw added this to the v0.7.0 milestone 2020-12-17 14:03:58 +00:00
YakoYakoYokuYoku added 1 commit 2020-12-17 14:08:41 +00:00
Return fmt.Errorf when title is empty
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a0835d3a18
YakoYakoYokuYoku commented 2020-12-17 14:09:40 +00:00
Author
Contributor
Copy Link

Do you plan to ask for the deadline as well? That would be great as it prepares for #303

Yeah, let's do that.

> Do you plan to ask for the deadline as well? That would be great as it prepares for #303 Yeah, let's do that.
YakoYakoYokuYoku commented 2020-12-17 14:26:18 +00:00
Author
Contributor
Copy Link

@noerw May I ask you the date layout for the deadline (see time.Parse)?

@noerw May I ask you the date layout for the deadline (see [time.Parse](https://pkg.go.dev/time#Parse))?
6543 commented 2020-12-17 14:31:00 +00:00
Owner
Copy Link

by the way pleace "update branch" ...

by the way pleace "update branch" ...
6543 reviewed 2020-12-17 14:34:24 +00:00
Dismissed
cmd/milestones/create.go Outdated
@ -43,28 +42,22 @@ var CmdMilestonesCreate = cli.Command{
func runMilestonesCreate(cmd *cli.Context) error {
ctx := context.InitCommand(cmd)
ctx.Ensure(context.CtxRequirement{RemoteRepo: true})
6543 commented 2020-12-17 14:34:24 +00:00
Owner
Copy Link

isn't ctx.Ensure(context.CtxRequirement{RemoteRepo: true}) still needed?

isn't `ctx.Ensure(context.CtxRequirement{RemoteRepo: true})` still needed?
6543 commented 2020-12-17 14:34:35 +00:00
Owner
Copy Link

cc @noerw

cc @noerw
noerw commented 2020-12-17 14:40:27 +00:00
Member
Copy Link

It is.

It is.
YakoYakoYokuYoku marked this conversation as resolved
YakoYakoYokuYoku added 1 commit 2020-12-17 14:42:50 +00:00
Merge branch 'master' into interactive-ms
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a169550f62
noerw commented 2020-12-17 14:43:59 +00:00
Member
Copy Link

@YakoYakoYokuYoku Regarding time parsing: I'd do something similar to

var t time.Time
if deadline != "" {
	if t, err := time.ParseInLocation(time.RFC3339, deadline); err != nil {
		if t, err = time.ParseInLocation(time.UnixDate, deadline); err != nil {
			return err
		}
	}
}

edit: doe RFC3339 accept date only? If not, we should accept a date in RFC3339 structure, but with only the date..

@YakoYakoYokuYoku Regarding time parsing: I'd do something similar to ``` var t time.Time if deadline != "" { if t, err := time.ParseInLocation(time.RFC3339, deadline); err != nil { if t, err = time.ParseInLocation(time.UnixDate, deadline); err != nil { return err } } } ``` edit: doe RFC3339 accept date only? If not, we should accept a date in RFC3339 structure, but with only the date..
YakoYakoYokuYoku force-pushed interactive-ms from a169550f62 to 747fa1345f 2020-12-17 14:47:16 +00:00 Compare
YakoYakoYokuYoku commented 2020-12-17 15:45:50 +00:00
Author
Contributor
Copy Link

doe RFC3339 accept date only? If not, we should accept a date in RFC3339 structure, but with only the date..

It seems that time.RFC3339 doesn't support an ISO 8601 date structure with only the date, but we could nest two time.Parses (one with time.RFC3339 and the other with "2006-01-02") or we could use dateparse.ParseAny.

edit: dateparse is also in go.mod.

> doe RFC3339 accept date only? If not, we should accept a date in RFC3339 structure, but with only the date.. It seems that `time.RFC3339` doesn't support an ISO 8601 date structure with only the date, but we could nest two `time.Parse`s (one with `time.RFC3339` and the other with `"2006-01-02"`) or we could use `dateparse.ParseAny`. edit: `dateparse` is also in `go.mod`.
noerw commented 2020-12-17 15:49:26 +00:00
Member
Copy Link

@YakoYakoYokuYoku Sounds good to me to have "2006-01-02" and RFC3339 as fallback. I'd avoid another dependency

Scratch that, we already have dateparse ? Lets go for dateparse.ParseLocal

~~@YakoYakoYokuYoku Sounds good to me to have "2006-01-02" and RFC3339 as fallback. I'd avoid another dependency~~ Scratch that, we already have dateparse ? Lets go for `dateparse.ParseLocal`
YakoYakoYokuYoku added 1 commit 2020-12-17 16:28:44 +00:00
Incorporate deadline functionality
All checks were successful
continuous-integration/drone/pr Build is passing
Details
4416c6099a
YakoYakoYokuYoku commented 2020-12-17 16:32:39 +00:00
Author
Contributor
Copy Link

Yeah I know that I'm using time.Parse here, but I would be thankful if the reviews point out other important things.

Yeah I know that I'm using `time.Parse` here, but I would be thankful if the reviews point out other important things.
noerw requested changes 2020-12-17 17:10:18 +00:00
Dismissed
modules/interact/milestone_create.go Outdated
@ -0,0 +16,4 @@
)
// CreateMilestone interactively creates a milestone
func CreateMilestone(login *config.Login, owner, repo string, deadline *time.Time, state gitea.StateType) error {
noerw commented 2020-12-17 17:09:30 +00:00
Member
Copy Link

No need for the deadline & state params: They will never be set anyway

No need for the deadline & state params: They will never be set anyway
6543 commented 2020-12-17 17:28:12 +00:00
Owner
Copy Link

didn't he add a flag for this?

didn't he add a flag for this?
noerw commented 2020-12-17 17:59:29 +00:00
Member
Copy Link

Yeah, but interactive mode won't be enabled if there is a flag set..
We could ofcourse change the condition to go into interactive mode, if not all mandatory flags are provided, but idk if that's better

Yeah, but interactive mode won't be enabled if there is a flag set.. We could ofcourse change the condition to go into interactive mode, if not all mandatory flags are provided, but idk if that's better
6543 commented 2020-12-17 18:00:56 +00:00
Owner
Copy Link

no interactive should only if no flags are pressent - how would you integrate tea into scripts if it would ask you the whole time ...

no interactive should only if no flags are pressent - how would you integrate tea into scripts if it would ask you the whole time ...
6543 commented 2020-12-17 18:03:08 +00:00
Owner
Copy Link
-func CreateMilestone(login *config.Login, owner, repo string, deadline *time.Time, state gitea.StateType) error {
+func CreateMilestone(login *config.Login, owner, repo string) error {
```diff -func CreateMilestone(login *config.Login, owner, repo string, deadline *time.Time, state gitea.StateType) error { +func CreateMilestone(login *config.Login, owner, repo string) error { ```
YakoYakoYokuYoku marked this conversation as resolved
modules/interact/milestone_create.go Outdated
@ -0,0 +39,4 @@
}
// deadline
promptI = &survey.Input{Message: "Milestone deadline [no due date]:"}
noerw commented 2020-12-17 17:07:44 +00:00
Member
Copy Link

I'd put the date parsing inside a survey.Validator similar to promptRepoSlug(). This lets users iterate on wrong inputs, instead of failing the entire command

I'd put the date parsing inside a `survey.Validator` similar to `promptRepoSlug()`. This lets users iterate on wrong inputs, instead of failing the entire command
👍 1
YakoYakoYokuYoku commented 2020-12-17 17:51:17 +00:00
Author
Contributor
Copy Link

Gotcha, thx for pointing that out ?

Gotcha, thx for pointing that out ?
YakoYakoYokuYoku marked this conversation as resolved
6543 requested changes 2020-12-17 18:06:15 +00:00
Dismissed
cmd/milestones/create.go Outdated
@ -64,2 +68,2 @@
if err != nil {
return err
if ctx.NumFlags() == 0 {
return interact.CreateMilestone(ctx.Login, ctx.Owner, ctx.Repo, deadline, state)
6543 commented 2020-12-17 18:02:17 +00:00
Owner
Copy Link
-		return interact.CreateMilestone(ctx.Login, ctx.Owner, ctx.Repo, deadline, state)
+		return interact.CreateMilestone(ctx.Login, ctx.Owner, ctx.Repo)
```diff - return interact.CreateMilestone(ctx.Login, ctx.Owner, ctx.Repo, deadline, state) + return interact.CreateMilestone(ctx.Login, ctx.Owner, ctx.Repo) ```
YakoYakoYokuYoku marked this conversation as resolved
modules/interact/milestone_create.go Outdated
@ -0,0 +17,4 @@
// CreateMilestone interactively creates a milestone
func CreateMilestone(login *config.Login, owner, repo string, deadline *time.Time, state gitea.StateType) error {
var title, description, dueDate string
6543 commented 2020-12-17 18:06:10 +00:00
Owner
Copy Link
-	var title, description, dueDate string
+	var title, description, dueDate string
+	var deadline *time.Time
```diff - var title, description, dueDate string + var title, description, dueDate string + var deadline *time.Time ```
YakoYakoYokuYoku marked this conversation as resolved
modules/interact/milestone_create.go Outdated
@ -0,0 +59,4 @@
title,
description,
deadline,
state)
6543 commented 2020-12-17 18:05:22 +00:00
Owner
Copy Link
-		state)
+		gitea.StateOpen)
```diff - state) + gitea.StateOpen) ```
YakoYakoYokuYoku marked this conversation as resolved
YakoYakoYokuYoku added 1 commit 2020-12-17 18:30:13 +00:00
Use dateparse and cleanup CreateMilestone task
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2be9a124f2
YakoYakoYokuYoku requested review from noerw 2020-12-17 18:34:36 +00:00
YakoYakoYokuYoku requested review from 6543 2020-12-17 18:34:37 +00:00
noerw approved these changes 2020-12-17 18:40:22 +00:00
Dismissed
6543 approved these changes 2020-12-17 18:48:12 +00:00
Dismissed
6543 merged commit 43e9943757 into master 2020-12-17 18:50:08 +00:00
6543 commented 2020-12-17 18:50:30 +00:00
Owner
Copy Link

@YakoYakoYokuYoku nice work 👍

@YakoYakoYokuYoku nice work :+1:
YakoYakoYokuYoku commented 2020-12-17 18:53:34 +00:00
Author
Contributor
Copy Link

You welcome too ?

You welcome too ?
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#310
No description provided.
Delete Branch "YakoYakoYokuYoku/tea:interactive-ms"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?