gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add tea issues --fields, allow printing labels #312

Merged
6543 merged 16 commits from noerw/tea:print-issue-fields-labels into master 2020-12-21 15:41:07 +00:00
Conversation 2 Commits 16 Files Changed 16 +343 -222
noerw commented 2020-12-17 15:10:38 +00:00
Member
Copy Link
  • refactor the field selection of tea repos ls --fields, so it can be reused with other entities.
  • use the new generic --fields flag & tableFromItems() to add field selection to tea issues ls & tea ms issues
  • add more printable fields to issues, most importantly colored labels :) (fixes #268)

Maybe we should reconsider the default fields that are printed for issues. At least labels should be included I think, not sure if we really need author and updated by default

- refactor the field selection of `tea repos ls --fields`, so it can be reused with other entities. - use the new generic `--fields` flag & `tableFromItems()` to add field selection to `tea issues ls` & `tea ms issues` - add more printable fields to issues, most importantly colored labels :) (fixes #268) Maybe we should reconsider the default fields that are printed for issues. At least `labels` should be included I think, not sure if we really need `author` and `updated` by default
noerw added this to the v0.7.0 milestone 2020-12-17 15:10:38 +00:00
noerw added the
kind
enhancement
kind
refactor
 labels 2020-12-17 15:10:38 +00:00
noerw added 8 commits 2020-12-17 15:10:39 +00:00
add fields flag to tea issues, tea ms issues
All checks were successful
continuous-integration/drone/pr Build is passing
Details
742ee19f95
6543 reviewed 2020-12-17 17:55:04 +00:00
Dismissed
cmd/issues/list.go Outdated
@ -49,3 +53,3 @@
}
print.IssuesList(issues, ctx.Output)
fields, _ := flags.GetFields(cmd, nil)
6543 commented 2020-12-17 17:55:04 +00:00
Owner
Copy Link
-	fields, _ := flags.GetFields(cmd, nil)
+	fields, err := flags.GetFields(cmd, print.IssueFields)
+	if err != nil {
+		return err
+	}
```diff - fields, _ := flags.GetFields(cmd, nil) + fields, err := flags.GetFields(cmd, print.IssueFields) + if err != nil { + return err + } ```
noerw marked this conversation as resolved
6543 commented 2020-12-17 17:57:21 +00:00
Owner
Copy Link

now you use FullName for user, can you add a fiel username witch instead of FullName always use username?

now you use FullName for user, can you add a fiel username witch instead of FullName always use username?
noerw added 3 commits 2020-12-17 19:09:09 +00:00
Merge branch 'master' into print-issue-fields-labels
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e3ef0159b1
noerw commented 2020-12-17 19:10:06 +00:00
Author
Member
Copy Link

now you use FullName for user, can you add a fiel username witch instead of FullName always use username?

@6543 This actually was the behaviour before too. I added author-id to get just the raw username.

> now you use FullName for user, can you add a fiel username witch instead of FullName always use username? @6543 This actually was the behaviour before too. I added `author-id` to get just the raw username.
👍 1
noerw added 1 commit 2020-12-17 20:18:17 +00:00
change default fields 
tea issues -> replace updated with labels
tea ms issues -> replace author with labels, reorder
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fb8d82f90a
lunny approved these changes 2020-12-18 04:19:25 +00:00
Dismissed
noerw added 1 commit 2020-12-18 12:28:59 +00:00
fixup! validate provided fields
All checks were successful
continuous-integration/drone/pr Build is passing
Details
561a31c2fd
noerw added 1 commit 2020-12-21 13:41:17 +00:00
Merge branch 'master' into print-issue-fields-labels
All checks were successful
continuous-integration/drone/pr Build is passing
Details
68339676fb
6543 added 1 commit 2020-12-21 15:23:44 +00:00
Merge branch 'master' into print-issue-fields-labels
All checks were successful
continuous-integration/drone/pr Build is passing
Details
144df8384b
6543 approved these changes 2020-12-21 15:32:07 +00:00
Dismissed
6543 added 1 commit 2020-12-21 15:36:08 +00:00
Validate Fields for repos
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e1fb8682fb
6543 merged commit 9efee7bf99 into master 2020-12-21 15:41:07 +00:00
6543 deleted branch print-issue-fields-labels 2020-12-21 15:41:15 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#312
No description provided.
Delete Branch "noerw/tea:print-issue-fields-labels"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?