contributed container build definition #350

tgerczei · 2021-03-15T18:36:21Z

tgerczei commented

2021-03-15 18:36:21 +00:00

as discussed with @noerw on Discord

👍 2

tgerczei added 1 commit 2021-03-15 18:36:22 +00:00

continuous-integration/drone/pr Build is passing

Details

34e86ef5db

contributed container build definition

6543 approved these changes 2021-03-16 11:38:14 +00:00

Dismissed

noerw requested changes 2021-03-16 13:09:33 +00:00

Dismissed

noerw left a comment

thank you!
I don't have permission to push to your branch, could adapt the labels as suggested?

Aside: if we are to integrate docker builds with CI (@gitea/Owners ?), we probably want an image that builds from local source instead of pulling from git. I can add that in a followup, not sure if as a replacement or alternative

thank you! I don't have permission to push to your branch, could adapt the labels as suggested? Aside: if we are to integrate docker builds with CI (@gitea/Owners ?), we probably want an image that builds from local source instead of pulling from git. I can add that in a followup, not sure if as a replacement or alternative

contrib/Dockerfile Outdated

						
				@ -0,0 +23,4 @@

				FROM scratch

				ARG BUILD_DATE

				ARG VERSION="0.7.0"

				LABEL org.opencontainers.image.title="Gitea - Git with a cup of tea"

noerw commented

2021-03-16 13:05:33 +00:00

- LABEL org.opencontainers.image.title="Gitea - Git with a cup of tea"
+ LABEL org.opencontainers.image.title="tea - CLI for Gitea - git with a cup of tea"

```diff - LABEL org.opencontainers.image.title="Gitea - Git with a cup of tea" + LABEL org.opencontainers.image.title="tea - CLI for Gitea - git with a cup of tea" ```

tgerczei marked this conversation as resolved

contrib/Dockerfile Outdated

						
				@ -0,0 +29,4 @@

				LABEL org.opencontainers.image.url="https://gitea.com/gitea/tea"

				LABEL org.opencontainers.image.authors="Tamás Gérczei <tamas@gerczei.eu>"

				LABEL org.opencontainers.image.created="${BUILD_DATE}"

				LABEL org.opencontainers.image.source="https://github.com/tgerczei/conteaner"

noerw commented

2021-03-16 13:06:12 +00:00

- LABEL org.opencontainers.image.source="https://github.com/tgerczei/conteaner"
+ LABEL org.opencontainers.image.source="https://gitea.com/gitea/tea"

```diff - LABEL org.opencontainers.image.source="https://github.com/tgerczei/conteaner" + LABEL org.opencontainers.image.source="https://gitea.com/gitea/tea" ```

tgerczei marked this conversation as resolved

contrib/Dockerfile Outdated

						
				@ -0,0 +30,4 @@

				LABEL org.opencontainers.image.authors="Tamás Gérczei <tamas@gerczei.eu>"

				LABEL org.opencontainers.image.created="${BUILD_DATE}"

				LABEL org.opencontainers.image.source="https://github.com/tgerczei/conteaner"

				LABEL org.opencontainers.image.vendor="Gérczei Tamás E.V."

noerw commented

2021-03-16 13:05:52 +00:00

- LABEL org.opencontainers.image.vendor="Gérczei Tamás E.V."
+ LABEL org.opencontainers.image.vendor="The Gitea Authors"

```diff - LABEL org.opencontainers.image.vendor="Gérczei Tamás E.V." + LABEL org.opencontainers.image.vendor="The Gitea Authors" ```

tgerczei marked this conversation as resolved

noerw added the

kind/build

label 2021-03-16 13:17:24 +00:00

tgerczei added 1 commit 2021-03-16 15:52:30 +00:00

continuous-integration/drone/pr Build is passing

Details

651572c207

updated image labels

tgerczei requested review from noerw 2021-03-16 16:50:09 +00:00

noerw approved these changes 2021-03-16 16:55:25 +00:00

Dismissed

techknowlogick requested changes 2021-03-16 18:16:35 +00:00

Dismissed

techknowlogick left a comment

Blocking as I'd like to review

techknowlogick reviewed 2021-03-16 18:21:55 +00:00

Dismissed

contrib/Dockerfile Outdated

						
				@ -0,0 +1,36 @@

				ARG GOVERSION="1.16.2"

techknowlogick commented

2021-03-16 18:21:55 +00:00

A couple general notes:

This can be place in repo root, as if we can then use drone to build & push
With it being in repo root, a docker COPY can be used rather than a git clone.
Can you use the make command to build?
If we use drone, then some of the labels will be auto-populated
Rather than having a shell script for the build, you can move that into make file.

A couple general notes: * This can be place in repo root, as if we can then use drone to build & push * With it being in repo root, a docker `COPY` can be used rather than a git clone. * Can you use the make command to build? * If we use drone, then some of the labels will be auto-populated * Rather than having a shell script for the build, you can move that into make file.

👍 1

tgerczei marked this conversation as resolved

tgerczei added 2 commits 2021-03-16 19:36:25 +00:00

2d327f5247

moved image build definition to project root, deleted build hook, removed labels included by Drone

6453d631c3

added target 'build-image' to Makefile, will build from local sources, removed build arg 'BUILD_DATE'

tgerczei requested review from techknowlogick 2021-03-16 19:37:00 +00:00

tgerczei added 1 commit 2021-03-16 19:38:17 +00:00

continuous-integration/drone/pr Build is passing

Details

94442dc64f

switched to Docker from podman

techknowlogick reviewed 2021-03-21 21:21:22 +00:00

Dismissed

Dockerfile Outdated

						
				@ -0,0 +11,4 @@

				COPY . $GOPATH/src/

				WORKDIR $GOPATH/src

				RUN	go get -v . && \

techknowlogick commented

2021-03-21 21:21:22 +00:00

could you use a make build here as it will use the vendored libs and wont go out to fetch them again.

tgerczei marked this conversation as resolved

techknowlogick commented

2021-03-21 21:22:52 +00:00

a general question, should this be a rootless container? as some people may wish to run this is environments where root in continers is prohibited.

tgerczei added 1 commit 2021-03-22 07:15:44 +00:00

continuous-integration/drone/pr Build is passing

Details

2b935b75ad

will now produce image via make

tgerczei commented

2021-03-22 07:25:39 +00:00

a general question, should this be a rootless container? as some people may wish to run this is environments where root in continers is prohibited.

Yes, rootless usage is intended. One can pass e.g. '-u $(id -u):$(id -g)' in case a privileged daemon is involved in execution. I personally use podman as an unprivileged user.

> a general question, should this be a rootless container? as some people may wish to run this is environments where root in continers is prohibited. Yes, rootless usage is intended. One can pass e.g. '-u $(id -u):$(id -g)' in case a privileged daemon is involved in execution. I personally use podman as an unprivileged user.

tgerczei added 1 commit 2021-03-22 07:29:18 +00:00

continuous-integration/drone/pr Build is passing

Details

3cefc3298a Merge branch 'master' into master

techknowlogick approved these changes 2021-03-30 05:06:21 +00:00

Dismissed

lunny merged commit 195bd2199c into master

2021-03-30 11:13:24 +00:00

lunny referenced this issue from a commit

2021-03-30 11:13:24 +00:00

contributed container build definition (#350)

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#350

				`@ -0,0 +1,36 @@`
				`ARG GOVERSION="1.16.2"`