contributed container build definition #350
No reviewers
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
4 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/tea#350
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "tgerczei/tea:master"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
as discussed with @noerw on Discord
thank you!
I don't have permission to push to your branch, could adapt the labels as suggested?
Aside: if we are to integrate docker builds with CI (@gitea/Owners ?), we probably want an image that builds from local source instead of pulling from git. I can add that in a followup, not sure if as a replacement or alternative
@ -0,0 +23,4 @@
FROM scratch
ARG BUILD_DATE
ARG VERSION="0.7.0"
LABEL org.opencontainers.image.title="Gitea - Git with a cup of tea"
@ -0,0 +29,4 @@
LABEL org.opencontainers.image.url="https://gitea.com/gitea/tea"
LABEL org.opencontainers.image.authors="Tamás Gérczei <tamas@gerczei.eu>"
LABEL org.opencontainers.image.created="${BUILD_DATE}"
LABEL org.opencontainers.image.source="https://github.com/tgerczei/conteaner"
@ -0,0 +30,4 @@
LABEL org.opencontainers.image.authors="Tamás Gérczei <tamas@gerczei.eu>"
LABEL org.opencontainers.image.created="${BUILD_DATE}"
LABEL org.opencontainers.image.source="https://github.com/tgerczei/conteaner"
LABEL org.opencontainers.image.vendor="Gérczei Tamás E.V."
Blocking as I'd like to review
@ -0,0 +1,36 @@
ARG GOVERSION="1.16.2"
A couple general notes:
COPY
can be used rather than a git clone.@ -0,0 +11,4 @@
COPY . $GOPATH/src/
WORKDIR $GOPATH/src
RUN go get -v . && \
could you use a make build here as it will use the vendored libs and wont go out to fetch them again.
a general question, should this be a rootless container? as some people may wish to run this is environments where root in continers is prohibited.
Yes, rootless usage is intended. One can pass e.g. '-u $(id -u):$(id -g)' in case a privileged daemon is involved in execution. I personally use podman as an unprivileged user.