tea login add with credentials fails when server has REQUIRE_SIGNIN_VIEW = true #365

Closed
opened 2021-05-28 09:17:46 +00:00 by noerw · 0 comments
Member

(workaround: provide a token instead of user/pass)

The issue is that we create a gitea Client without providing credentials
df724b4006/modules/task/login_create.go (L59)
and then gitea/go-sdk#517 happens

Fixing this would be a nice opportunity for a refactor: avoid recreating a client via login.Client() whenever we want to access it (this call can take some time, as it already talks to the server), and make it a member of TeaContext instead. This needs some thought wrt concurrency/locking, but should be solvable

(workaround: provide a token instead of user/pass) The issue is that we create a gitea `Client` without providing credentials https://gitea.com/gitea/tea/src/commit/df724b40064c62883c5466eea2dc50683fc823cf/modules/task/login_create.go#L59 and then https://gitea.com/gitea/go-sdk/issues/517 happens Fixing this would be a nice opportunity for a refactor: avoid recreating a client via `login.Client()` whenever we want to access it (this call can take some time, as it already talks to the server), and make it a member of `TeaContext` instead. This needs some thought wrt concurrency/locking, but should be solvable
noerw added the
kind/bug
kind
refactor
labels 2021-05-28 09:17:46 +00:00
noerw added this to the v0.8.0 milestone 2021-06-23 13:02:39 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#365
No description provided.