--repo flag skips reading the local repo #378

Closed
opened 2021-07-08 20:19:29 +00:00 by noerw · 1 comment
Member

Commands that require a local repo (such as tea pr create), don't work when an override for the remote repo is specified:

$ tea pr create --repo foo/bar # goal: create a PR in a different repo

Local repository required: Execute from a repo dir, or specify a path with --repo.

ref #377 (comment)


that said, tea pr create should still work without a local repo. local repo should just be used to find a default for the head branch when available

Commands that require a local repo (such as `tea pr create`), don't work when an override for the remote repo is specified: ``` $ tea pr create --repo foo/bar # goal: create a PR in a different repo Local repository required: Execute from a repo dir, or specify a path with --repo. ``` ref https://gitea.com/gitea/tea/issues/377#issuecomment-441849 --- that said, `tea pr create` should still work without a local repo. local repo should just be used to find a default for the head branch when available
noerw added the
kind/bug
label 2021-07-08 20:19:29 +00:00
noerw added this to the v0.8.0 milestone 2021-07-08 20:19:33 +00:00
Author
Member

the specific issue with tea pr create has been adressed.

the remaining issue here is caused by a change from #327:

if len(repoFlag) == 0 || repoFlagPathExists {

Not sure what this was about, need to check the testcases in #320 without this if statement..

the specific issue with `tea pr create` has been adressed. the remaining issue here is caused by a change from #327: https://gitea.com/gitea/tea/src/commit/3fca309f2c60045ccb2798f84d1314684783eace/modules/context/context.go#L102 Not sure what this was about, need to check the testcases in #320 without this if statement..
6543 closed this issue 2021-09-22 15:48:21 +00:00
6543 reopened this issue 2021-09-22 15:48:57 +00:00
6543 closed this issue 2021-09-22 16:12:57 +00:00
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#378
No description provided.