gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Implement notification subcommands #389

Merged
6543 merged 20 commits from noerw/tea:notification-subcmds into master 2021-09-05 17:11:17 +00:00
Conversation 2 Commits 20 Files Changed 11 +363 -116
noerw commented 2021-08-24 02:30:38 +00:00
Member
Copy Link
  • enhance notification listing
    • add --states and --type filters
    • toggle per-user or per-repo listing via --mine flag
    • print more fields
  • add subcommands to mark notifications as read, unread, pinned, unpinned. operates on
    • all notifications matching the --state and --mine filter flags, or
    • a notification specified by ID.
  • add a --fields flag for notifications listing. not in this PR
  • interactive mode not in this PR. this would go well together with #324

fixes #243, fixes #155

based on initial work in #283 and #386, but opening a new PR for @6543 to review as I changed quite a lot

⚠️ breaking ⚠️

  • tea notifications --all has moved to tea notifications --mine
  • tea notifications now only works with the context of a remote repo.
    To run this outside of a local git dir, run either tea n --mine or tea n --repo <my/repo>

aside: while developing i discovered a couple of issues with the notifications APIs:

- [x] enhance notification listing - add `--states` and `--type` filters - toggle per-user or per-repo listing via `--mine` flag - print more fields - [x] add subcommands to mark notifications as read, unread, pinned, unpinned. operates on - all notifications matching the `--state` and `--mine` filter flags, or - a notification specified by ID. - [ ] ~~add a `--fields` flag for notifications listing.~~ *not in this PR* - [ ] ~~interactive mode~~ *not in this PR*. this would go well together with #324 fixes #243, fixes #155 based on initial work in #283 and #386, but opening a new PR for @6543 to review as I changed quite a lot --- ### ⚠️ breaking ⚠️ - `tea notifications --all` has moved to `tea notifications --mine` - `tea notifications` now only works with the context of a remote repo. To run this outside of a local git dir, run either `tea n --mine` or `tea n --repo <my/repo>` --- aside: while developing i discovered a couple of issues with the notifications APIs: - https://github.com/go-gitea/gitea/issues/16733 - https://github.com/go-gitea/gitea/issues/16796 - https://github.com/go-gitea/gitea/issues/16797
👍 1
noerw added this to the v0.8.0 milestone 2021-08-24 02:30:38 +00:00
noerw added the
kind
feature
 label 2021-08-24 02:30:38 +00:00
noerw added 18 commits 2021-08-24 02:30:39 +00:00
add subcomands for notifications 
Fix #243

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
74047bee0d
Fixed exported function comments. 
Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
f978713928
Integrated review comments. 
Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
91b5db3e42
Moved notifications_list from task into cmd/notifications 
Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
481132ffdb
WIP - Improved.
Some checks failed
continuous-integration/drone/pr Build is failing
Details
abd32a7074
code dedub
All checks were successful
continuous-integration/drone/pr Build is passing
Details
be0e857273
Next dedub
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0f12c0a77f
Merge branch 'master' into add-subcomands-for-notifications_rebase283
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e52b2678a9
refactor FieldsFlag as CsvFlag for reusability 
to be used in --state + --type of notifications listing
5ee01374bf
rename --for-user flag to --mine for consistency 
with `tea time --mine`. also move the flag to the list subcommand only,
as it's not needed for the other subcmds
4acda8d111
print notification id 
to be able to mark single notifications
Some checks failed
continuous-integration/drone/pr Build is failing
Details
8414c23ed5
noerw requested review from 6543 2021-08-24 02:30:49 +00:00
noerw added 1 commit 2021-08-24 02:53:34 +00:00
lint
All checks were successful
continuous-integration/drone/pr Build is passing
Details
4b87414787
6543 added 1 commit 2021-09-05 15:24:35 +00:00
Merge branch 'master' into notification-subcmds
All checks were successful
continuous-integration/drone/pr Build is passing
Details
526e665e51
6543 commented 2021-09-05 15:38:40 +00:00
Owner
Copy Link

nice refactor and works great!

one thing: why did you rename --all to --mine ?

nice refactor and works great! one thing: why did you rename `--all` to `--mine` ?
6543 commented 2021-09-05 16:03:59 +00:00
Owner
Copy Link

☝️ noerw: "... for consistency with `tea time --mine` ..."

I can live with that ;)

☝️ ``` noerw: "... for consistency with `tea time --mine` ..." ``` I can live with that ;)
6543 approved these changes 2021-09-05 16:04:09 +00:00
noerw added the
kind/breaking
 label 2021-09-05 16:09:01 +00:00
axifive approved these changes 2021-09-05 17:09:09 +00:00
axifive left a comment
Member
Copy Link

looks good

looks good
6543 merged commit 5b28a05eb7 into master 2021-09-05 17:11:17 +00:00
6543 deleted branch notification-subcmds 2021-09-05 17:11:18 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
axifive
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.8.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#389
No description provided.
Delete Branch "noerw/tea:notification-subcmds"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?