gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 17 Actions Releases 16 Activity

added global appendable Flags (#12) #39

Merged
techknowlogick merged 18 commits from :12_global_cli_flags into master 2019-10-23 15:58:21 +00:00
Conversation 11 Commits 18 Files Changed 5 +116 -98
root360-AndreasUlm commented 2019-06-22 16:00:10 +00:00
Contributor
Copy Link
No description provided.
lunny commented 2019-06-23 00:48:51 +00:00
Owner
Copy Link

Replaced #26

Replaced #26
lunny added the
kind
enhancement
 label 2019-06-23 00:49:11 +00:00
lunny added this to the v0.1.0 milestone 2019-06-23 00:49:12 +00:00
lunny requested changes 2019-06-27 07:32:11 +00:00
Dismissed
cmd/issues.go Outdated
@ -36,3 +29,1 @@
Usage: "Indicate one repository, optional when inside a gitea repository",
},
},
Flags: RepoDefaultFlags,
lunny commented 2019-06-27 07:32:06 +00:00
Owner
Copy Link

Output should not be added in this sub command.

Output should not be added in this sub command.
root360-AndreasUlm commented 2019-09-14 20:22:25 +00:00
Author
Contributor
Copy Link

fixed remarks of @lunny

fixed remarks of @lunny
lunny commented 2019-09-15 02:36:08 +00:00
Owner
Copy Link

If this PR depends on #40 ?

If this PR depends on #40 ?
root360-AndreasUlm commented 2019-09-15 07:45:19 +00:00
Author
Contributor
Copy Link

Yes, we should first merge #40 and then I'll update this PR accordingly.

Yes, we should first merge #40 and then I'll update this PR accordingly.
root360-AndreasUlm commented 2019-09-15 20:09:12 +00:00
Author
Contributor
Copy Link

Changes with last commits:

  • rebased to latest master
  • renamed defined flag-lists to represent the flags activated
  • updated commands to use renamed flags
  • added --repo & --login to main.go to allow setting flag directly after tea: tea -l test -r test/test releases
Changes with last commits: * rebased to latest master * renamed defined flag-lists to represent the flags activated * updated commands to use renamed flags * added --repo & --login to main.go to allow setting flag directly after tea: `tea -l test -r test/test releases`
lunny reviewed 2019-09-17 03:34:26 +00:00
Dismissed
main.go Outdated
lunny commented 2019-09-17 03:34:26 +00:00
Owner
Copy Link

Is this necessary since we have added LoginRepoFlags on sub commands?

Is this necessary since we have added `LoginRepoFlags` on sub commands?
root360-AndreasUlm reviewed 2019-09-17 05:08:44 +00:00
Dismissed
main.go Outdated
root360-AndreasUlm commented 2019-09-17 05:08:44 +00:00
Author
Contributor
Copy Link

Depends on the intended feel of the command.
If we want to allow some flags to be set everywhere (tea -l pulls == tea pulls -l), we must add this otherwise it's not necessary.

Depends on the intended feel of the command. If we want to allow some flags to be set everywhere (`tea -l pulls` == `tea pulls -l`), we must add this otherwise it's not necessary.
lunny commented 2019-10-19 10:55:09 +00:00
Owner
Copy Link

Please resolve the conflicts.

Please resolve the conflicts.
root360-AndreasUlm commented 2019-10-19 17:09:31 +00:00
Author
Contributor
Copy Link

@lunny: resolved conflicts and removed flags from main.go

@lunny: resolved conflicts and removed flags from main.go
lunny approved these changes 2019-10-23 15:21:19 +00:00
Dismissed
zeripath approved these changes 2019-10-23 15:23:09 +00:00
Dismissed
6543 commented 2019-10-23 15:34:16 +00:00
Owner
Copy Link

make lgtm work?

make lgtm work?
techknowlogick approved these changes 2019-10-23 15:52:53 +00:00
Dismissed
techknowlogick closed this pull request 2019-10-23 15:58:21 +00:00
6543 commented 2019-10-23 18:10:35 +00:00
Owner
Copy Link

@techknowlogick was there a ned for 3 aprovals?!?

@techknowlogick was there a ned for 3 aprovals?!?
6543 commented 2019-10-23 18:10:35 +00:00
Owner
Copy Link

@techknowlogick was there a ned for 3 aprovals?!?

@techknowlogick was there a ned for 3 aprovals?!?
6543 commented 2019-10-23 18:31:33 +00:00
Owner
Copy Link

... read the conversation in discort ... OK

... read the conversation in discort ... OK
root360-AndreasUlm deleted branch 12_global_cli_flags 2019-10-25 13:41:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.1.0
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#39
No description provided.
Delete Branch ":12_global_cli_flags"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?