gitea/tea
gitea/tea
56
128
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Don't require a body for comment PR reviews #399

Merged
zeripath merged 3 commits from noerw/tea:fix/372 into master 2021-09-22 18:18:26 +00:00
Conversation 2 Commits 3 Files Changed 1 +1 -1
noerw commented 2021-09-13 19:24:26 +00:00
Member
Copy Link

fixes #372

fixes #372
noerw added this to the v0.8.0 milestone 2021-09-13 19:24:26 +00:00
noerw added the
kind
enhancement
upstream/gitea
 labels 2021-09-13 19:24:26 +00:00
noerw added 1 commit 2021-09-13 19:24:27 +00:00
dont require a body for comment PR reviews
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1d79f6409d
noerw added 1 commit 2021-09-14 13:58:20 +00:00
Merge branch 'master' into fix/372
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ff0fcf7a03
6543 modified the milestone from v0.8.0 to v0.9.0 2021-09-21 23:58:09 +00:00
6543 added the
status/blocked
 label 2021-09-21 23:58:15 +00:00
6543 commented 2021-09-21 23:58:42 +00:00
Owner
Copy Link

gitea's ui also cant do that - this has to be canged everywhere ...

gitea's ui also cant do that - this has to be canged everywhere ...
noerw commented 2021-09-22 09:21:03 +00:00
Author
Member
Copy Link

@6543 According to https://github.com/go-gitea/gitea/pull/16229 it does work, thus the change to the API was made.

@6543 According to https://github.com/go-gitea/gitea/pull/16229 it does work, thus the change to the API was made.
noerw reviewed 2021-09-22 09:28:05 +00:00
modules/interact/pull_review.go
@ -53,3 +53,3 @@
// comment
var promptOpts survey.AskOpt
if state == gitea.ReviewStateComment || state == gitea.ReviewStateRequestChanges {
if (state == gitea.ReviewStateComment && len(codeComments) == 0) || state == gitea.ReviewStateRequestChanges {
noerw commented 2021-09-22 09:28:01 +00:00
Author
Member
Copy Link

this is a test using the webui to verify my claim in #399 (comment)

this is a test using the webui to verify my claim in https://gitea.com/gitea/tea/pulls/399#issuecomment-592704
6543 commented 2021-09-22 15:51:21 +00:00
Owner
Copy Link

well I'm ok with it - since the gitea will have the last word anyway ...

well I'm ok with it - since the gitea will have the last word anyway ...
6543 removed the
status/blocked
upstream/gitea
 labels 2021-09-22 15:50:52 +00:00
6543 approved these changes 2021-09-22 15:51:30 +00:00
6543 modified the milestone from v0.9.0 to v0.8.0 2021-09-22 15:51:36 +00:00
6543 added 1 commit 2021-09-22 16:14:14 +00:00
Merge branch 'master' into fix/372
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d1492edc19
zeripath approved these changes 2021-09-22 18:18:18 +00:00
zeripath merged commit 802bdf7dc5 into master 2021-09-22 18:18:26 +00:00
6543 deleted branch fix/372 2021-09-22 18:31:47 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
zeripath
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.8.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#399
No description provided.
Delete Branch "noerw/tea:fix/372"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?