support tea releases create with asset upload #4

Closed
opened 2018-12-03 15:32:40 +00:00 by lunny · 3 comments
Owner

Author: @noerw

I'm happy to provide a pull request implementing this functionality, but want to find consensus on the command line interface first.

I'd prefer a command like this:

tea releases create --tag v1.0 --target master -t v1.0 --asset artifact1.zip --asset artifact2

But I saw that in the HTTP API assets are handled in a separate endpoint. Would the API described above be fine anyway?

Author: @noerw I'm happy to provide a pull request implementing this functionality, but want to find consensus on the command line interface first. I'd prefer a command like this: ``` tea releases create --tag v1.0 --target master -t v1.0 --asset artifact1.zip --asset artifact2 ``` But I saw that in the HTTP API assets are handled in a separate endpoint. Would the API described above be fine anyway?
Author
Owner

Author: @lunny

Please send your pull request, maintainers will review it.

Author: @lunny Please send your pull request, maintainers will review it.
Author
Owner

Author: @simbo1905

The GitHub CLI hub release might provide some inspiration as to what the api could look like. For example you are suggesting creation a release from master which is a moving target; someone might push a broken commit just at the instance you are releasing. So the hub tool takes a “commitish” as the target such as a sha hash for a commit. By taking inspiration from that mature tool it will make it easier for people to write release automation scripts that are easy to migrate from other git servers onto gitea.

Author: @simbo1905 The GitHub CLI [hub release](https://hub.github.com/hub-release.1.html) might provide some inspiration as to what the api could look like. For example you are suggesting creation a release from master which is a moving target; someone might push a broken commit just at the instance you are releasing. So the hub tool takes a “commitish” as the target such as a sha hash for a commit. By taking inspiration from that mature tool it will make it easier for people to write release automation scripts that are easy to migrate from other git servers onto gitea.
Author
Owner

Author: @noerw

was implemented with #6

Author: @noerw was implemented with #6
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#4
No description provided.