Bug: tea release create -- "title is empty" #483

New Issue

MrMelon54 · 2022-05-10T14:30:59Z

MrMelon54 commented

2022-05-10 14:30:59 +00:00

describe your environment

tea version used (tea -v): v0.8.0
- I also reproduced the issue with the latest master build
Gitea version used:
- the issue only occurred after updating gitea recently
operating system: debian
I make use of...
- non-standard default branch names (no main,master, or trunk)
- .ssh/config or .gitconfig host aliases in my git remotes
- ssh_agent or similar
- non-standard ports for gitea and/or ssh
- something else that's likely to interact badly with tea: ...

Please provide the output of git remote -v (if the issue is related to tea not finding resources on Gitea):

describe the issue (observed vs expected behaviour)

Expected:

tea r c v1.0.0 -t "My title"
should create a new release for v1.0.0

Observed:

tea r c v1.0.0 -t "My title"
"Error: title is empty"

### describe your environment - tea version used (`tea -v`): v0.8.0 - [x] I also reproduced the issue [with the latest master build](https://dl.gitea.io/tea/master) - Gitea version used: - [ ] the issue only occurred after updating gitea recently - operating system: debian - I make use of... - [ ] non-standard default branch names (no `main`,`master`, or `trunk`) - [ ] .ssh/config or .gitconfig host aliases in my git remotes - [ ] ssh_agent or similar - [ ] non-standard ports for gitea and/or ssh - [ ] something else that's likely to interact badly with tea: ... Please provide the output of `git remote -v` (if the issue is related to tea not finding resources on Gitea): ``` ``` ### describe the issue (observed vs expected behaviour) Expected: - `tea r c v1.0.0 -t "My title"` - should create a new release for v1.0.0 Observed: - `tea r c v1.0.0 -t "My title"` - "Error: title is empty"

MrMelon54 added the

kind/bug

label 2022-05-10 14:30:59 +00:00

MrMelon54 commented

2022-05-10 14:37:03 +00:00

I tested the command a bit more and figured out that the following works:

tea r c --tag v1.0.0 --target master -t "My title"

The error message obviously is very confusing and thus my issue still stands

I tested the command a bit more and figured out that the following works: `tea r c --tag v1.0.0 --target master -t "My title"` The error message obviously is very confusing and thus my issue still stands

👀 1

6543 commented

2022-05-14 22:09:45 +00:00

can you try: go install code.gitea.io/tea@02f5f15269e2e06f260eb1e7ea27f3387929b013
☝️ install current master version

and test if issue still exist?

can you try: `go install code.gitea.io/tea@02f5f15269e2e06f260eb1e7ea27f3387929b013` ☝️ install current master version and test if issue still exist?

MrMelon54 commented

2022-05-14 22:17:26 +00:00

Issue still occurs when using the master version

Also tea r c v1.0.0 should probably do an interactive thing like gh does

Issue still occurs when using the master version Also `tea r c v1.0.0` should probably do an interactive thing like `gh` does

👍 1

6543 commented

2022-05-14 22:35:32 +00:00

thank's for checking :)

6543 added this to the v0.9.0 milestone 2022-05-14 22:35:37 +00:00

noerw commented

2022-06-20 12:51:06 +00:00

tea r c v1.0.0 will never work - this command does not take arguments. The docs should be clearer about this, and maybe there should be an error about unexpected arguments?
the 'title is empty' error comes from code.gitea.io/go-sdk, I don't get why this is triggered when a title is actually set.

- `tea r c v1.0.0` will never work - this command does not take arguments. The docs should be clearer about this, and maybe there should be an error about unexpected arguments? - the 'title is empty' error comes from [code.gitea.io/go-sdk](https://gitea.com/gitea/go-sdk/src/commit/359c771ce3d2f8e9f8e48be37a9f79cdb92a6c88/gitea/release.go#L108-L110), I don't get why this is triggered when a title is actually set.

noerw added the

kind/docs

upstream/sdk

labels 2022-06-20 12:51:24 +00:00

noerw referenced a pull request that will close this issue

2022-08-26 15:45:17 +00:00

Clarify command descriptions when no arguments are taken #496

noerw commented

2022-08-26 15:50:57 +00:00

#496 changes the command help of commands without arguments to be more clear.
#496 also allows the syntax tea r c <tag>
the invocation that remains broken is tea r c v1.0.0 -t "My title". this is due to the fact that our flag parsing library ignores flags placed after the first non-flag argument. this is a wontfix until we switch away from github.com/urfave/cli/v2, which in general has horrible ergonomics. hopefully there soon is work in progress for a v3 release that fixes this and other issues

- #496 changes the command help of commands without arguments to be more clear. - #496 also allows the syntax `tea r c <tag>` - the invocation that remains broken is `tea r c v1.0.0 -t "My title"`. this is due to the fact that our flag parsing library ignores flags placed after the first non-flag argument. this is a wontfix until we switch away from `github.com/urfave/cli/v2`, which in general has horrible ergonomics. hopefully there soon is [work in progress for a v3 release](https://github.com/urfave/cli/issues/1113#issuecomment-1214475136) that fixes this and other issues

6543 referenced this issue from a commit

2022-09-13 18:14:03 +00:00

Clarify command descriptions when no arguments are taken (#496)

6543 closed this issue

2022-09-13 18:14:03 +00:00

Sign in to join this conversation.

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#483