gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 17 Actions Releases 16 Activity

Add tea issue edit #506

Merged
lunny merged 14 commits from noerw/tea:edit-issue into main 2022-10-25 00:40:00 +00:00
Conversation 0 Commits 14 Files Changed 7 +293 -20
noerw commented 2022-09-14 11:24:04 +00:00
Member
Copy Link

fixes #229
fixes #502

interactive mode will be in a follow up

fixes #229 fixes #502 interactive mode will be in a follow up
noerw added this to the v0.10.0 milestone 2022-09-14 11:24:04 +00:00
noerw added the
kind
feature
 label 2022-09-14 11:24:04 +00:00
noerw added 4 commits 2022-09-14 11:24:05 +00:00
refactor & rename old IssuePREditFlags → IssuePRCreateFlags 
as they were in fact used for issue/pr creation
863e4ce940
add task.EditIssue() 
this uses a custom options struct, as the API & SDK interfaces are
quite messy.
f789a803c8
fix bug with RemoveLabels() 
interestingly the add-labels & issue creation APIs don't have this issue
2d7182e7c3
add tea issue edit
Some checks failed
continuous-integration/drone/pr Build is failing
Details
76a6f25d30
noerw added 1 commit 2022-09-14 11:28:49 +00:00
Merge branch 'main' into edit-issue
Some checks failed
continuous-integration/drone/pr Build is failing
Details
0afdc6a250
6543 added 1 commit 2022-09-14 19:01:37 +00:00
Merge branch 'main' into edit-issue
Some checks failed
continuous-integration/drone/pr Build is failing
Details
16033ce221
6543 requested review from 6543 2022-09-14 20:44:32 +00:00
noerw added 1 commit 2022-09-14 22:40:21 +00:00
fix lint
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e5dc0de449
noerw reviewed 2022-09-20 14:59:11 +00:00
noerw reviewed 2022-09-20 14:59:50 +00:00
modules/task/issue_edit.go Outdated
@ -0,0 +48,4 @@
}
issueOpts := gitea.EditIssueOption{}
var issueOptsDirty = true
noerw commented 2022-09-20 14:59:50 +00:00
Author
Member
Copy Link
-	var issueOptsDirty = true
+	var issueOptsDirty = false
```diff - var issueOptsDirty = true + var issueOptsDirty = false ```
noerw marked this conversation as resolved
noerw reviewed 2022-09-21 16:47:35 +00:00
modules/task/issue_edit.go Outdated
@ -0,0 +63,4 @@
}
if o.Milestone != nil {
if *o.Milestone == "" {
var tmp int64
noerw commented 2022-09-21 16:47:35 +00:00
Author
Member
Copy Link

use gitea.OptionalInt64() instead

use `gitea.OptionalInt64()` instead
noerw marked this conversation as resolved
noerw added 1 commit 2022-09-21 17:00:03 +00:00
fixes / refactor
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1b41e0c212
6543 added 1 commit 2022-09-26 20:36:54 +00:00
Merge branch 'main' into edit-issue
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2d7a38a2ad
6543 reviewed 2022-09-26 20:39:13 +00:00
cmd/issues/edit.go Outdated
@ -0,0 +44,4 @@
indices := make([]int64, ctx.Args().Len())
for i, arg := range ctx.Args().Slice() {
var err error
if indices[i], err = utils.ArgToIndex(arg); err != nil {
6543 commented 2022-09-26 20:39:13 +00:00
Owner
Copy Link
indices, err := utils.ArgsToIndices(ctx.Args().Slice())
```go indices, err := utils.ArgsToIndices(ctx.Args().Slice()) ```
6543 marked this conversation as resolved
6543 added 1 commit 2022-09-26 20:44:14 +00:00
use utils.ArgsToIndices
Some checks reported errors
continuous-integration/drone/pr Build was killed
Details
b5fdb59852
6543 added 1 commit 2022-09-26 21:14:37 +00:00
handle err
All checks were successful
continuous-integration/drone/pr Build is passing
Details
0fa5d96f2b
6543 approved these changes 2022-09-26 21:48:32 +00:00
6543 added 1 commit 2022-09-27 15:48:35 +00:00
Merge branch 'main' into edit-issue
All checks were successful
continuous-integration/drone/pr Build is passing
Details
40b68a02a8
noerw added 1 commit 2022-09-29 11:18:40 +00:00
Merge branch 'main' into edit-issue
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b235b1ba22
6543 requested review from Maintainers 2022-09-29 12:38:43 +00:00
6543 added 1 commit 2022-10-24 22:39:28 +00:00
Merge branch 'main' into edit-issue
All checks were successful
continuous-integration/drone/pr Build is passing
Details
c3d7e4e813
lunny approved these changes 2022-10-25 00:39:51 +00:00
lunny merged commit 2a8c1daa67 into main 2022-10-25 00:40:00 +00:00
lunny referenced this issue from a commit 2022-10-25 00:40:00 +00:00
Add `tea issue edit` (#506)
noerw deleted branch edit-issue 2023-02-16 17:05:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
lunny
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.10.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#506
No description provided.
Delete Branch "noerw/tea:edit-issue"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?