Add Allow Maintainer Edits #509
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Depends on
#606 Update PullRequest struct
gitea/go-sdk
Reference: gitea/tea#509
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "6543/tea:add_allow-maintainer-edits"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
close #508
Add Allow Maintainer Editsto WIP: Add Allow Maintainer Edits@ -34,6 +35,7 @@ func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview, ciStatus *g
FormatTime(*pr.Created, false),
base,
head,
// TODO: pr.AllowMaintainerEdit,
just another sdk update ...
@ -49,6 +52,11 @@ func CreatePull(ctx *context.TeaContext) (err error) {
return err
}
promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false}
Also maybe default to true?
@ -69,2 +71,4 @@
}
if allowMaintainerEdits {
pr, _, err = client.EditPullRequest(ctx.Owner, ctx.Repo, pr.ID, gitea.EditPullRequestOption{
pr.Index
WIP: Add Allow Maintainer Editsto Add Allow Maintainer Edits@ -65,2 +65,4 @@
}
if pr.AllowMaintainerEdit {
out += "- Maintainers are allowed to edit"
isn't this missing a newline?
One nit, otherwise LGTM
I'm approving, but is there no idea about automated testcases for the tea command ?
@strk sadly no :/
-> #504