Find DefaultPRHead based on branch and SHA #514

Merged
6543 merged 4 commits from 6543/tea:enhance_find-remote-of-branch into main 2022-10-24 22:38:39 +00:00
Owner

enhance

enhance
6543 added this to the v0.10.0 milestone 2022-09-26 22:42:42 +00:00
6543 added the
kind
enhancement
label 2022-09-26 22:42:42 +00:00
6543 added 1 commit 2022-09-26 22:42:43 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
b83875ae41
Find DefaultPRHead based on branch and SHA
6543 requested review from Maintainers 2022-09-27 11:30:16 +00:00
Member

Can you describe which case is enhanced with this?

This might give wrong / ambiguous results, I think that was the reason I did not pass the sha in:
Did you test what happens when you pass a sha to TeaFindBranchRemote() that is on multiple branches? Which branch / remote will be selected? Or can't this case occur?

Can you describe which case is enhanced with this? This might give wrong / ambiguous results, I think that was the reason I did not pass the sha in: Did you test what happens when you pass a sha to `TeaFindBranchRemote()` that is on multiple branches? Which branch / remote will be selected? Or can't this case occur?
6543 added 1 commit 2022-09-27 12:07:27 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
757bd0cb72
TeaFindBranchRemote() make specific priority order
first match of sha and branch -> first match of branch -> first match of sha
Author
Owner

@noerw added specific priority order

@noerw added specific priority order
strk approved these changes 2022-09-27 15:29:47 +00:00
strk left a comment
Member

Approving, but no testcase here ?

Approving, but no testcase here ?
Author
Owner

I might could add unit test for this func ...

I might could add unit test for this func ...
6543 added 1 commit 2022-09-27 15:45:07 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
8742cbbed8
Merge branch 'main' into enhance_find-remote-of-branch
6543 added 1 commit 2022-09-29 02:59:30 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
264c92e31c
Merge branch 'main' into enhance_find-remote-of-branch
Member

I can't observe a difference in behaviour. Again, can you clarify what case is better handled with this? When the local branch is named differently than the remote branch?

I can't observe a difference in behaviour. Again, can you clarify what case is better handled with this? When the local branch is named differently than the remote branch?
Author
Owner

I do work with multiple remotes so I do see difference in behavior.

e.g. this pull was created with tea with this patch...

I do work with multiple remotes so I do see difference in behavior. e.g. this pull was created with tea with this patch...
Author
Owner

... but let's make it wip and I see how i can add tests

... but let's make it wip and I see how i can add tests
6543 added the
status/wip
label 2022-09-29 12:40:47 +00:00
noerw approved these changes 2022-09-29 20:12:49 +00:00
Member

I still don't get the exact context where this helps, but it doesn't seem to break anything :)

I still don't get the exact context where this helps, but it doesn't seem to break anything :)
noerw requested changes 2022-09-29 20:17:10 +00:00
noerw left a comment
Member

never mind, this breaks the default values for me after further testing:

ignore me, i'm tired. I tested with detached head, that's not supposed to set default values.

~~never mind, this breaks the default values for me after further testing:~~ ignore me, i'm tired. I tested with detached head, that's not supposed to set default values.
noerw approved these changes 2022-09-29 20:20:19 +00:00
6543 removed the
status/wip
label 2022-10-24 22:38:26 +00:00
6543 merged commit 54b535a527 into main 2022-10-24 22:38:39 +00:00
6543 deleted branch enhance_find-remote-of-branch 2022-10-24 22:38:40 +00:00
Sign in to join this conversation.
No description provided.