Find DefaultPRHead based on branch and SHA #514
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/tea#514
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "6543/tea:enhance_find-remote-of-branch"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
enhance
Can you describe which case is enhanced with this?
This might give wrong / ambiguous results, I think that was the reason I did not pass the sha in:
Did you test what happens when you pass a sha to
TeaFindBranchRemote()
that is on multiple branches? Which branch / remote will be selected? Or can't this case occur?@noerw added specific priority order
Approving, but no testcase here ?
I might could add unit test for this func ...
I can't observe a difference in behaviour. Again, can you clarify what case is better handled with this? When the local branch is named differently than the remote branch?
I do work with multiple remotes so I do see difference in behavior.
e.g. this pull was created with tea with this patch...
... but let's make it wip and I see how i can add tests
I still don't get the exact context where this helps, but it doesn't seem to break anything :)
never mind, this breaks the default values for me after further testing:ignore me, i'm tired. I tested with detached head, that's not supposed to set default values.