add tea times
command #54
No reviewers
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Depends on
#198 update TrackedTimes structs (#196)
gitea/go-sdk
#235 Changelog v0.11.0
gitea/go-sdk
Reference: gitea/tea#54
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "noerw/tea:50-cmd-times"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
As proposed in #50
TODO
--from
,--to
flags as filters onTrackedTime.Created
vendor new dependency
araddon/dateparse
help needed, don't know how. put it in the README maybe?runmake vendor
!don't show internal IDs, but proper user facing names / IDs:
For some reason the API returns internal IssueID & UserID, instead of IssueIndex & UserName.
I feel like it shouldn't be the clients job to resolve each of these internal IDs, so we might need an API change here?
delete times / reset issue: missing functions in go-sdk, so I skipped that one
I would wait for https://github.com/go-gitea/gitea/issues/8833 and it's stable upstream api
status update: https://github.com/go-gitea/gitea/pull/9200 WIP ...
status update: 9200 is ready, need reviews
side notes:
-> maby add general function(s) for this? as it could be used in other tea routines
@noerw now nothing is blocking this PR anymore
Is this still wip?
Yes,
if we're to add the gitea version check as proposed by @6543 in order to enable this feature, we're still blocked by #78 (since
ServerVersion()
is broken in the old vendored version of the go-sdk)@noerw new go-sdk merged
WIP: add `tea times` commandto add `tea times` command@6543 @lunny This is ready now:
Updated to latest master, version check is implemented, from/to filters are implemented client-side.
@ -35,6 +36,27 @@ type Login struct {
Insecure bool `yaml:"insecure"`
}
// Checks the logins server against a version constraint such as ">= 1.11.0+dev"
Build is failing due to this comment, it should start with
CheckServerVersionConstraint
@noerw would be nice if you wold make code refactor in seperate PR next time :)
plreace split PR next time!
@6543 its there:
But I agree this solution is messy (always need to quote
'#54'
to avoid a bash comment).We could do a more explicit variant with
--user
and--issue
flags.Testing
tea times '#54'
on this issue reveals that I can only list my own times on this issue, 6543s do not show up.Is that intended / desired behaviour?
@noerw no leave it like that we have enouth --options
@noerw it is, since you are no repoAdmin
... ok UI show this ... maby we should export this too :/
"This pull request has changes conflicting with the target branch."
@noerw I thin you have to rebase this PR ...
@noerw can you update to the latest sdk version?
v0.11.0
it also support deleting issues:
Client.ResetIssueTime(owner, repo string, index int64)
Client.DeleteTime(owner, repo string, index, timeID int64)
added in gitea/go-sdk#210
update sdk to v0.11.0
Ok, finally found some time to finalize this:
master
delete
&reset
subcommands@6543
CI failed but I think #98 will fix that.
@ -33,2 +32,2 @@
Name: "save, s",
Usage: "Save all the labels as a file",
&cli.StringFlag{
Name: "save, s",
can you remove the
s
there?done
one nit
can you merge master in? or update this branch?