gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

update dependencies #78

Closed
noerw wants to merge 2 commits from noerw:update-deps into main
pull from: noerw:update-deps
merge into: gitea:main
Conversation 10 Commits 2 Files Changed 347 +68639 -43609
noerw commented 2019-12-17 19:30:58 +00:00
Member
Copy Link

Update all dependencies (as I didnt find a way to update specific vendored modules). For example, this pulls the last 12 months of changes of go-sdk as will be needed for #54 ;)
Manual testing (in lack of a proper test suite) of all commands didn't reveal any obious problems.

GO111MODULE=on go get -u
make vendor
git add .
git commit

We could add a make task for this..

Update all dependencies (as I didnt find a way to update specific vendored modules). For example, this pulls the last 12 months of changes of `go-sdk` as will be needed for #54 ;) Manual testing (in lack of a proper test suite) of all commands didn't reveal any obious problems. ``` GO111MODULE=on go get -u make vendor git add . git commit ``` We could add a `make` task for this..
noerw commented 2019-12-17 19:41:12 +00:00
Author
Member
Copy Link

Can't see in the build log why the build failed..?

Can't see in the build log why the build failed..?
techknowlogick commented 2019-12-17 20:32:22 +00:00
Owner
Copy Link

The error is: Please run 'make vendor' and commit the result:

The error is: `Please run 'make vendor' and commit the result:`
noerw commented 2019-12-17 21:44:08 +00:00
Author
Member
Copy Link

That's what I did.. (see above) ? Rerunning make vendor does nothing

That's what I did.. (see above) ? Rerunning `make vendor` does nothing
techknowlogick commented 2019-12-17 22:38:12 +00:00
Owner
Copy Link

Which version of golang are you running? Perhaps if you are running go1.12 something has changed with how go1.13 generates the files?

Which version of golang are you running? Perhaps if you are running go1.12 something has changed with how go1.13 generates the files?
noerw commented 2019-12-17 22:59:20 +00:00
Author
Member
Copy Link

On the machine where I commited, I run go 1.12.13.
Just reran the above commands on another machine with go 1.13.5, and the results are indeed different.
Lets try

On the machine where I commited, I run go 1.12.13. Just reran the above commands on another machine with go 1.13.5, and the results are indeed different. Lets try
noerw commented 2019-12-31 10:43:16 +00:00
Author
Member
Copy Link

Can we rerun the tests? Seems to be a network timeout issue during build

Can we rerun the tests? Seems to be a network timeout issue during build
👍 1
lunny commented 2020-01-01 00:48:42 +00:00
Owner
Copy Link

@noerw done.

@noerw done.
6543 approved these changes 2020-01-01 15:39:44 +00:00
Dismissed
6543 added a new dependency 2020-01-01 15:41:03 +00:00
#54 add `tea times` command
6543 added this to the v0.2.0 milestone 2020-01-01 16:27:04 +00:00
6543 commented 2020-01-01 16:30:14 +00:00
Owner
Copy Link

@noerw fi you like to use 488204ae31 you shuld update dependencys again!

@noerw fi you like to use https://gitea.com/gitea/go-sdk/commit/488204ae3128ad6ed92629b593fce0b7ae53ba96 you shuld update dependencys again!
6543 requested changes 2020-01-01 16:31:47 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

outdated!
gitea-sdk is now on 488204ae31

outdated! gitea-sdk is now on 488204ae31
6543 commented 2020-01-03 16:07:17 +00:00
Owner
Copy Link

In generall updatable:

  • code.gitea.io/sdk/gitea v0.0.0-20191013013401-e41e9ea72caa -> v0.0.0-20200103062250-c7686bd633c6
    -> #81
  • github.com/mattn/go-runewidth v0.0.4 -> v0.0.7
  • github.com/olekukonko/tablewriter v0.0.1 -> v0.0.4
  • github.com/sergi/go-diff v1.0.0 -> v1.1.0
  • github.com/stretchr/testify v1.3.0 -> v1.4.0 -> #83
  • github.com/urfave/cli v1.20.0 -> v1.22.2 -> #84
  • golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 -> v0.0.0-20191227163750-53104e6ec876
  • golang.org/x/net v0.0.0-20190724013045-ca1201d0de80 -> v0.0.0-20191209160850-c0dbc17a3553
  • golang.org/x/sys v0.0.0-20190726091711-fc99dfbffb4e -> v0.0.0-20200103143344-a1369afcdac7
In generall updatable: * code.gitea.io/sdk/gitea v0.0.0-20191013013401-e41e9ea72caa -> v0.0.0-20200103062250-c7686bd633c6 -> #81 * github.com/mattn/go-runewidth v0.0.4 -> v0.0.7 * github.com/olekukonko/tablewriter v0.0.1 -> v0.0.4 * github.com/sergi/go-diff v1.0.0 -> v1.1.0 * github.com/stretchr/testify v1.3.0 -> v1.4.0 -> #83 * github.com/urfave/cli v1.20.0 -> v1.22.2 -> #84 * golang.org/x/crypto v0.0.0-20190701094942-4def268fd1a4 -> v0.0.0-20191227163750-53104e6ec876 * golang.org/x/net v0.0.0-20190724013045-ca1201d0de80 -> v0.0.0-20191209160850-c0dbc17a3553 * golang.org/x/sys v0.0.0-20190726091711-fc99dfbffb4e -> v0.0.0-20200103143344-a1369afcdac7
6543 removed this from the v0.2.0 milestone 2020-01-03 17:54:56 +00:00
6543 removed a dependency 2020-01-04 01:48:08 +00:00
#54 add `tea times` command
6543 closed this pull request 2020-01-04 02:08:37 +00:00
6543 commented 2020-01-04 02:09:30 +00:00
Owner
Copy Link

@noerw if you need a specific dependency updated can you create a specific issue for that?

@noerw if you need a specific dependency updated can you create a specific issue for that?
Some checks are pending
continuous-integration/drone/pr Build is passing
Details
check-and-test / check-and-test (pull_request)
Required

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#78
No description provided.
Delete Branch "noerw:update-deps"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?