add tea issues [open|close] commands #99

noerw · 2020-03-05T09:53:08Z

noerw commented

2020-03-05 09:53:08 +00:00

No description provided.

lunny reviewed 2020-03-05 15:35:59 +00:00

Dismissed

cmd/issues.go Outdated

						
				@ -159,0 +162,4 @@

				// CmdIssuesOpen represents a sub command of issues to open an issue

				var CmdIssuesOpen = cli.Command{

					Name:        "open",

lunny commented

2020-03-05 15:35:59 +00:00

It's more suitable to rename to reopen.

It's more suitable to rename to `reopen`.

noerw commented

2020-03-05 15:57:39 +00:00

I renamed it to reopen, but left open as command alias

I renamed it to `reopen`, but left `open` as command alias

lunny added this to the v0.3.0 milestone 2020-03-05 15:38:35 +00:00

6543 added the

kind

feature

label 2020-03-07 01:55:09 +00:00

noerw changed title from ~~add subcmds: tea issues [open|close]~~ to add `tea issues [open|close]` commands

2020-03-07 13:45:04 +00:00

6543 approved these changes 2020-04-01 03:42:49 +00:00

Dismissed

lunny reviewed 2020-04-01 08:33:41 +00:00

Dismissed

cmd/issues.go Outdated

						
				@ -24,3 +25,4 @@

					Subcommands: []*cli.Command{

						&CmdIssuesList,

						&CmdIssuesCreate,

						&CmdIssuesOpen,

lunny commented

2020-04-01 08:33:41 +00:00

How about just rename it CmdIssuesReopen?

How about just rename it `CmdIssuesReopen`?

6543 requested review from lunny 2020-04-18 00:31:17 +00:00

6543 commented

2020-04-18 00:31:48 +00:00

@noerw pleace "update" this branch 👍

@noerw pleace "update" this branch :+1:

lunny approved these changes 2020-04-22 11:12:56 +00:00

Dismissed

6543 commented

2020-04-22 12:38:58 +00:00

@noerw a other pull removed "strings" from import - pleace fix merger relicts

zeripath approved these changes 2020-04-22 12:53:05 +00:00

Dismissed

zeripath commented

2020-04-22 12:54:25 +00:00

You need to add "strings" to the imports.

You need to add `"strings"` to the imports.

noerw commented

2020-04-22 14:15:18 +00:00

thanks, done!

lunny referenced this issue from a commit

2020-04-22 16:09:32 +00:00

add `tea issues [open|close]` commands (#99) update to master Merge branch 'master' into issue-openclose adress code review add issues [open|close] Co-authored-by: Norwin Roosen <git@nroo.de> Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/tea/pulls/99 Reviewed-by: 6543 <6543@noreply.gitea.io> Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-by: Andrew Thornton <art27@cantab.net>

lunny merged commit 1a4d8edf37 into master

2020-04-22 16:09:36 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

4 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#99

add tea issues [open|close] commands #99

add `tea issues [open|close]` commands #99