gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add milestones subcomands #149

Merged
6543 merged 18 commits from 6543/tea:feat_milestones into master 2020-09-17 19:35:25 +00:00
Conversation 6 Commits 18 Files Changed 5 +478 -14
6543 commented 2020-07-16 10:35:20 +00:00
Owner
Copy Link

close #123

close #123
6543 added this to the v0.4.0 milestone 2020-07-16 10:35:20 +00:00
6543 added the
kind
feature
status/wip
 labels 2020-07-16 10:35:20 +00:00
6543 added 1 commit 2020-07-16 10:35:23 +00:00
first draft
Some checks failed
continuous-integration/drone/pr Build is failing
Details
b08054c71e
6543 added 1 commit 2020-07-16 11:50:12 +00:00
first working version
Some checks failed
continuous-integration/drone/pr Build is failing
Details
b69fb09a97
6543 added
status/needs-reviews
 and removed
status/wip
 labels 2020-07-16 11:50:24 +00:00
6543 added 1 commit 2020-07-16 11:52:44 +00:00
be more tollerant with name matching
Some checks failed
continuous-integration/drone/pr Build is failing
Details
de9e6894f0
6543 added 1 commit 2020-07-16 11:59:06 +00:00
nice Milestone Detail look
Some checks failed
continuous-integration/drone/pr Build is failing
Details
ecdeda8a4d
6543 added 1 commit 2020-07-16 11:59:44 +00:00
nit
Some checks failed
continuous-integration/drone/pr Build is failing
Details
c8658a9e2d
6543 commented 2020-07-16 12:00:17 +00:00
Author
Owner
Copy Link

I think it is ready now ?

I think it is ready now ?
6543 added 1 commit 2020-07-16 12:15:44 +00:00
fix lint
All checks were successful
continuous-integration/drone/pr Build is passing
Details
973721c6bc
lunny reviewed 2020-07-16 14:51:43 +00:00
Dismissed
cmd/milestones.go Outdated
@ -0,0 +276,4 @@
// since there is no API to resolve it we have to iterate all milestones :/
// https://gitea.com/gitea/go-sdk/issues/383
i := 0
for {
lunny commented 2020-07-16 14:51:43 +00:00
Owner
Copy Link

Maybe we need a new API PR at first.

Maybe we need a new API PR at first.
6543 commented 2020-07-16 14:58:24 +00:00
Author
Owner
Copy Link

@lunny I tested it - the speed is totaly ok

And I think we should not block this feature - instead migrate to a better solution with go-sdk v0.13 migration

@lunny I tested it - the speed is totaly ok And I think we should not block this feature - instead migrate to a better solution with go-sdk v0.13 migration
6543 commented 2020-07-16 14:59:14 +00:00
Author
Owner
Copy Link

this isssue is on track of 0.13.0 so it should make no problem or do I miss something?

this isssue is on track of 0.13.0 so it should make no problem or do I miss something?
lunny commented 2020-07-16 15:24:29 +00:00
Owner
Copy Link

How many milestones on your tested repository?

How many milestones on your tested repository?
6543 commented 2020-07-16 15:26:30 +00:00
Author
Owner
Copy Link

not that mouch - but since ListRepoMilestone return up to >APIMaxItem< say you have 300 MS it would take by default 6 api calls to lookup - and you always have the choice to use the ID instead

not that mouch - but since ListRepoMilestone return up to `>APIMaxItem<` say you have 300 MS it would take by default 6 api calls to lookup - and you always have the choice to use the ID instead
6543 commented 2020-07-16 15:26:58 +00:00
Author
Owner
Copy Link
  • 6 calls in the worst case ...
* 6 calls in the worst case ...
6543 added 1 commit 2020-07-16 15:02:57 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
872c3d43a1
6543 added 1 commit 2020-07-16 18:34:41 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
54a051c477
6543 added 1 commit 2020-07-17 09:15:08 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
cf39a6d7c8
6543 added 1 commit 2020-07-17 15:53:47 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
15a576c6cd
6543 added 1 commit 2020-07-17 16:37:33 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
cf3c270871
6543 force-pushed feat_milestones from cf3c270871 to a578df3610 2020-07-17 16:40:04 +00:00 Compare
6543 commented 2020-07-17 23:07:11 +00:00
Author
Owner
Copy Link

because of your concerns of the milestone-id lookup function

should we move this feature into the next milestone?
@lunny

because of your concerns of the milestone-id lookup function should we move this feature into the next milestone? @lunny
6543 added the
upstream/gitea
upstream/sdk
status/blocked
 labels 2020-07-18 06:44:52 +00:00
6543 modified the milestone from v0.4.0 to v0.5.0 2020-07-18 06:44:57 +00:00
6543 removed the
status/needs-reviews
 label 2020-07-18 08:06:11 +00:00
6543 added 1 commit 2020-07-18 11:13:42 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
222eed10a1
6543 added 1 commit 2020-07-27 12:48:04 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
36de59d8c2
6543 added a new dependency 2020-07-27 12:48:11 +00:00
gitea/go-sdk#383 - Get Milestone by Name
6543 commented 2020-07-27 12:49:46 +00:00
Author
Owner
Copy Link

upstream pull: https://github.com/go-gitea/gitea/pull/12336

upstream pull: https://github.com/go-gitea/gitea/pull/12336
6543 commented 2020-07-28 12:49:27 +00:00
Author
Owner
Copy Link

@lunny I created a pull to the sdk: gitea/go-sdk#388

@lunny I created a pull to the sdk: https://gitea.com/gitea/go-sdk/pulls/388
6543 removed the
upstream/gitea
 label 2020-08-19 18:52:35 +00:00
6543 added 1 commit 2020-08-19 18:52:57 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7444704796
6543 removed the
upstream/sdk
status/blocked
 labels 2020-09-12 16:28:58 +00:00
6543 added 1 commit 2020-09-12 16:29:20 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
22025990b8
6543 added the
status/needs-reviews
 label 2020-09-12 16:31:42 +00:00
6543 commented 2020-09-12 16:32:34 +00:00
Author
Owner
Copy Link

the ms-name-resolve will be removed/optimized if sdk v0.13.0 is out ...

the ms-name-resolve will be removed/optimized if sdk v0.13.0 is out ...
6543 removed a dependency 2020-09-12 16:33:43 +00:00
gitea/go-sdk#383 - Get Milestone by Name
zeripath reviewed 2020-09-14 13:52:15 +00:00
Dismissed
cmd/milestones.go Outdated
@ -0,0 +268,4 @@
Flags: AllDefaultFlags,
}
func getMileIDbyNameOrID(client *gitea.Client, owner, repo, nameOrID string) (int64, error) {
zeripath commented 2020-09-14 13:52:15 +00:00
Owner
Copy Link

I'm really not a fan of this function name. What's wrong with just getMilestoneID?

I'm really not a fan of this function name. What's wrong with just getMilestoneID?
6543 commented 2020-09-14 14:38:53 +00:00
Author
Owner
Copy Link

I'll refactor it to getMilestone because List return a full usable milestone ...

I'll refactor it to **getMilestone** because List return a full usable milestone ...
6543 commented 2020-09-14 15:07:39 +00:00
Author
Owner
Copy Link

getMilestoneID is fine, beside MilestoneDetails only ID is needed ...

getMilestoneID is fine, beside MilestoneDetails only ID is needed ...
6543 added 1 commit 2020-09-14 15:12:38 +00:00
rename and add TODO note for sdk release
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fa1a976e41
zeripath reviewed 2020-09-14 19:23:13 +00:00
Dismissed
cmd/milestones.go Outdated
@ -0,0 +106,4 @@
if state == gitea.StateAll {
headers = append(headers, "State")
}
headers = append(headers, []string{
zeripath commented 2020-09-14 19:23:13 +00:00
Owner
Copy Link

Why bother creating the []string{...}... when you can just let the compiler do that for you.

headers = append(header, "Open/Closed Issues", "DueDate")
Why bother creating the []string{...}... when you can just let the compiler do that for you. ```go headers = append(header, "Open/Closed Issues", "DueDate") ```
zeripath reviewed 2020-09-14 19:23:45 +00:00
Dismissed
cmd/milestones.go Outdated
@ -0,0 +127,4 @@
if state == gitea.StateAll {
item = append(item, string(m.State))
}
item = append(item, []string{
zeripath commented 2020-09-14 19:23:45 +00:00
Owner
Copy Link

simy here.

simy here.
6543 added 1 commit 2020-09-15 02:30:46 +00:00
as per @zeripath
All checks were successful
continuous-integration/drone/pr Build is passing
Details
e3b406f949
6543 commented 2020-09-15 02:31:18 +00:00
Author
Owner
Copy Link

@zeripath done

@zeripath done
6543 added 1 commit 2020-09-15 02:31:43 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
a2dab3b39c
6543 added a new dependency 2020-09-15 22:23:29 +00:00
#179 Update SDK to v0.13.0
6543 added 7 commits 2020-09-16 00:34:27 +00:00
migrate & adapt
All checks were successful
continuous-integration/drone/pr Build is passing
Details
95ea311568
impruve
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7142bf6648
6543 added 2 commits 2020-09-16 01:30:59 +00:00
issues show milestones
Some checks failed
continuous-integration/drone/pr Build is failing
Details
fb0125c759
6543 added 1 commit 2020-09-16 01:32:43 +00:00
lint
All checks were successful
continuous-integration/drone/pr Build is passing
Details
bde7251852
6543 added 1 commit 2020-09-16 02:05:54 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
28a95372a0
6543 added 1 commit 2020-09-16 04:55:16 +00:00
pull list show milestone too
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fbd2555c2b
lunny approved these changes 2020-09-17 05:36:26 +00:00
Dismissed
lunny added 1 commit 2020-09-17 05:36:38 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
fa7908b7be
6543 added 1 commit 2020-09-17 12:57:55 +00:00
Merge branch 'master' into feat_milestones
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7e0fbe144f
zeripath approved these changes 2020-09-17 19:07:00 +00:00
Dismissed
zeripath approved these changes 2020-09-17 19:09:31 +00:00
Dismissed
6543 merged commit 7c30579900 into master 2020-09-17 19:35:25 +00:00
6543 deleted branch feat_milestones 2020-09-17 19:35:37 +00:00
6543 removed the
status/needs-reviews
 label 2020-09-17 19:35:45 +00:00
6543 changed title from Add milestones subcomand to Add milestones subcomands 2020-09-21 04:10:13 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.5.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#179 Update SDK to v0.13.0
gitea/tea
Reference: gitea/tea#149
No description provided.
Delete Branch "6543/tea:feat_milestones"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?