gitea/tea
gitea/tea
57
129
Fork 64
Code Issues 97 Pull Requests 21 Actions Releases 16 Activity

Add Repo Create subcomand & enhancements #173

Merged
6543 merged 20 commits from 6543/tea:repos-create into master 2020-09-23 19:50:02 +00:00
Conversation 1 Commits 20 Files Changed 2 +17 -17
1 changed files with 17 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 7873abe197 - Show all commits

34
cmd/repos.go
View File

@ -7,6 +7,7 @@ package cmd
import (
"fmt"
"log"
"net/http"
"strings"
"code.gitea.io/tea/modules/utils"
@ -43,13 +44,8 @@ var CmdReposList = cli.Command{
Usage: "Filter by mode: fork, mirror, source",
},
&cli.StringFlag{
Name: "user",
Aliases: []string{"u"},
Required: false,
Usage: "Filter by owner",
},
&cli.StringFlag{
Name: "org",
Name: "owner",
noerw commented 2020-09-23 11:14:32 +00:00
Outdated
Review
Copy Link

lets use owner / -O everywhere, and avoid two terms for the same concept

lets use `owner` / `-O` everywhere, and avoid two terms for the same concept
noerw commented 2020-09-23 11:18:52 +00:00
Outdated
Review
Copy Link

And why are there two flags org and user? Can't they be merged into --owner?

And why are there two flags `org` and `user`? Can't they be merged into `--owner`?
6543 commented 2020-09-23 19:20:04 +00:00
Outdated
Review
Copy Link

It will add a request ...
but It's user convinient So why not ...

It will add a request ... but It's user convinient So why not ...
noerw commented 2020-09-23 19:23:30 +00:00
Outdated
Review
Copy Link

Hm, I consider two flags for the same field is more confusing than convenient, but idk.

Let's leave it as is, but please change the description to say "Filter by user" then

Hm, I consider two flags for the same field is more confusing than convenient, but idk. Let's leave it as is, but please change the description to say "Filter by user" then
6543 commented 2020-09-23 19:33:14 +00:00
Review
Copy Link

changed :)

changed :)
Aliases: []string{"O"},
Required: false,
Usage: "Filter by owner",
},
@ -146,18 +142,22 @@ func runReposList(ctx *cli.Context) error {
client := login.Client()
var ownerID int64
if ctx.IsSet("user") {
owner, _, err := client.GetUserInfo(ctx.String("user"))
if ctx.IsSet("owner") {
6543 marked this conversation as resolved Outdated
zeripath commented 2020-09-14 14:02:08 +00:00
Outdated
Review
Copy Link

TODO: is usually better detected by IDEs

`TODO:` is usually better detected by IDEs
noerw commented 2020-09-23 11:17:12 +00:00
Outdated
Review
Copy Link

By using initCommandLoginOnly(), the login is not read from the current repo!

This came up in #189 as well, where I wrote a workaround.
But we need a proper solution for cases where the command is meaningful when executed outside of a repo, but we still want it to consider repo context where available.

By using `initCommandLoginOnly()`, the login is not read from the current repo! This came up in #189 as well, where I wrote a workaround. But we need a proper solution for cases where the command is meaningful when executed outside of a repo, but we still want it to consider repo context where available.
6543 commented 2020-09-23 19:22:26 +00:00
Outdated
Review
Copy Link

If we use login, _, _ := initCommand() outside of a repo we will get this:

Error: repository does not exist

If we use `login, _, _ := initCommand()` outside of a repo we will get this: Error: repository does not exist
6543 commented 2020-09-23 19:23:00 +00:00
Outdated
Review
Copy Link

So yes we somehow have to unify both commands but in a way it will work for all commands

So yes we somehow have to unify both commands but in a way it will work for all commands
6543 commented 2020-09-23 19:23:27 +00:00
Outdated
Review
Copy Link

... witch is no mouch for this pull

... witch is no mouch for this pull
// test if owner is a organisation
org, resp, err := client.GetOrg(ctx.String("owner"))
if err != nil {
return err
if resp == nil || resp.StatusCode != http.StatusNotFound {
return err
}
// if owner is no org, its a user
user, _, err := client.GetUserInfo(ctx.String("owner"))
if err != nil {
return err
}
ownerID = user.ID
} else {
ownerID = org.ID
}
ownerID = owner.ID
} else if ctx.IsSet("org") {
org, _, err := client.GetOrg(ctx.String("org"))
if err != nil {
return err
}
ownerID = org.ID
} else {
me, _, err := client.GetMyUserInfo()
if err != nil {