gitea/tea
gitea/tea
57
129
Fork 64
Code Issues 97 Pull Requests 20 Actions Releases 16 Activity

Add Repo Create subcomand & enhancements #173

Merged
6543 merged 20 commits from 6543/tea:repos-create into master 2020-09-23 19:50:02 +00:00
Conversation 1 Commits 20 Files Changed 2 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit eb0cea0522 - Show all commits

2
cmd/repos.go
View File

@ -142,7 +142,7 @@ func runReposList(ctx *cli.Context) error {
var rps []*gitea.Repository
var err error
// ToDo: on sdk v0.13.0 release, switch to SearchRepos()
// TODO: on sdk v0.13.0 release, switch to SearchRepos()
6543 marked this conversation as resolved Outdated
zeripath commented 2020-09-14 14:02:08 +00:00
Outdated
Review
Copy Link

TODO: is usually better detected by IDEs

`TODO:` is usually better detected by IDEs
noerw commented 2020-09-23 11:17:12 +00:00
Outdated
Review
Copy Link

By using initCommandLoginOnly(), the login is not read from the current repo!

This came up in #189 as well, where I wrote a workaround.
But we need a proper solution for cases where the command is meaningful when executed outside of a repo, but we still want it to consider repo context where available.

By using `initCommandLoginOnly()`, the login is not read from the current repo! This came up in #189 as well, where I wrote a workaround. But we need a proper solution for cases where the command is meaningful when executed outside of a repo, but we still want it to consider repo context where available.
6543 commented 2020-09-23 19:22:26 +00:00
Outdated
Review
Copy Link

If we use login, _, _ := initCommand() outside of a repo we will get this:

Error: repository does not exist

If we use `login, _, _ := initCommand()` outside of a repo we will get this: Error: repository does not exist
6543 commented 2020-09-23 19:23:00 +00:00
Outdated
Review
Copy Link

So yes we somehow have to unify both commands but in a way it will work for all commands

So yes we somehow have to unify both commands but in a way it will work for all commands
6543 commented 2020-09-23 19:23:27 +00:00
Outdated
Review
Copy Link

... witch is no mouch for this pull

... witch is no mouch for this pull
// Note: user filter can be used as org filter too
if org != "" {
rps, err = login.Client().ListOrgRepos(org, gitea.ListOrgReposOptions{})