Use glamour and termev to render/colorize content #181

6543 · 2020-09-16T04:39:07Z

6543 commented

2020-09-16 04:39:07 +00:00

close #146
close #49

use glamour to render markdon for detail views

for repos
for issues
...

and use glamour's dependency termev to colorize

label color field

close #146 close #49 use glamour to render markdon for detail views - for repos - for issues - ... and use glamour's dependency **termev** to colorize - label color field ![](https://gitea.com/attachments/09e75127-52aa-4fec-96bd-5aa89f149768) ![](https://gitea.com/attachments/77c35850-9f2d-42a8-8c90-e2574e8c2aac)

Bildschirmfoto zu 2020-09-16 06-38-30.png

24 KiB

Bildschirmfoto zu 2020-09-16 06-37-27.png

19 KiB

1 ❤️ 2

6543 added this to the v0.5.0 milestone 2020-09-16 04:39:07 +00:00

6543 added the

kind

feature

label 2020-09-16 04:39:07 +00:00

6543 added 5 commits 2020-09-16 04:39:10 +00:00

Vendor: Add glamour c69dfbd13e

use glamour for issue content 923eef4f59

label color colorate fbf2ba8019

update go.mod 856370292a

update termev

continuous-integration/drone/pr Build is passing

Details

c76a834757

6543 changed title from ~~use-glamour~~ to Use glamour and termev to render/colorize content

2020-09-16 04:39:35 +00:00

6543 added the

status/needs-reviews

label 2020-09-16 04:39:43 +00:00

6543 added 1 commit 2020-09-17 12:58:44 +00:00

Merge branch 'master' into use-glamour

continuous-integration/drone/pr Build is passing

Details

763aeb5e68

noerw commented

2020-09-17 16:59:47 +00:00

Nice!

This renders badly on a light-themed terminal for me though.
You could use termenv.HasDarkBackground() to set the glamour theme to "light" or "dark".

Also, note that this feature increases build size from 17mb to 25mb. But I guess that's worth it..?

Nice! This renders badly on a light-themed terminal for me though. You could use `termenv.HasDarkBackground()` to set the glamour theme to `"light"` or `"dark"`. Also, note that this feature increases build size from 17mb to 25mb. But I guess that's worth it..?

6543 commented

2020-09-17 17:42:32 +00:00

for me tea with all patches: 17M (17694720b)

for me tea with all patches: `17M` (17694720b)

6543 added 1 commit 2020-09-17 19:37:48 +00:00

Merge branch 'master' into use-glamour

continuous-integration/drone/pr Build is passing

Details

1e3fb11148

6543 added

status/wip

and removed

status/needs-reviews

labels 2020-09-18 00:21:11 +00:00

6543 commented

2020-09-18 00:21:36 +00:00

wip: because of HasDarkBackground()

6543 added 1 commit 2020-09-18 00:31:59 +00:00

select Glamour Theme based on BackgroundColor

continuous-integration/drone/pr Build is passing

Details

445007e677

6543 added

status/needs-reviews

and removed

status/wip

labels 2020-09-18 00:32:16 +00:00

6543 commented

2020-09-18 00:33:17 +00:00

@noerw hope your terminal looks now nice too :)

noerw commented

2020-09-18 07:36:15 +00:00

@6543 nice, theming works well!

RE build size (with go version go1.13.14 linux/amd64):

running make results in a 20M binary for me (current master is 13M)
running go build results in a 25M binary (current master is 17M).

Might be a go<=1.14 issue..?

@6543 nice, theming works well! RE build size (with `go version go1.13.14 linux/amd64`): - running `make` results in a 20M binary for me (current master is `13M`) - running `go build` results in a 25M binary (current master is `17M`). Might be a go<=1.14 issue..?

techknowlogick commented

2020-09-18 11:09:35 +00:00

@noerw go 1.15 was announced as creating smaller binaries, perhaps you could attempt building with that?

👍 1

noerw commented

2020-09-18 12:36:56 +00:00

Can confirm, on go 1.15 production build is 17M (compared to 11M on master).
The point still stands, this feature increases build size by more than 50%.

Considering that 11M is already totally out of place for a simple CLI, 17M is not significantly worse I guess ¯\_(ツ)_/¯ But it somehow rubs me the wrong way

Can confirm, on go 1.15 production build is 17M (compared to 11M on master). The point still stands, this feature increases build size by more than 50%. Considering that 11M is already totally out of place for a simple CLI, 17M is not significantly worse I guess ¯\\_(ツ)\_/¯ But it somehow rubs me the wrong way

6543 commented

2020-09-18 12:49:30 +00:00

@noerw on the one hand storage space is cheep this days ...

on the other hand: look at the tools the unix time has given us (140K /usr/bin/ls) ...

I think the 6Mb are worth it if we realy utilize this two libs
adding to mouch libs and blow up tea's binary on the other hand is bas

so I would considder only 3 legitime libs: markdown rendering (already include collor lib and syntax highliting lib), the sdk (include version lib) and in the future eventualy survey? (for interactive prompts)

@noerw on the one hand storage space is cheep this days ... on the other hand: look at the tools the unix time has given us (`140K /usr/bin/ls`) ... I think the 6Mb are worth it if we realy utilize this two libs adding to mouch libs and blow up tea's binary on the other hand is bas so I would considder only 3 legitime libs: markdown rendering (already include collor lib and syntax highliting lib), the sdk (include version lib) and in the future eventualy survey? (for interactive prompts)

6543 commented

2020-09-18 13:32:36 +00:00

@noerw with this and #186 the binary is 18M

gh cli tool is 19M

@noerw with this and #186 the binary is 18M `gh` cli tool is 19M

🎉 1

techknowlogick approved these changes 2020-09-19 04:01:09 +00:00

Dismissed

lunny approved these changes 2020-09-19 15:43:11 +00:00

Dismissed

lunny added 1 commit 2020-09-19 15:43:34 +00:00

Merge branch 'master' into use-glamour