Use glamour and termev to render/colorize content #181

close #146
close #49

use glamour to render markdon for detail views

for repos
for issues
...

and use glamour's dependency termev to colorize

label color field

Bildschirmfoto zu 2020-09-16 06-38-30.png

24 KiB

Bildschirmfoto zu 2020-09-16 06-37-27.png

19 KiB

Nice!

This renders badly on a light-themed terminal for me though.
You could use termenv.HasDarkBackground() to set the glamour theme to "light" or "dark".

Also, note that this feature increases build size from 17mb to 25mb. But I guess that's worth it..?

for me tea with all patches: 17M (17694720b)

wip: because of HasDarkBackground()

@noerw hope your terminal looks now nice too :)

@6543 nice, theming works well!

RE build size (with go version go1.13.14 linux/amd64):

running make results in a 20M binary for me (current master is 13M)
running go build results in a 25M binary (current master is 17M).

Might be a go<=1.14 issue..?

@noerw go 1.15 was announced as creating smaller binaries, perhaps you could attempt building with that?

Can confirm, on go 1.15 production build is 17M (compared to 11M on master).
The point still stands, this feature increases build size by more than 50%.

Considering that 11M is already totally out of place for a simple CLI, 17M is not significantly worse I guess ¯\_(ツ)_/¯ But it somehow rubs me the wrong way

@noerw on the one hand storage space is cheep this days ...

on the other hand: look at the tools the unix time has given us (140K /usr/bin/ls) ...

I think the 6Mb are worth it if we realy utilize this two libs
adding to mouch libs and blow up tea's binary on the other hand is bas

so I would considder only 3 legitime libs: markdown rendering (already include collor lib and syntax highliting lib), the sdk (include version lib) and in the future eventualy survey? (for interactive prompts)

@noerw with this and #186 the binary is 18M

gh cli tool is 19M