tea pulls create: detect head branch repo owner #193

Merged
6543 merged 5 commits from noerw/tea:issue-169 into master 2 years ago
noerw commented 2 years ago
Collaborator

fixes #169 (only the --remote / -R flag bug. however the remaining bugs there are tracked in other issues, so it can be closed once this is merged)

this PR finally was created with tea pulls create ?

fixes #169 (only the `--remote` / `-R` flag bug. however the remaining bugs there are tracked in other issues, so it can be closed once this is merged) this PR finally was created with `tea pulls create` ?
noerw added 1 commit 2 years ago
b5567f7542 detect repo owner for default head branch
6543 approved these changes 2 years ago
Dismissed
6543 left a comment
Collaborator

add more logic - hope this will solve lot of edge cases

add more logic - hope this will solve lot of edge cases
6543 added this to the v0.5.0 milestone 2 years ago
6543 added the
kind/bug
status/needs-reviews
labels 2 years ago
lunny reviewed 2 years ago
Dismissed
cmd/pulls.go Outdated
log.Println("git push")
err = localRepo.Push(&git.PushOptions{})
if err == git.NoErrAlreadyUpToDate {
log.Println(err.Error())
lunny commented 2 years ago
Owner

Why not ignore the error?

Why not ignore the error?
noerw commented 2 years ago
Poster
Collaborator

because it is not an error, just information that nothing new was pushed.

because it is not an error, just information that nothing new was pushed.
6543 commented 2 years ago
Collaborator

@noerw why not ignore this "error" at all (print nothing)

@noerw why not ignore this "error" at all (print nothing)
noerw marked this conversation as resolved
6543 removed the
status/needs-reviews
label 2 years ago
noerw added 3 commits 2 years ago
Poster
Collaborator

@lunny this one is ready now

@lunny this one is ready now
Collaborator

@noerw pleace update :)

@noerw pleace update :)
noerw added 1 commit 2 years ago
387f494383 Merge branch 'master' into issue-169
lunny approved these changes 2 years ago
Dismissed
6543 merged commit 159bf03d49 into master 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 159bf03d49.
Sign in to join this conversation.
Loading…
There is no content yet.