Add Release Subcomands #195

Merged
6543 merged 10 commits from 6543/tea:enhance-release into master 2020-09-23 19:56:42 +00:00
Owner

add Subcomands to list, edit and delete

add Subcomands to **list**, **edit** and **delete**
6543 added 5 commits 2020-09-21 03:18:38 +00:00
6543 added the
kind
feature
status/needs-reviews
labels 2020-09-21 03:19:09 +00:00
6543 added this to the v0.5.0 milestone 2020-09-21 03:19:14 +00:00
lunny approved these changes 2020-09-21 05:03:53 +00:00
Dismissed
6543 added 1 commit 2020-09-21 05:58:51 +00:00
Merge branch 'master' into enhance-release
All checks were successful
continuous-integration/drone/pr Build is passing
930facee74
noerw requested changes 2020-09-23 10:41:58 +00:00
Dismissed
cmd/releases.go Outdated
@ -29,0 +38,4 @@
Usage: "List Releases",
Description: "List Releases",
Action: runReleases,
Flags: AllDefaultFlags,
Member

While we're at it, it might be nice to add a 'prerelease/draftfilter flag fortea releases ls`?

While we're at it, it might be nice to add a 'prerelease`/`draft` filter flag for `tea releases ls`?
Author
Owner

Not supported by the sdk

Not supported by the sdk
Author
Owner

.. and api

.. and api
noerw marked this conversation as resolved
cmd/releases.go Outdated
@ -149,0 +175,4 @@
Name: "delete",
Usage: "Delete a release",
Description: `Delete a release`,
ArgsUsage: "[<release tag>]",
Member

[foo] indicates that foo is optional. release tag is not optional.

`[foo]` indicates that `foo` is optional. release tag is not optional.
cmd/releases.go Outdated
@ -149,0 +221,4 @@
}
// CmdReleaseEdit represents a sub command of Release to edit releases
var CmdReleaseEdit = cli.Command{
Member

please add ArgsUsage: "<release tag>" to options

please add `ArgsUsage: "<release tag>"` to options
6543 marked this conversation as resolved
cmd/releases.go Outdated
@ -149,0 +257,4 @@
},
&cli.BoolFlag{
Name: "release",
Usage: "Release Draft/Pre-Release",
Member

what does this flag do? it's unclear to me, there already is a draft/prerelease flag.

what does this flag do? it's unclear to me, there already is a draft/prerelease flag.
Author
Owner

releasea a "unreleased" release <- how should I describe it ?!?

releasea a "unreleased" release <- how should I describe it ?!?
Member

Ah I get it now, after looking at the logic behind the flag.
I'd remove this flag, if you want to change the draft state, you can just use --draft=false flag.

Imo the use case does not exist where you intentionally set both --draft --prerelease on creation, and lateron want to remove both flags. (i.e. why initially set the prerelease flag then?)

Ah I get it now, after looking at the logic behind the flag. I'd remove this flag, if you want to change the draft state, you can just use `--draft=false` flag. Imo the use case does not exist where you intentionally set both `--draft --prerelease` on creation, and lateron want to remove both flags. (i.e. why initially set the prerelease flag then?)
6543 marked this conversation as resolved
cmd/releases.go Outdated
@ -149,0 +268,4 @@
tag := ctx.Args().First()
if len(tag) == 0 {
fmt.Println("Release tag needed to delete")
Member

should be ...to edit"

should be `...to edit"`
6543 marked this conversation as resolved
6543 removed the
status/needs-reviews
label 2020-09-23 14:24:05 +00:00
6543 added 2 commits 2020-09-23 19:09:10 +00:00
Merge branch 'master' into enhance-release
All checks were successful
continuous-integration/drone/pr Build is passing
5bb8ee4357
6543 added 1 commit 2020-09-23 19:48:13 +00:00
rm release flag
All checks were successful
continuous-integration/drone/pr Build is passing
54bc0436fd
6543 added 1 commit 2020-09-23 19:52:29 +00:00
Merge branch 'master' into enhance-release
All checks were successful
continuous-integration/drone/pr Build is passing
f3b27690c6
noerw approved these changes 2020-09-23 19:53:44 +00:00
Dismissed
6543 referenced this issue from a commit 2020-09-23 19:56:35 +00:00
6543 merged commit 288a8574c3 into master 2020-09-23 19:56:35 +00:00
6543 deleted branch enhance-release 2020-09-23 19:56:47 +00:00
Sign in to join this conversation.
No description provided.