Refactor: apply new internal structurs #206
Merged
lunny
merged 22 commits from 6543/tea:refactor_new-internal-structure
into master
2 years ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch '6543/tea:refactor_new-internal-structure'
Deleting a branch is permanent. It CANNOT be undone. Continue?
reference: #184
Aim:
No-Aim:
Refactors:
Refactor: apply new internal structursto WIP: Refactor: apply new internal structurs 2 years ago// Copyright 2018 The Gitea Authors. All rights reserved.
2020
"gopkg.in/yaml.v2"
)
// Config reprensents local configurations
LocalConfig
yamlConfigPath string
)
func init() {
// TODO: dont rely on intransparent init func to detect tea config
c9877bafd5
toc0aa819442
2 years agoWIP: Refactor: apply new internal structursto Refactor: apply new internal structurs 2 years agoOK this already to that big - so wont add more to this and wait until it got merged to send the next batch (shouldn't be that big but will contain impruvements ... (see TODOs)
"log"
"strconv"
"code.gitea.io/tea/modules/intern"
We need a blank line.
between internal modues ?!?
How about a subfolder for issues' commands?
what structur do you mean?
instead of issues_subcomand -> issues/subcomand ?
I didn't do a thorough review yet, but generally it looks like a great improvement ?
Some remarks:
modules/intern
->modules/internal
(intern means Praktikant and isn't that much shorter ;)modules/config
, because it is all about config right now?modules/git/auth.go:absPathWithExpansion
tomodules/util/path.go
?cmd/times.go:formatDuration()
tomodules/print/print.go
?modules/interact
seems a bit too separated, unless you expect that module to grow significantly?1.
internal
is a preserved package name (we can't use that one...)4.
yes I think so :) (I like to have more interaction forcreate
comands with no args)2. &3.
I'll look into it@noerw done
@lunny done
Lint error
@lunny fixed :)
import (
"code.gitea.io/sdk/gitea"
"code.gitea.io/tea/cmd/flags"
sort import
// Copyright 2018 The Gitea Authors. All rights reserved.
year
@lunny do you have time?
f445ac7521
into master 2 years agof445ac7521
.