add times ls #272

Merged
6543 merged 3 commits from khmarbaise/tea:issue-242-times-ls into master 2020-12-07 12:29:49 +00:00
Member

Fix #242

Move list code into times/list.go
to make it more in line with the rest of the code.

Signed-off-by: Karl Heinz Marbaise kama@soebes.de

Fix #242 Move `list` code into times/list.go to make it more in line with the rest of the code. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
khmarbaise added 1 commit 2020-12-06 23:38:11 +00:00
add times ls
Some checks failed
continuous-integration/drone/pr Build is failing
e739fffe8c
Fix #242

Move `list` code into times/list.go
to make it more in line with the rest of the code.

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
khmarbaise reviewed 2020-12-06 23:39:05 +00:00
Dismissed
@ -0,0 +53,4 @@
// RunTimesList list repositories
func RunTimesList(ctx *cli.Context) error {
login, owner, repo := config.InitCommand(flags.GlobalRepoValue, flags.GlobalLoginValue, flags.GlobalRemoteValue)
Author
Member

So the prefered way would be here to name it: RunTrackedtimesList instead?

So the prefered way would be here to name it: `RunTrackedtimesList` instead?
Owner

¯(ツ)

we at some point have to define one way ...

¯_(ツ)_/¯ we at some point have to define one way ...
6543 marked this conversation as resolved
khmarbaise added 1 commit 2020-12-06 23:48:19 +00:00
add times ls
All checks were successful
continuous-integration/drone/pr Build is passing
ca04b25c9f
reformatted code.

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
noerw added the
kind
refactor
label 2020-12-06 23:59:57 +00:00
noerw added this to the v0.6.0 milestone 2020-12-07 00:00:29 +00:00
noerw added the
skip-changelog
label 2020-12-07 00:03:42 +00:00
noerw added the
status/needs-feedback
label 2020-12-07 00:39:53 +00:00
6543 reviewed 2020-12-07 00:48:50 +00:00
Dismissed
@ -0,0 +54,4 @@
// RunTimesList list repositories
func RunTimesList(ctx *cli.Context) error {
login, owner, repo := config.InitCommand(flags.GlobalRepoValue, flags.GlobalLoginValue, flags.GlobalRemoteValue)
client := login.Client()
Owner

this check is not needed anymore :)

this check is not needed anymore :)
Author
Member

You mean this part:

client := login.Client()

Or do you mean the check for the version?

if err := client.CheckServerVersionConstraint(">= 1.11");
You mean this part: ``` client := login.Client() ``` Or do you mean the check for the version? ``` if err := client.CheckServerVersionConstraint(">= 1.11"); ```
Member

The version constraint check.
(Sorry, the PR comment view is currently broken, showing comments on the wrong line, in the "changed files" view it should be correct)

The version constraint check. (Sorry, the PR comment view is currently broken, showing comments on the wrong line, in the "changed files" view it should be correct)
Author
Member

Removed CheckServerVersionConstraint as suggested.

Removed CheckServerVersionConstraint as suggested.
noerw marked this conversation as resolved
noerw added
status/needs-reviews
kind/breaking
and removed
status/needs-feedback
labels 2020-12-07 11:36:02 +00:00
khmarbaise added 1 commit 2020-12-07 11:58:14 +00:00
Removed version check as suggested through the review.
All checks were successful
continuous-integration/drone/pr Build is passing
84afdc83d8
noerw approved these changes 2020-12-07 12:12:10 +00:00
Dismissed
6543 approved these changes 2020-12-07 12:29:05 +00:00
Dismissed
6543 referenced this issue from a commit 2020-12-07 12:29:49 +00:00
6543 merged commit 16133212fc into master 2020-12-07 12:29:49 +00:00
6543 removed the
status/needs-reviews
label 2020-12-07 12:30:02 +00:00
6543 removed the
kind/breaking
label 2020-12-12 11:05:55 +00:00
Sign in to join this conversation.
No description provided.