gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

add times ls #272

Merged
6543 merged 3 commits from khmarbaise/tea:issue-242-times-ls into master 2020-12-07 12:29:49 +00:00
Conversation 0 Commits 3 Files Changed 2 +99 -75
khmarbaise commented 2020-12-06 23:38:11 +00:00
Member
Copy Link

Fix #242

Move list code into times/list.go
to make it more in line with the rest of the code.

Signed-off-by: Karl Heinz Marbaise kama@soebes.de

Fix #242 Move `list` code into times/list.go to make it more in line with the rest of the code. Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
👍 1
khmarbaise added 1 commit 2020-12-06 23:38:11 +00:00
add times ls 
Fix #242

Move `list` code into times/list.go
to make it more in line with the rest of the code.

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
Some checks failed
continuous-integration/drone/pr Build is failing
Details
e739fffe8c
khmarbaise reviewed 2020-12-06 23:39:05 +00:00
Dismissed
cmd/times/list.go
@ -0,0 +53,4 @@
// RunTimesList list repositories
func RunTimesList(ctx *cli.Context) error {
login, owner, repo := config.InitCommand(flags.GlobalRepoValue, flags.GlobalLoginValue, flags.GlobalRemoteValue)
khmarbaise commented 2020-12-06 23:39:05 +00:00
Author
Member
Copy Link

So the prefered way would be here to name it: RunTrackedtimesList instead?

So the prefered way would be here to name it: `RunTrackedtimesList` instead?
6543 commented 2020-12-07 00:20:23 +00:00
Owner
Copy Link

¯(ツ)/¯

we at some point have to define one way ...

¯_(ツ)_/¯ we at some point have to define one way ...
6543 marked this conversation as resolved
khmarbaise added 1 commit 2020-12-06 23:48:19 +00:00
add times ls 
reformatted code.

Signed-off-by: Karl Heinz Marbaise <kama@soebes.de>
All checks were successful
continuous-integration/drone/pr Build is passing
Details
ca04b25c9f
noerw added the
kind
refactor
 label 2020-12-06 23:59:57 +00:00
noerw added this to the v0.6.0 milestone 2020-12-07 00:00:29 +00:00
noerw added the
skip-changelog
 label 2020-12-07 00:03:42 +00:00
noerw added the
status/needs-feedback
 label 2020-12-07 00:39:53 +00:00
6543 reviewed 2020-12-07 00:48:50 +00:00
Dismissed
cmd/times/list.go
@ -0,0 +54,4 @@
// RunTimesList list repositories
func RunTimesList(ctx *cli.Context) error {
login, owner, repo := config.InitCommand(flags.GlobalRepoValue, flags.GlobalLoginValue, flags.GlobalRemoteValue)
client := login.Client()
6543 commented 2020-12-07 00:48:50 +00:00
Owner
Copy Link

this check is not needed anymore :)

this check is not needed anymore :)
khmarbaise commented 2020-12-07 10:52:16 +00:00
Author
Member
Copy Link

You mean this part:

client := login.Client()

Or do you mean the check for the version?

if err := client.CheckServerVersionConstraint(">= 1.11");
You mean this part: ``` client := login.Client() ``` Or do you mean the check for the version? ``` if err := client.CheckServerVersionConstraint(">= 1.11"); ```
noerw commented 2020-12-07 11:32:10 +00:00
Member
Copy Link

The version constraint check.
(Sorry, the PR comment view is currently broken, showing comments on the wrong line, in the "changed files" view it should be correct)

The version constraint check. (Sorry, the PR comment view is currently broken, showing comments on the wrong line, in the "changed files" view it should be correct)
khmarbaise commented 2020-12-07 11:58:38 +00:00
Author
Member
Copy Link

Removed CheckServerVersionConstraint as suggested.

Removed CheckServerVersionConstraint as suggested.
noerw marked this conversation as resolved
noerw added
status/needs-reviews
kind/breaking
 and removed
status/needs-feedback
 labels 2020-12-07 11:36:02 +00:00
khmarbaise added 1 commit 2020-12-07 11:58:14 +00:00
Removed version check as suggested through the review.
All checks were successful
continuous-integration/drone/pr Build is passing
Details
84afdc83d8
noerw approved these changes 2020-12-07 12:12:10 +00:00
Dismissed
6543 approved these changes 2020-12-07 12:29:05 +00:00
Dismissed
6543 referenced this issue from a commit 2020-12-07 12:29:49 +00:00
Add `times ls` (#272)
6543 merged commit 16133212fc into master 2020-12-07 12:29:49 +00:00
6543 removed the
status/needs-reviews
 label 2020-12-07 12:30:02 +00:00
6543 removed the
kind/breaking
 label 2020-12-12 11:05:55 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.6.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#272
No description provided.
Delete Branch "khmarbaise/tea:issue-242-times-ls"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?