use token auth for https remotes #275

Merged

6543 merged 3 commits from noerw/tea:issue-231-refacor-prompt into master 2 years ago

noerw commented 2 years ago

Collaborator

better UX & partial fix to #231

👍 1

noerw added 1 commit 2 years ago

c11bf8ee43

use token for https auth instead of user name

noerw added the

status/needs-reviews

kind/enhancement

labels 2 years ago

6543 reviewed 2 years ago

Dismissed

modules/git/auth.go Outdated

6543 commented 2 years ago

Collaborator

-	case "https":
+	case "http", "https":

6543 commented 2 years ago

Collaborator

it will close #262 if you would add it

noerw commented 2 years ago

Poster

Collaborator

I don't think so, the URL passed in their config is ssh://.
But we can add it anyway.

6543 commented 2 years ago

Collaborator

Yes plz

6543 marked this conversation as resolved

lunny approved these changes 2 years ago

Dismissed

6543 removed the

status/needs-reviews

label 2 years ago

noerw added 1 commit 2 years ago

c1fd5e40d0

also handle http urls

6543 approved these changes 2 years ago

Dismissed

6543 left a comment

Collaborator

can you hit the "Update branch" button ;)

noerw added 1 commit 2 years ago

93cc5f68e6 Merge branch 'master' into issue-231-refacor-prompt

6543 merged commit 9a3b54b9a3 into master 2 years ago

6543 referenced this issue from a commit 2 years ago

use token auth for https remotes (#275)

6543 added this to the v0.6.0 milestone 2 years ago

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 9a3b54b9a3.

No reviewers

No Assignees

3 Participants

Notifications

Due Date

No due date set.

Reference: gitea/tea#275