fix InitCommand() #285
No reviewers
Labels
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
No Milestone
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: gitea/tea#285
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "noerw/tea:issue-200-initcommand"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
@ -0,0 +1,165 @@
// Copyright 2020 The Gitea Authors. All rights reserved.
// Use of this source code is governed by a MIT-style
// license that can be found in the LICENSE file.
is there a reason so split this up into login_tasks.go
do we have some sort of rule to know witch func is going into this file or login.go ?
I split the files because I never found what I was looking for.
login.go
holds theLogin
struct and all its attached methodslogin_tasks.go
is what later should go intomodules/tasks/login.go
(ie. notLogin
methods(I'm open to merging the files again if you don't want to move login_tasks into the tasks module once #158 is fixed)
I agree, e.g. Create-/Generate- Login can go into task ...
but GetDefaultLogin and GetLoginByName is definetly something I expect to be in the config module ...
16034f60e0
to580c55d751
@noerw I created
580c55d751
based on #285 (comment).So I'll need your OK too ..
@6543 yeah sounds good :) thanks