gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Refactor: unexport config.Config var & move login tasks to task module #288

Merged
6543 merged 11 commits from 6543/tea:unexport-ConfigVar into master 2020-12-12 13:28:38 +00:00
Conversation 3 Commits 11 Files Changed 12 +226 -175
6543 commented 2020-12-11 10:10:53 +00:00
Owner
Copy Link

Only access config.Config throu functions.

this make sure config is initialiced when accessing it

you can call it a follow up of #285

Only access config.Config throu functions. this make sure config is initialiced when accessing it you can call it a follow up of #285
👍 1
6543 added this to the v0.6.0 milestone 2020-12-11 10:10:53 +00:00
6543 added the
kind
refactor
 label 2020-12-11 10:10:53 +00:00
6543 added 5 commits 2020-12-11 10:10:54 +00:00
unexport config var
All checks were successful
continuous-integration/drone/pr Build is passing
Details
516f13860e
6543 commented 2020-12-11 10:11:06 +00:00
Author
Owner
Copy Link

@noerw I had this in mind ;)

@noerw I had this in mind ;)
6543 added 1 commit 2020-12-11 10:15:05 +00:00
make SetDefaultLogin() case insensitive
All checks were successful
continuous-integration/drone/pr Build is passing
Details
1edeb6c272
6543 added 1 commit 2020-12-11 10:18:44 +00:00
update func descriptions
All checks were successful
continuous-integration/drone/pr Build is passing
Details
01bddc385a
6543 added the
status/needs-reviews
 label 2020-12-11 10:19:04 +00:00
6543 commented 2020-12-11 10:20:03 +00:00
Author
Owner
Copy Link

this prevent race condidtions & make sure if someone func read something from config, it's loaded

this prevent race condidtions & make sure if someone func read something from config, it's loaded
6543 changed title from Refactor: unexport config.Config Var to Refactor: unexport config.Config var & move login tasks to task module 2020-12-11 10:20:38 +00:00
noerw requested changes 2020-12-11 11:03:23 +00:00
Dismissed
modules/config/login.go Outdated
@ -49,0 +66,4 @@
}
loginExist := false
for i := range config.Logins {
noerw commented 2020-12-11 11:02:32 +00:00
Member
Copy Link

Why not use GetLoginByName() here?

Why not use `GetLoginByName()` here?
6543 commented 2020-12-11 12:20:55 +00:00
Author
Owner
Copy Link

because we have to itterate and set Default=false to all others

we could switch to a hashmap ... but this need some more refactoring

because we have to itterate and set Default=false to all others we could switch to a hashmap ... but this need some more refactoring
noerw commented 2020-12-11 12:22:28 +00:00
Member
Copy Link

ah, got it

ah, got it
noerw marked this conversation as resolved
modules/config/login.go Outdated
@ -52,1 +83,4 @@
// GetLoginByName get login by name (case insensitive)
func GetLoginByName(name string) *Login {
err := loadConfig()
noerw commented 2020-12-11 11:03:02 +00:00
Member
Copy Link

We reload config file for each function call now, can we avoid this?

We reload config file for each function call now, can we avoid this?
noerw commented 2020-12-11 11:04:55 +00:00
Member
Copy Link

Oh never mind, just saw the once-change in loadConfig ?

Oh never mind, just saw the `once`-change in loadConfig ?
noerw marked this conversation as resolved
noerw approved these changes 2020-12-11 12:22:52 +00:00
Dismissed
6543 added 1 commit 2020-12-11 13:46:12 +00:00
Merge branch 'master' into unexport-ConfigVar
All checks were successful
continuous-integration/drone/pr Build is passing
Details
941cc3cf75
6543 added 1 commit 2020-12-11 13:55:34 +00:00
move FindSSHKey to task module
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7267cd0afb
6543 added 1 commit 2020-12-11 14:04:56 +00:00
split task/login into two
All checks were successful
continuous-integration/drone/pr Build is passing
Details
b1285630ea
6543 commented 2020-12-11 14:06:28 +00:00
Author
Owner
Copy Link

@noerw changed a bit more since your last review - so here's the ping ;)

@noerw changed a bit more since your last review - so here's the ping ;)
noerw approved these changes 2020-12-11 14:57:14 +00:00
Dismissed
noerw left a comment
Member
Copy Link

still good with me

still good with me
6543 added 1 commit 2020-12-11 22:04:19 +00:00
Merge branch 'master' into unexport-ConfigVar
All checks were successful
continuous-integration/drone/pr Build is passing
Details
d57ae37280
zeripath approved these changes 2020-12-12 13:26:00 +00:00
Dismissed
6543 removed the
status/needs-reviews
 label 2020-12-12 13:27:46 +00:00
6543 merged commit c063329e9a into master 2020-12-12 13:28:38 +00:00
6543 deleted branch unexport-ConfigVar 2020-12-12 13:28:46 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.6.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#288
No description provided.
Delete Branch "6543/tea:unexport-ConfigVar"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?