gitea/tea
gitea
/
tea
56
114
Fork 56
Code Issues 89 Pull Requests 14 Actions Releases 16 Activity

Add commands for reviews #315

Merged
6543 merged 9 commits from noerw/tea:reviews into master 2020-12-21 15:22:23 +00:00
Conversation 0 Commits 9 Files Changed 18 +1121
noerw commented 2020-12-18 16:28:44 +00:00
Member
Copy Link

Adds tea pr review, tea pr approve, tea pr reject.

demo

fixes #131

Adds `tea pr review`, `tea pr approve`, `tea pr reject`. ![demo](https://gitea.com/attachments/78c64512-66d2-4434-8639-c00b01a9dd99) fixes #131
review.gif
928 KiB
:gitea: 3 ❤️ 2 🎉 1
noerw added 3 commits 2020-12-18 16:28:45 +00:00
noerw added this to the v0.7.0 milestone 2020-12-18 16:30:28 +00:00
noerw added the
kind
feature
 label 2020-12-18 16:30:36 +00:00
lunny approved these changes 2020-12-19 08:35:13 +00:00
Dismissed
noerw added 1 commit 2020-12-19 08:58:13 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
2d520128c7
vendor slimmed down diff parser
noerw added 2 commits 2020-12-19 09:33:43 +00:00
91a4f43a44
review diff: default to true 
if users want a shortcut, they can use lgtm or reject subcmds
All checks were successful
continuous-integration/drone/pr Build is passing
Details
cc9311a1a1
`tea pr approve`: accept optional comment
noerw added 1 commit 2020-12-21 13:41:53 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
8d3b68d2ce Merge branch 'master' into reviews
6543 requested changes 2020-12-21 14:56:01 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

a realy nice work!

a realy nice work!
cmd/pulls/reject.go Outdated
@ -0,0 +38,4 @@
comment := strings.Join(ctx.Args().Tail(), " ")
return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
6543 commented 2020-12-21 14:53:02 +00:00
Owner
Copy Link
-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
+		return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil)
```diff - return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil) + return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil) ```
noerw commented 2020-12-21 15:03:34 +00:00
Author
Member
Copy Link

good catch

good catch
noerw marked this conversation as resolved
noerw added 1 commit 2020-12-21 15:03:16 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
7e1479d4f4
fix copy paste error
noerw added 1 commit 2020-12-21 15:06:06 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
Details
19aa421e3e
clean go.mod
6543 approved these changes 2020-12-21 15:21:11 +00:00
Dismissed
6543 merged commit 8bb5c15745 into master 2020-12-21 15:22:23 +00:00
6543 deleted branch reviews 2020-12-21 15:22:36 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#315
No description provided.
Delete Branch "noerw/tea:reviews"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?