gitea
/
tea
32
54
Fork 23
Code Issues 43 Pull Requests 3 Releases 11 Activity
Labels Milestones
New Pull Request

Add commands for reviews #315

Merged
6543 merged 9 commits from noerw/tea:reviews into master 4 months ago
Conversation 0 Commits 9 Files Changed 18
noerw commented 4 months ago

Adds tea pr review, tea pr approve, tea pr reject.

demo

fixes #131

Adds `tea pr review`, `tea pr approve`, `tea pr reject`. ![demo](https://gitea.com/attachments/78c64512-66d2-4434-8639-c00b01a9dd99) fixes #131
review.gif
928 KiB
:gitea: 3 ❤️ 2 🎉 1
noerw added 3 commits 4 months ago
noerw added this to the v0.7.0 milestone 4 months ago
noerw added the
kind/feature
 label 4 months ago
lunny approved these changes 4 months ago
noerw added 1 commit 4 months ago
continuous-integration/drone/pr Build is passing
Details
2d520128c7
vendor slimmed down diff parser
noerw added 2 commits 4 months ago
91a4f43a44
review diff: default to true
continuous-integration/drone/pr Build is passing
Details
cc9311a1a1
`tea pr approve`: accept optional comment
noerw added 1 commit 4 months ago
continuous-integration/drone/pr Build is passing
Details
8d3b68d2ce Merge branch 'master' into reviews
6543 requested changes 4 months ago
6543 left a comment

a realy nice work!

cmd/pulls/reject.go Outdated
comment := strings.Join(ctx.Args().Tail(), " ")
return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
6543 commented 4 months ago
Poster
Collaborator 
-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
+		return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil)
```diff - return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil) + return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil) ```
noerw commented 4 months ago
Poster

good catch

good catch
noerw marked this conversation as resolved
noerw added 1 commit 4 months ago
continuous-integration/drone/pr Build is passing
Details
7e1479d4f4
fix copy paste error
noerw added 1 commit 4 months ago
continuous-integration/drone/pr Build is passing
Details
19aa421e3e
clean go.mod
6543 approved these changes 4 months ago
6543 merged commit 8bb5c15745 into master 4 months ago
6543 referenced this issue from a commit 4 months ago
Add commands for reviews (#315)
6543 deleted branch reviews 4 months ago

Reviewers

lunny approved these changes 4 months ago
6543 approved these changes 4 months ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 8bb5c15745.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
lunny
6543
Labels
Apply labels
Clear labels
kind/breaking kind/bug kind/build kind/deployment kind/docs kind/enhancement kind/feature kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation priority/critical priority/high priority/low priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/has-backport status/has-pull status/needs-backport status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/sdk
No Label kind/breaking kind/bug kind/build kind/deployment kind/docs kind/enhancement kind/feature kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation priority/critical priority/high priority/low priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/has-backport status/has-pull status/needs-backport status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/sdk
Milestone
Set milestone
Clear milestone
No items
No Milestone
v0.7.0
Assignees
Assign users
Clear assignees
No Assignees
4 Participants
Notifications
Due Date

No due date set.

Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'noerw/tea:reviews'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes