Add commands for reviews #315

Merged
6543 merged 9 commits from noerw/tea:reviews into master 2020-12-21 15:22:23 +00:00
Member

Adds tea pr review, tea pr approve, tea pr reject.

demo

fixes #131

Adds `tea pr review`, `tea pr approve`, `tea pr reject`. ![demo](https://gitea.com/attachments/78c64512-66d2-4434-8639-c00b01a9dd99) fixes #131
928 KiB
noerw added 3 commits 2020-12-18 16:28:45 +00:00
noerw added this to the v0.7.0 milestone 2020-12-18 16:30:28 +00:00
noerw added the
kind
feature
label 2020-12-18 16:30:36 +00:00
lunny approved these changes 2020-12-19 08:35:13 +00:00
Dismissed
noerw added 1 commit 2020-12-19 08:58:13 +00:00
vendor slimmed down diff parser
All checks were successful
continuous-integration/drone/pr Build is passing
2d520128c7
noerw added 2 commits 2020-12-19 09:33:43 +00:00
if users want a shortcut, they can use lgtm or reject subcmds
tea pr approve: accept optional comment
All checks were successful
continuous-integration/drone/pr Build is passing
cc9311a1a1
noerw added 1 commit 2020-12-21 13:41:53 +00:00
Merge branch 'master' into reviews
All checks were successful
continuous-integration/drone/pr Build is passing
8d3b68d2ce
6543 requested changes 2020-12-21 14:56:01 +00:00
Dismissed
6543 left a comment
Owner

a realy nice work!

a realy nice work!
@ -0,0 +38,4 @@
comment := strings.Join(ctx.Args().Tail(), " ")
return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
Owner
-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
+		return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil)
```diff - return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil) + return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil) ```
Author
Member

good catch

good catch
noerw marked this conversation as resolved
noerw added 1 commit 2020-12-21 15:03:16 +00:00
fix copy paste error
All checks were successful
continuous-integration/drone/pr Build is passing
7e1479d4f4
noerw added 1 commit 2020-12-21 15:06:06 +00:00
clean go.mod
All checks were successful
continuous-integration/drone/pr Build is passing
19aa421e3e
6543 approved these changes 2020-12-21 15:21:11 +00:00
Dismissed
6543 merged commit 8bb5c15745 into master 2020-12-21 15:22:23 +00:00
6543 deleted branch reviews 2020-12-21 15:22:36 +00:00
Sign in to join this conversation.
No description provided.