Add commands for reviews #315

Merged
6543 merged 9 commits from noerw/tea:reviews into master 2 years ago
noerw commented 2 years ago
Collaborator

Adds tea pr review, tea pr approve, tea pr reject.

demo

fixes #131

Adds `tea pr review`, `tea pr approve`, `tea pr reject`. ![demo](https://gitea.com/attachments/78c64512-66d2-4434-8639-c00b01a9dd99) fixes #131
928 KiB
noerw added this to the v0.7.0 milestone 2 years ago
noerw added the
kind/feature
label 2 years ago
lunny approved these changes 2 years ago
Dismissed
6543 requested changes 2 years ago
Dismissed
6543 left a comment
Owner

a realy nice work!

a realy nice work!
@ -0,0 +38,4 @@
comment := strings.Join(ctx.Args().Tail(), " ")
return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
6543 commented 2 years ago
Owner
-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
+		return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil)
```diff - return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil) + return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil) ```
noerw commented 2 years ago
Poster
Collaborator

good catch

good catch
noerw marked this conversation as resolved
6543 approved these changes 2 years ago
Dismissed
6543 merged commit 8bb5c15745 into master 2 years ago
6543 referenced this issue from a commit 2 years ago
6543 deleted branch reviews 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 8bb5c15745.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b noerw-reviews master
git pull reviews

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff noerw-reviews
git push origin master
Sign in to join this conversation.
Loading…
There is no content yet.