Add commands for reviews #315

Merged

6543 merged 9 commits from noerw/tea:reviews into master

noerw commented

Collaborator

Adds tea pr review, tea pr approve, tea pr reject.

fixes #131

review.gif

928 KiB

3 ❤️ 2 🎉 1

noerw added 3 commits

acf453b0e9

add interactive `tea pr review`

it's amazingly simple

0b31a776b8

vendor gitea.com/noerw/unidiff-comments

6e736e0972

add `tea pr lgtm|reject` shorthands

noerw added this to the v0.7.0 milestone

noerw added the kind/feature label

lunny approved these changes

Dismissed

noerw added 1 commit

2d520128c7

vendor slimmed down diff parser

noerw added 2 commits

91a4f43a44

review diff: default to true

if users want a shortcut, they can use lgtm or reject subcmds

cc9311a1a1

`tea pr approve`: accept optional comment

noerw added 1 commit

8d3b68d2ce Merge branch 'master' into reviews

6543 requested changes

Dismissed

6543 left a comment

Collaborator

a realy nice work!

cmd/pulls/reject.go Outdated

6543 commented

Collaborator

-		return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)
+		return task.CreatePullReview(ctx, idx, gitea.ReviewStateRequestChanges, comment, nil)

noerw commented

Poster

Collaborator

good catch

noerw marked this conversation as resolved

noerw added 1 commit

7e1479d4f4

fix copy paste error

noerw added 1 commit

19aa421e3e

clean go.mod

6543 approved these changes

Dismissed

6543 merged commit 8bb5c15745 into master 2 years ago

6543 referenced this issue from a commit

Add commands for reviews (#315)

6543 deleted branch reviews

continuous-integration/drone/pr Build is passing

Details

The pull request has been merged as 8bb5c15745.

No reviewers

No Assignees

4 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#315


				`comment := strings.Join(ctx.Args().Tail(), " ")`

				`return task.CreatePullReview(ctx, idx, gitea.ReviewStateApproved, comment, nil)`