don't push before creating a pull #334
Merged
6543
merged 3 commits from noerw/tea:fix-333-pr-create-push
into master
2 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'noerw/tea:fix-333-pr-create-push'
Deleting a branch is permanent. It CANNOT be undone. Continue?
Not sure if this is the best way, but it's the simplest way to fix #333.
Everything else is overly complex due to a chicken-egg problem:
Knowing which remote / branch to push involves requires prompting the user,
which requires to have a upstream branch pushed to detect default values.
Note:
gh
automatically pushes and creates a upstream branch if necessary, which is much better UX.For
tea
this is difficult, as we don't know about the intended PR head remote / repo. Maybe we should addDefaultPRHeadRepo
toLogin
config to solve this?long term we could load the gitea.Repository obj into context ... & check witch permissions we have -> if we dont have push permission check if we own forks if there is > 1 use this as head 🚀
d474883e90
into master 2 months agod474883e90
.