don't push before creating a pull #334

Merged
6543 merged 3 commits from noerw/tea:fix-333-pr-create-push into master 2 months ago
noerw commented 2 months ago

Not sure if this is the best way, but it's the simplest way to fix #333.
Everything else is overly complex due to a chicken-egg problem:
Knowing which remote / branch to push involves requires prompting the user,
which requires to have a upstream branch pushed to detect default values.

Not sure if this is the best way, but it's the simplest way to fix #333. Everything else is overly complex due to a chicken-egg problem: Knowing which remote / branch to push involves requires prompting the user, which requires to have a upstream branch pushed to detect default values.
noerw added this to the v0.7.0 milestone 2 months ago
noerw added the
kind/bug
label 2 months ago
noerw added 1 commit 2 months ago
5df68437ba
don't push before creating a pull
6543 added 1 commit 2 months ago
0520efa9d5 Merge branch 'master' into fix-333-pr-create-push
Poster

Note: gh automatically pushes and creates a upstream branch if necessary, which is much better UX.
For tea this is difficult, as we don't know about the intended PR head remote / repo. Maybe we should add DefaultPRHeadRepo to Login config to solve this?

Note: `gh` automatically pushes and creates a upstream branch if necessary, which is much better UX. For `tea` this is difficult, as we don't know about the intended PR head remote / repo. Maybe we should add `DefaultPRHeadRepo` to `Login` config to solve this?
Collaborator

long term we could load the gitea.Repository obj into context ... & check witch permissions we have -> if we dont have push permission check if we own forks if there is > 1 use this as head 🚀

long term we could load the gitea.Repository obj into context ... & check witch permissions we have -> if we dont have push permission check if we own forks if there is > 1 use this as head 🚀
6543 added 1 commit 2 months ago
1bf61a369e Merge branch 'master' into fix-333-pr-create-push
6543 approved these changes 2 months ago
Dismissed
zeripath approved these changes 2 months ago
Dismissed
khmarbaise approved these changes 2 months ago
Dismissed
6543 merged commit d474883e90 into master 2 months ago
6543 referenced this issue from a commit 2 months ago
6543 deleted branch fix-333-pr-create-push 2 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as d474883e90.
Sign in to join this conversation.
Loading…
There is no content yet.