don't push before creating a pull #334

noerw · 2021-03-04T18:18:34Z

noerw commented

2021-03-04 18:18:34 +00:00

Not sure if this is the best way, but it's the simplest way to fix #333.
Everything else is overly complex due to a chicken-egg problem:
Knowing which remote / branch to push involves requires prompting the user,
which requires to have a upstream branch pushed to detect default values.

Not sure if this is the best way, but it's the simplest way to fix #333. Everything else is overly complex due to a chicken-egg problem: Knowing which remote / branch to push involves requires prompting the user, which requires to have a upstream branch pushed to detect default values.

noerw added this to the v0.7.0 milestone 2021-03-04 18:18:34 +00:00

noerw added the

kind/bug

label 2021-03-04 18:18:34 +00:00

noerw added 1 commit 2021-03-04 18:18:35 +00:00

don't push before creating a pull

This is the simplest way to resolve #333. everything else is overly complex:
Knowing which remote / branch to push involves requires prompting, which
requires to have a upstream branch pushed to detect default values.

continuous-integration/drone/pr Build is passing

Details

5df68437ba

6543 added 1 commit 2021-03-05 08:57:57 +00:00

Merge branch 'master' into fix-333-pr-create-push

continuous-integration/drone/pr Build is passing

Details

0520efa9d5

noerw commented

2021-03-05 09:44:05 +00:00

Note: gh automatically pushes and creates a upstream branch if necessary, which is much better UX.
For tea this is difficult, as we don't know about the intended PR head remote / repo. Maybe we should add DefaultPRHeadRepo to Login config to solve this?

Note: `gh` automatically pushes and creates a upstream branch if necessary, which is much better UX. For `tea` this is difficult, as we don't know about the intended PR head remote / repo. Maybe we should add `DefaultPRHeadRepo` to `Login` config to solve this?

6543 commented

2021-03-05 09:51:21 +00:00

long term we could load the gitea.Repository obj into context ... & check witch permissions we have -> if we dont have push permission check if we own forks if there is > 1 use this as head ?

👍 1

6543 added 1 commit 2021-03-05 10:07:11 +00:00

Merge branch 'master' into fix-333-pr-create-push

continuous-integration/drone/pr Build is passing

Details

1bf61a369e

6543 approved these changes 2021-03-05 10:07:26 +00:00

Dismissed

6543 referenced this pull request

2021-03-05 10:08:02 +00:00

Enhance `create pull` #338

zeripath approved these changes 2021-03-05 10:14:53 +00:00