gitea
/
tea
42
89
Fork 41
Code Issues 65 Pull Requests 7 Releases 13 Activity
Labels Milestones

Implement notification subcommands #389

Merged
6543 merged 20 commits from noerw/tea:notification-subcmds into master 11 months ago
Conversation 2 Commits 20 Files Changed 11
noerw commented 12 months ago
Collaborator
  • enhance notification listing
    • add --states and --type filters
    • toggle per-user or per-repo listing via --mine flag
    • print more fields
  • add subcommands to mark notifications as read, unread, pinned, unpinned. operates on
    • all notifications matching the --state and --mine filter flags, or
    • a notification specified by ID.
  • add a --fields flag for notifications listing. not in this PR
  • interactive mode not in this PR. this would go well together with #324

fixes #243, fixes #155

based on initial work in #283 and #386, but opening a new PR for @6543 to review as I changed quite a lot

⚠️ breaking ⚠️

  • tea notifications --all has moved to tea notifications --mine
  • tea notifications now only works with the context of a remote repo.
    To run this outside of a local git dir, run either tea n --mine or tea n --repo <my/repo>

aside: while developing i discovered a couple of issues with the notifications APIs:

- [x] enhance notification listing - add `--states` and `--type` filters - toggle per-user or per-repo listing via `--mine` flag - print more fields - [x] add subcommands to mark notifications as read, unread, pinned, unpinned. operates on - all notifications matching the `--state` and `--mine` filter flags, or - a notification specified by ID. - [ ] ~~add a `--fields` flag for notifications listing.~~ *not in this PR* - [ ] ~~interactive mode~~ *not in this PR*. this would go well together with #324 fixes #243, fixes #155 based on initial work in #283 and #386, but opening a new PR for @6543 to review as I changed quite a lot --- ### ⚠️ breaking ⚠️ - `tea notifications --all` has moved to `tea notifications --mine` - `tea notifications` now only works with the context of a remote repo. To run this outside of a local git dir, run either `tea n --mine` or `tea n --repo <my/repo>` --- aside: while developing i discovered a couple of issues with the notifications APIs: - https://github.com/go-gitea/gitea/issues/16733 - https://github.com/go-gitea/gitea/issues/16796 - https://github.com/go-gitea/gitea/issues/16797
👍 1
noerw added this to the v0.8.0 milestone 12 months ago
noerw added the
kind/feature
 label 12 months ago
noerw added 18 commits 12 months ago
74047bee0d
add subcomands for notifications
f978713928
Fixed exported function comments.
91b5db3e42
Integrated review comments.
481132ffdb
Moved notifications_list from task into cmd/notifications
continuous-integration/drone/pr Build is failing
Details
abd32a7074
WIP - Improved.
continuous-integration/drone/pr Build is passing
Details
be0e857273
code dedub
continuous-integration/drone/pr Build is passing
Details
0f12c0a77f
Next dedub
5ee01374bf
refactor FieldsFlag as CsvFlag for reusability
4acda8d111
rename --for-user flag to --mine for consistency
continuous-integration/drone/pr Build is failing
Details
8414c23ed5
print notification id
noerw requested review from 6543 12 months ago
noerw added 1 commit 12 months ago
continuous-integration/drone/pr Build is passing
Details
4b87414787
lint
6543 added 1 commit 11 months ago
continuous-integration/drone/pr Build is passing
Details
526e665e51 Merge branch 'master' into notification-subcmds
6543 commented 11 months ago
Collaborator

nice refactor and works great!

one thing: why did you rename --all to --mine ?

nice refactor and works great! one thing: why did you rename `--all` to `--mine` ?
6543 commented 11 months ago
Collaborator

☝️ noerw: "... for consistency with `tea time --mine` ..."

I can live with that ;)

☝️ ``` noerw: "... for consistency with `tea time --mine` ..." ``` I can live with that ;)
6543 approved these changes 11 months ago
noerw added the
kind/breaking
 label 11 months ago
axifive approved these changes 11 months ago
axifive left a comment

looks good

looks good
6543 merged commit 5b28a05eb7 into master 11 months ago
6543 deleted branch notification-subcmds 11 months ago

Reviewers

6543 approved these changes 11 months ago
axifive approved these changes 11 months ago
continuous-integration/drone/pr Build is passing
Details
The pull request has been merged as 5b28a05eb7.
Sign in to join this conversation.
Reviewers
Request review
No reviewers
6543
axifive
Labels
Apply labels
Clear labels
kind/breaking kind/bug kind/build kind/dependency kind/deployment kind/docs kind/enhancement kind/feature kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation priority/critical priority/high priority/low priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/has-backport status/has-pull status/needs-backport status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/sdk
No Label kind/breaking kind/bug kind/build kind/dependency kind/deployment kind/docs kind/enhancement kind/feature kind/proposal kind/question kind/refactor kind/security kind/testing kind/translation priority/critical priority/high priority/low priority/medium reviewed/duplicate reviewed/invalid reviewed/wontfix skip-changelog status/blocked status/has-backport status/has-pull status/needs-backport status/needs-feedback status/needs-reviews status/wip upstream/gitea upstream/sdk
Milestone
Set milestone
Clear milestone
No items
No Milestone
v0.8.0
Assignees
Assign users
Clear assignees
No Assignees
3 Participants
Notifications
Due Date

No due date set.

Reference: gitea/tea#389
Write Preview
Loading…
Cancel
Save
There is no content yet.
Delete Branch 'noerw/tea:notification-subcmds'

Deleting a branch is permanent. It CANNOT be undone. Continue?

No
Yes