Implement notification subcommands #389
Merged
6543
merged 20 commits from noerw/tea:notification-subcmds
into master
11 months ago
Loading…
Reference in new issue
There is no content yet.
Delete Branch 'noerw/tea:notification-subcmds'
Deleting a branch is permanent. It CANNOT be undone. Continue?
--states
and--type
filters--mine
flag--state
and--mine
filter flags, oradd anot in this PR--fields
flag for notifications listing.interactive modenot in this PR. this would go well together with #324fixes #243, fixes #155
based on initial work in #283 and #386, but opening a new PR for @6543 to review as I changed quite a lot
⚠️ breaking ⚠️
tea notifications --all
has moved totea notifications --mine
tea notifications
now only works with the context of a remote repo.To run this outside of a local git dir, run either
tea n --mine
ortea n --repo <my/repo>
aside: while developing i discovered a couple of issues with the notifications APIs:
nice refactor and works great!
one thing: why did you rename
--all
to--mine
?☝️
noerw: "... for consistency with `tea time --mine` ..."
I can live with that ;)
looks good
5b28a05eb7
into master 11 months agoReviewers
5b28a05eb7
.