Correctly match login by ssh host with port #391

noerw · 2021-08-25T07:46:07Z

noerw commented

2021-08-25 07:46:07 +00:00

fixes #380

note: It seems like it was expected that SSHHost only contains the host portion. So this may be breaking (although I don't believe many people used the feature like that with a custom ssh port). I can't think of a good reason to not specify the port in that field, including the port seems more intuitive

fixes #380 note: It seems like it was expected that `SSHHost` only contains the host portion. So this may be breaking (although I don't believe many people used the feature like that with a custom ssh port). I can't think of a good reason to *not* specify the port in that field, including the port seems more intuitive

noerw added this to the v0.8.0 milestone 2021-08-25 07:46:07 +00:00

noerw added the

kind/bug

label 2021-08-25 07:46:07 +00:00

noerw added 1 commit 2021-08-25 07:46:08 +00:00

properly match login via ssh host with port

continuous-integration/drone/pr Build is passing

Details

ed3175ec08

zeripath approved these changes 2021-08-30 16:48:08 +00:00

lunny approved these changes 2021-08-31 07:14:42 +00:00

lunny added 1 commit 2021-08-31 07:14:48 +00:00