Correctly match login by ssh host with port #391

Merged
6543 merged 3 commits from noerw/tea:fix-380 into master 2 months ago
noerw commented 2 months ago

fixes #380

note: It seems like it was expected that SSHHost only contains the host portion. So this may be breaking (although I don't believe many people used the feature like that with a custom ssh port). I can't think of a good reason to not specify the port in that field, including the port seems more intuitive

fixes #380 note: It seems like it was expected that `SSHHost` only contains the host portion. So this may be breaking (although I don't believe many people used the feature like that with a custom ssh port). I can't think of a good reason to *not* specify the port in that field, including the port seems more intuitive
noerw added this to the v0.8.0 milestone 2 months ago
noerw added the
kind/bug
label 2 months ago
noerw added 1 commit 2 months ago
ed3175ec08 properly match login via ssh host with port
zeripath approved these changes 2 months ago
lunny approved these changes 2 months ago
lunny added 1 commit 2 months ago
cac527a991 Merge branch 'master' into fix-380
6543 added 1 commit 2 months ago
7cad16391e Merge branch 'master' into fix-380
6543 merged commit 808e8b1c5a into master 2 months ago
6543 deleted branch fix-380 2 months ago

Reviewers

zeripath approved these changes 2 months ago
lunny approved these changes 2 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 808e8b1c5a.
Sign in to join this conversation.
Loading…
There is no content yet.