Drop features to reduce friction on first use #395

noerw · 2021-09-04T13:32:59Z

noerw commented

2021-09-04 13:32:59 +00:00

This implements the proposal #379. Check the commit messages for a summary of changes.
To try these changes, run

tea pr checkout 395
make install

For now this is a preview to evaluate the proposal (I'll properly upstream the changes to go-git, and split this PR up as necessary).
Let me know what you think.

This implements the proposal #379. Check the commit messages for a summary of changes. To try these changes, run ``` tea pr checkout 395 make install ``` For now this is a preview to evaluate the proposal (I'll properly upstream the changes to go-git, and split this PR up as necessary). Let me know what you think.

noerw added the

kind/breaking

kind/proposal

labels 2021-09-04 13:32:59 +00:00

noerw added 5 commits 2021-09-04 13:33:00 +00:00

drop --remote flag

replacement: If you need to specify a different remote repo, just use the --repo flag explicitly

16f7670f8d

--repo: drop support for local repos

if you need to operate on a different local repo, `cd` to it first

6c3d1358a6

remove ssh support

for git operations, rewrite SSH remote urls as https internally

this currently requires a custom patch of gogit to implement
dynamically setting the remote URL for fetch/push operations:
https://github.com/go-git/go-git/issues/173

a945b62c81

pr create: add --head-repo flag

the previous way to specify a fork head (owner:branch) remains functional

b9e11cb33b

document more assumptions

continuous-integration/drone/pr Build is failing

Details

472d105a3c

noerw commented

2021-09-15 13:37:51 +00:00

upstream go-git PR: https://github.com/go-git/go-git/pull/375

continuous-integration/drone/pr Build is failing

Details

check-and-test / check-and-test (pull_request)

Required

This pull request has changes conflicting with the target branch.

cmd/flags/flags.go
cmd/login/add.go
cmd/pulls/create.go
main.go
modules/context/context.go
modules/git/auth.go
modules/interact/login.go
modules/interact/pull_create.go
modules/task/login_create.go
modules/task/login_ssh.go

View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u drop-features:noerw-drop-features

git checkout noerw-drop-features

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#395