gitea/tea
gitea/tea
57
135
Fork 67
Code Issues 102 Pull Requests 8 Actions Releases 16 Activity

Don't skip reading the local repo when --repo specifies a repo slug #398

Merged
6543 merged 3 commits from noerw/tea:fix/378-repoflag-context into master 2021-09-22 16:12:57 +00:00
Conversation 1 Commits 3 Files Changed 1 +7 -8
noerw commented 2021-09-12 09:35:35 +00:00
Member
Copy Link

I added this check in #327, but it wasn't needed at all
as the error case it intended to catch where already handled by checking if the path exists.

fixes #378

I added this check in #327, but it wasn't needed at all as the error case it intended to catch where already handled by checking if the path exists. fixes #378
noerw added this to the v0.8.0 milestone 2021-09-12 09:35:35 +00:00
noerw added the
kind/bug
 label 2021-09-12 09:35:35 +00:00
noerw added 1 commit 2021-09-12 09:35:36 +00:00
dont skip reading local repo when repo flag specifies a repo slug
All checks were successful
continuous-integration/drone/pr Build is passing
Details
21171731e7 
the check was added in #327, but isnt needed, as the error case is already handled by the path exists check
6543 approved these changes 2021-09-22 00:54:03 +00:00
6543 commented 2021-09-22 00:54:24 +00:00
Owner
Copy Link

in combination with #393 - it fixes the issue

in combination with #393 - it fixes the issue
6543 added 1 commit 2021-09-22 00:54:30 +00:00
Merge branch 'master' into fix/378-repoflag-context
All checks were successful
continuous-integration/drone/pr Build is passing
Details
853786c549
6543 added 1 commit 2021-09-22 15:49:04 +00:00
Merge branch 'master' into fix/378-repoflag-context
All checks were successful
continuous-integration/drone/pr Build is passing
Details
30a71b7685
zeripath approved these changes 2021-09-22 15:55:04 +00:00
6543 merged commit 1731e00ebd into master 2021-09-22 16:12:57 +00:00
6543 deleted branch fix/378-repoflag-context 2021-09-22 16:13:11 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
6543
zeripath
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.8.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#398
No description provided.
Delete Branch "noerw/tea:fix/378-repoflag-context"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?