unified output (#14) #40

root360-AndreasUlm · 2019-07-14T16:05:58Z

root360-AndreasUlm commented

2019-07-14 16:05:58 +00:00

replaces #25

replaces https://gitea.com/gitea/tea/pulls/25

root360-AndreasUlm commented

2019-07-14 16:37:25 +00:00

@lunny can you check the build result which failed due to failed pull of git module

Update:
Got it fixed by rebasing to master.

@lunny can you check the build result which failed due to failed pull of git module Update: Got it fixed by rebasing to master.

lunny added the

kind

enhancement

label 2019-07-15 06:14:24 +00:00

lunny reviewed 2019-07-15 11:34:39 +00:00

Dismissed

cmd/issues.go Outdated

lunny commented

2019-07-15 11:34:39 +00:00

How about remove string( and )?

How about remove `string(` and `)`?

lafriks requested changes 2019-08-15 08:09:37 +00:00

Dismissed

cmd/issues.go Outdated

						
				@ -37,1 +37,4 @@

						},

						cli.StringFlag{

							Name:        "output, o",

							Usage:       "Specify output format. (table)",

lafriks commented

2019-08-15 08:09:31 +00:00

			Usage:       "Specify output format. (table)",

to:

			Usage:       "Specify output format - table (default), csv, simple, tsv or yaml.",

same in other places. This string should probably be moved out somewhere to constant

```go Usage: "Specify output format. (table)", ``` to: ```go Usage: "Specify output format - table (default), csv, simple, tsv or yaml.", ``` same in other places. This string should probably be moved out somewhere to constant

root360-AndreasUlm commented

2019-09-14 20:21:36 +00:00

fixed remarks of @lafriks

lunny approved these changes 2019-09-15 02:32:35 +00:00

Dismissed

lunny added this to the v0.1.0 milestone 2019-09-15 02:32:44 +00:00

lunny commented

2019-09-15 02:34:13 +00:00

It's better to give Title more width. Anyhow LGTM, we can improve that on other PRs.

It's better to give `Title` more width. Anyhow LGTM, we can improve that on other PRs. ![image](/attachments/696fa897-be78-481a-a445-ddbc953d42af)

image.png

1.1 MiB

lunny commented

2019-09-15 08:24:12 +00:00

@lafriks needs your review.

lafriks approved these changes 2019-09-15 08:37:47 +00:00

Dismissed

lafriks referenced this issue from a commit

2019-09-15 08:38:19 +00:00

unified output (#14) (#40)

lafriks closed this pull request

2019-09-15 08:38:20 +00:00

lafriks deleted branch 14_unified_output

2019-09-15 08:38:36 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#40