Fix resolving of URLs in markdown #401

Merged
6543 merged 7 commits from noerw/tea:fix/347 into master 2 months ago
noerw commented 4 months ago
Collaborator

Path-only URLs need an absolute reference to be resolved against for printing in markdown
Previously we resolved against the URL to the resource we were operating on (eg comment or issue URL).
The markdown renderer in the web UI resolves all such URLs relative to the repo base URL. This PR adopts this behaviour in tea, by trimming the URL to a repo base URL via regex.

This makes a custom patch to our markdown renderer glamour obsolete, which turned out to be an incorrect patch, meaning we can make use of upstream glamour again.

Path-only URLs need an absolute reference to be resolved against for printing in markdown Previously we resolved against the URL to the resource we were operating on (eg comment or issue URL). The markdown renderer in the web UI resolves all such URLs relative to the repo base URL. This PR adopts this behaviour in tea, by trimming the URL to a repo base URL via regex. This makes a custom patch to our markdown renderer `glamour` obsolete, which turned out to be an incorrect patch, meaning we can make use of upstream glamour again.
noerw added the
kind/enhancement
label 4 months ago
noerw added 2 commits 4 months ago
0a6fbc6386 remove custom patch to glamour
noerw added this to the v0.9.0 milestone 4 months ago
noerw added
kind/bug
and removed
kind/enhancement
labels 4 months ago
noerw added 1 commit 4 months ago
82421aeffa Merge branch 'master' into fix/347
noerw added 1 commit 4 months ago
3b67f074b7 Merge branch 'master' into fix/347
noerw added 1 commit 3 months ago
83c255aa33 Merge branch 'master' into fix/347
lunny approved these changes 3 months ago
noerw added 1 commit 3 months ago
68cbb43667 Merge branch 'master' into fix/347
6543 approved these changes 2 months ago
6543 added 1 commit 2 months ago
fedbd8743f Merge branch 'master' into fix/347
6543 merged commit d2295828d0 into master 2 months ago
6543 referenced this issue from a commit 2 months ago
6543 deleted branch fix/347 2 months ago

Reviewers

lunny approved these changes 3 months ago
6543 approved these changes 2 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as d2295828d0.
Sign in to join this conversation.
Loading…
There is no content yet.