Fix resolving of URLs in markdown #401

noerw · 2021-09-14T10:52:26Z

noerw commented

2021-09-14 10:52:26 +00:00

Path-only URLs need an absolute reference to be resolved against for printing in markdown
Previously we resolved against the URL to the resource we were operating on (eg comment or issue URL).
The markdown renderer in the web UI resolves all such URLs relative to the repo base URL. This PR adopts this behaviour in tea, by trimming the URL to a repo base URL via regex.

This makes a custom patch to our markdown renderer glamour obsolete, which turned out to be an incorrect patch, meaning we can make use of upstream glamour again.

Path-only URLs need an absolute reference to be resolved against for printing in markdown Previously we resolved against the URL to the resource we were operating on (eg comment or issue URL). The markdown renderer in the web UI resolves all such URLs relative to the repo base URL. This PR adopts this behaviour in tea, by trimming the URL to a repo base URL via regex. This makes a custom patch to our markdown renderer `glamour` obsolete, which turned out to be an incorrect patch, meaning we can make use of upstream glamour again.

🎉 1

noerw added the

kind

enhancement

label 2021-09-14 10:52:26 +00:00

noerw added 2 commits 2021-09-14 10:52:27 +00:00

resolve urls relative to repo URL 7ecec8d3ad

remove custom patch to glamour

this is now obsolete, now that we preprocess the base URLs correctly

continuous-integration/drone/pr Build is passing

Details

0a6fbc6386

noerw added this to the v0.9.0 milestone 2021-09-22 21:35:20 +00:00

noerw added

kind/bug

and removed

kind

enhancement

labels 2021-09-22 21:35:36 +00:00

noerw added 1 commit 2021-09-23 11:25:42 +00:00

Merge branch 'master' into fix/347

continuous-integration/drone/pr Build is passing

Details

82421aeffa

noerw added 1 commit 2021-09-29 10:58:36 +00:00

Merge branch 'master' into fix/347

continuous-integration/drone/pr Build is passing

Details

3b67f074b7

noerw added 1 commit 2021-10-09 17:05:29 +00:00

Merge branch 'master' into fix/347

continuous-integration/drone/pr Build is passing

Details

83c255aa33

lunny approved these changes 2021-10-22 05:22:12 +00:00

noerw added 1 commit 2021-10-22 07:46:55 +00:00

Merge branch 'master' into fix/347

continuous-integration/drone/pr Build is passing

Details

68cbb43667

6543 approved these changes 2021-12-02 18:35:19 +00:00

6543 added 1 commit 2021-12-02 18:35:27 +00:00

Merge branch 'master' into fix/347

continuous-integration/drone/pr Build is passing

Details

fedbd8743f

6543 merged commit d2295828d0 into master

2021-12-02 18:59:02 +00:00

6543 referenced this issue from a commit

2021-12-02 18:59:03 +00:00

Fix resolving of URLs in markdown (#401)

6543 deleted branch fix/347

2021-12-02 18:59:12 +00:00

6543 referenced this pull request

2021-12-02 18:59:31 +00:00

Relative markdown URLs should be resolved relative to repo url #347

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#401