Add --fields to notification & milestone listings #422

Merged
6543 merged 22 commits from noerw/tea:fields-flag into main 2022-09-13 19:08:19 +00:00
Member

Together with #415 this finally adds the field flag to all entity listings.
closes #342

⚠️ breaking changes ⚠️

This changes the column names of tea milestones ls:

 - TITLE  | OPEN/CLOSED ISSUES | DUEDATE
 + TITLE  | ITEMS | DUEDATE
Together with #415 this finally adds the field flag to all entity listings. closes #342 ### ⚠️ breaking changes ⚠️ This changes the column names of `tea milestones ls`: ```diff - TITLE | OPEN/CLOSED ISSUES | DUEDATE + TITLE | ITEMS | DUEDATE ```
noerw added this to the v0.9.0 milestone 2021-09-28 17:21:54 +00:00
noerw added the
kind
enhancement
label 2021-09-28 17:21:54 +00:00
noerw added 4 commits 2021-09-28 17:21:55 +00:00
6543 added 1 commit 2021-09-28 20:37:27 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
c6189bf67e
Merge branch 'master' into fields-flag
noerw added 1 commit 2021-09-28 21:05:55 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
771c2b8306
update to new printable interface
noerw added 1 commit 2021-09-28 21:06:19 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
1b5dce46d9
Merge branch 'master' into fields-flag
noerw added 1 commit 2021-10-03 11:16:08 +00:00
Some checks failed
continuous-integration/drone/pr Build is failing
ee01b01f80
Merge branch 'master' into fields-flag
noerw added 1 commit 2021-10-04 17:44:48 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
fbaf9c67c5
Merge branch 'master' into fields-flag
zeripath reviewed 2021-10-10 12:51:53 +00:00
@ -27,0 +35,4 @@
"repository",
// "url1",
// "url2",
// "url3",
Owner

?

?
noerw marked this conversation as resolved
noerw added 1 commit 2021-10-12 06:58:10 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
5e9ba516f0
cleanup
the proper fields will be exposed with go-sdk 0.16 only
noerw added 1 commit 2021-10-12 06:58:25 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
a78dd13279
Merge branch 'master' into HEAD
noerw added 1 commit 2021-10-18 11:31:27 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
efc2ef0370
Merge branch 'master' into fields-flag
6543 added 1 commit 2021-12-02 19:27:13 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
c4e7f97655
Merge branch 'master' into fields-flag
noerw added 1 commit 2021-12-03 12:48:54 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
9d77c621a2
Merge branch 'master' into fields-flag
noerw reviewed 2021-12-23 14:02:18 +00:00
@ -40,0 +40,4 @@
"state",
"open items",
"closed items",
"open/closed issues",
Author
Member

not sure if these long and spaced column names are good, they are a not easy to apply:

tea ms -f 'open items,open/closed issues' ...

will see if I can come up with better values

not sure if these long and spaced column names are good, they are a not easy to apply: ``` tea ms -f 'open items,open/closed issues' ... ``` will see if I can come up with better values
Owner

agree 👍 - rest looks ready :)

agree :+1: - rest looks ready :)
Author
Member

@6543 I finally simplified the field names. I'm not exactly happy with the result, but it's good enough I guess.
This makes the PR breaking though, as we don't return the same fields anymore.

@6543 I finally simplified the field names. I'm not exactly happy with the result, but it's good enough I guess. This makes the PR breaking though, as we don't return the same fields anymore.
6543 marked this conversation as resolved
6543 added 1 commit 2022-01-14 03:57:09 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
f96a7a0478
Merge branch 'master' into fields-flag
6543 added 1 commit 2022-01-31 23:13:10 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
e7c0dc1857
Merge branch 'master' into fields-flag
noerw added 3 commits 2022-03-16 20:07:59 +00:00
5757645874 fix flag.IsSet() checks
turns out, using the flag method does not work, we have to use the
ctx.IsSet() equivalent ¯\_(ツ)_/¯
All checks were successful
continuous-integration/drone/pr Build is passing
12d13c2d20
Merge branch 'master' into fields-flag
noerw added 1 commit 2022-09-13 15:52:06 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
7be2377d2d
Merge branch 'main' into fields-flag
6543 approved these changes 2022-09-13 18:34:04 +00:00
6543 added 1 commit 2022-09-13 18:36:37 +00:00
All checks were successful
continuous-integration/drone/pr Build is passing
36e8208d39
Merge branch 'main' into fields-flag
delvh approved these changes 2022-09-13 18:51:00 +00:00
@ -15,6 +15,10 @@ import (
"github.com/urfave/cli/v2"
)
var notifFieldsFlag = flags.FieldsFlag(print.NotificationFields, []string{
Owner

typo?

typo?
noerw marked this conversation as resolved
noerw added 1 commit 2022-09-13 19:03:36 +00:00
Some checks reported errors
continuous-integration/drone/pr Build was killed
1798864fb2
rename variable
6543 approved these changes 2022-09-13 19:06:23 +00:00
6543 merged commit 99e49991bb into main 2022-09-13 19:08:19 +00:00
6543 deleted branch fields-flag 2022-09-13 19:08:19 +00:00
Sign in to join this conversation.
No description provided.