gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

Add tea whoami command #426

Merged
techknowlogick merged 5 commits from whoami into master 2021-10-04 17:42:00 +00:00
Conversation 3 Commits 5 Files Changed 3 +154
techknowlogick commented 2021-10-04 04:10:32 +00:00
Owner
Copy Link

The User print will be used in future for list of users for admin

The User print will be used in future for list of users for admin
techknowlogick added 1 commit 2021-10-04 04:10:32 +00:00
add whoami cli option
Some checks failed
continuous-integration/drone/pr Build is failing
Details
4475b64f7c
techknowlogick added this to the v0.9.0 milestone 2021-10-04 04:10:42 +00:00
noerw reviewed 2021-10-04 09:07:11 +00:00
cmd/whoami.go Outdated
@ -0,0 +15,4 @@
var CmdWhoami = cli.Command{
Name: "whoami",
Category: catSetup,
Description: `.`,
noerw commented 2021-10-04 09:07:11 +00:00
Member
Copy Link

That looks odd, please use the same content of Usage or elaborate further on the functionality (this string is displayed in tea whoami --help)

That looks odd, please use the same content of `Usage` or elaborate further on the functionality (this string is displayed in `tea whoami --help`)
techknowlogick marked this conversation as resolved
noerw reviewed 2021-10-04 09:07:28 +00:00
cmd/whoami.go Outdated
@ -0,0 +11,4 @@
"github.com/urfave/cli/v2"
)
// CmdTrackedTimes represents the command to operate repositories' times.
noerw commented 2021-10-04 09:07:28 +00:00
Member
Copy Link

linter complains about func comment

linter complains about func comment
techknowlogick marked this conversation as resolved
noerw reviewed 2021-10-04 09:09:32 +00:00
modules/print/user.go Outdated
@ -0,0 +108,4 @@
case "language":
return x.Language
case "is_admin":
return fmt.Sprintf("%t", x.IsAdmin)
noerw commented 2021-10-04 09:09:32 +00:00
Member
Copy Link

we have a FormatBool() helper for consistency

we have a `FormatBool()` helper for consistency
techknowlogick marked this conversation as resolved
noerw requested changes 2021-10-04 09:13:58 +00:00
noerw left a comment
Member
Copy Link

nice feature! just some nits :)

Also, will you add a user listing command too? right now print.UserList() is dead code

nice feature! just some nits :) Also, will you add a user listing command too? right now `print.UserList()` is dead code
noerw changed title from add whoami cli option to Add `tea whoami` command 2021-10-04 09:14:51 +00:00
noerw added the
kind
feature
 label 2021-10-04 09:14:56 +00:00
techknowlogick commented 2021-10-04 15:24:09 +00:00
Author
Owner
Copy Link

Also, will you add a user listing command too? right now print.UserList() is dead code

yes, I hope to add admin commands to list users (and potentially delete them too, for moderation purposes).

I've updated per your feedback, thanks :)

> Also, will you add a user listing command too? right now `print.UserList()` is dead code yes, I hope to add admin commands to list users (and potentially delete them too, for moderation purposes). I've updated per your feedback, thanks :)
axifive reviewed 2021-10-04 17:19:32 +00:00
modules/print/user.go Outdated
@ -0,0 +1,126 @@
// Copyright 2020 The Gitea Authors. All rights reserved.
axifive commented 2021-10-04 17:17:24 +00:00
Member
Copy Link

2021

2021
axifive marked this conversation as resolved
modules/print/user.go Outdated
@ -0,0 +10,4 @@
"code.gitea.io/sdk/gitea"
)
// RepoDetails print an repo formatted to stdout
axifive commented 2021-10-04 17:17:54 +00:00
Member
Copy Link

doc func name

doc func name
techknowlogick marked this conversation as resolved
modules/print/user.go Outdated
@ -0,0 +52,4 @@
), "")
}
// ReposList prints a listing of the repos
axifive commented 2021-10-04 17:18:09 +00:00
Member
Copy Link

same

same
techknowlogick marked this conversation as resolved
techknowlogick added 1 commit 2021-10-04 17:21:17 +00:00
update date
Some checks reported errors
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build was killed
Details
9cc9a32813
techknowlogick commented 2021-10-04 17:22:37 +00:00
Author
Owner
Copy Link

@axifive I've updated per your feedback, please review :)

@axifive I've updated per your feedback, please review :)
👍 1
noerw requested changes 2021-10-04 17:28:57 +00:00
modules/print/user.go Outdated
@ -0,0 +108,4 @@
case "language":
return x.Language
case "is_admin":
return formatBoolean(x.IsAdmin, true)
noerw commented 2021-10-04 17:27:54 +00:00
Member
Copy Link
-		return formatBoolean(x.IsAdmin, true)
+		return formatBoolean(x.IsAdmin, !machineReadable)
```diff - return formatBoolean(x.IsAdmin, true) + return formatBoolean(x.IsAdmin, !machineReadable) ```
techknowlogick commented 2021-10-04 17:30:48 +00:00
Author
Owner
Copy Link

updated

updated
techknowlogick marked this conversation as resolved
techknowlogick added 1 commit 2021-10-04 17:30:09 +00:00
update per feedback
Some checks failed
continuous-integration/drone/push Build is failing
Details
continuous-integration/drone/pr Build is failing
Details
74850739aa
noerw approved these changes 2021-10-04 17:31:01 +00:00
noerw commented 2021-10-04 17:38:21 +00:00
Member
Copy Link

@techknowlogick to get CI passing, we need to merge #425 and update this PR (with :magician: powers maybe? ;)

@techknowlogick to get CI passing, we need to merge #425 and update this PR (with :magician: powers maybe? ;)
axifive approved these changes 2021-10-04 17:41:49 +00:00
techknowlogick merged commit 4ffd994549 into master 2021-10-04 17:42:00 +00:00
techknowlogick deleted branch whoami 2021-10-04 17:42:00 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
noerw
axifive
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.9.0
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#426
No description provided.
Delete Branch "whoami"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?