Fix CI: disable package-comments lint rule #494

noerw · 2022-08-22T12:23:09Z

noerw commented

2022-08-22 12:23:09 +00:00

There was an unintended change to the rule in revive that now makes our CI trip:
https://github.com/mgechev/revive/pull/694
The package-comments now expected are not really worth writing as these are tiny internal packages, so this change just disables that rule for now.

There was an unintended change to the rule in revive that now makes our CI trip: https://github.com/mgechev/revive/pull/694 The package-comments now expected are not really worth writing as these are tiny internal packages, so this change just disables that rule for now.

noerw added the

kind/build

label 2022-08-22 12:23:09 +00:00

noerw added 1 commit 2022-08-22 12:23:10 +00:00

continuous-integration/drone/pr Build is passing

Details

27463c5e99 linter: disable package-comments rule

there was an unintended change to the rule in revive that now makes our CI trip.
those comments are not really worth writing, so we will just disable that rule for now

lunny approved these changes 2022-08-22 12:51:22 +00:00

zeripath approved these changes 2022-08-22 12:53:12 +00:00

zeripath approved these changes 2022-08-22 12:53:13 +00:00

zeripath merged commit d5a258213d into master

2022-08-22 12:53:20 +00:00

zeripath referenced this issue from a commit

2022-08-22 12:53:20 +00:00

Fix CI: disable package-comments lint rule (#494)

noerw deleted branch fixlint

2022-08-22 14:55:37 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: gitea/tea#494