Add Allow Maintainer Edits #509

						
				@ -34,6 +35,7 @@ func PullDetails(pr *gitea.PullRequest, reviews []*gitea.PullReview, ciStatus *g

						FormatTime(*pr.Created, false),

						base,

						head,

						// TODO: pr.AllowMaintainerEdit,

6543 commented

2022-09-15 02:13:29 +00:00

just another sdk update ...

6543 marked this conversation as resolved

noerw reviewed 2022-09-15 14:23:07 +00:00

modules/interact/pull_create.go Outdated

						
				@ -49,6 +52,11 @@ func CreatePull(ctx *context.TeaContext) (err error) {

						return err

					}

					promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false}

noerw commented

2022-09-15 14:23:07 +00:00

-	promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false} 
+	promptC := &survey.Confirm{Message: "Allow Maintainers to push to the base branch", Default: false}

Also maybe default to true?

```diff - promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false} + promptC := &survey.Confirm{Message: "Allow Maintainers to push to the base branch", Default: false} ``` Also maybe default to true?

👍 1

6543 marked this conversation as resolved

6543 reviewed 2022-09-19 13:42:06 +00:00

modules/task/pull_create.go Outdated

						
				@ -69,2 +71,4 @@

					}

					if allowMaintainerEdits {

						pr, _, err = client.EditPullRequest(ctx.Owner, ctx.Repo, pr.ID, gitea.EditPullRequestOption{

6543 commented

2022-09-19 13:42:06 +00:00

pr.Index

6543 marked this conversation as resolved

6543 added 2 commits 2022-09-26 22:10:10 +00:00

default to true 813c3734d4

fix and more TODO

continuous-integration/drone/pr Build is failing

Details

f64cdbef60

6543 added 1 commit 2022-09-26 22:12:14 +00:00

fix

continuous-integration/drone/pr Build is passing

Details

f2d3d5649f

6543 added a new dependency 2022-09-26 23:46:36 +00:00

gitea/go-sdk#606 - Update PullRequest struct

6543 changed title from ~~WIP: Add Allow Maintainer Edits~~ to Add Allow Maintainer Edits

2022-09-27 10:53:27 +00:00

6543 added 3 commits 2022-09-27 10:55:30 +00:00

update sdk 83d884e817

Merge branch 'main' into add_allow-maintainer-edits 53b605940b

resolve todos

continuous-integration/drone/pr Build is passing

Details

c141bb650a

6543 added 1 commit 2022-09-27 11:02:15 +00:00

fancy print

continuous-integration/drone/pr Build is passing

Details

7a339d227f

6543 requested review from Maintainers 2022-09-27 11:03:45 +00:00

noerw reviewed 2022-09-27 11:19:33 +00:00

modules/print/pull.go Outdated

						
				@ -65,2 +65,4 @@

					}

					if pr.AllowMaintainerEdit {

						out += "- Maintainers are allowed to edit"

noerw commented

2022-09-27 11:19:33 +00:00

isn't this missing a newline?

6543 marked this conversation as resolved

noerw approved these changes 2022-09-27 11:20:28 +00:00

noerw left a comment

One nit, otherwise LGTM

6543 added 1 commit 2022-09-27 11:49:13 +00:00

newline

continuous-integration/drone/pr Build is passing

Details

de56e7dd05

strk approved these changes 2022-09-27 15:26:32 +00:00

strk left a comment

I'm approving, but is there no idea about automated testcases for the tea command ?

6543 commented

2022-09-27 15:36:24 +00:00

@strk sadly no :/

-> #504

@strk sadly no :/ -> #504

6543 merged commit 15457f1770 into main

2022-09-27 15:36:36 +00:00

6543 referenced this issue from a commit

2022-09-27 15:36:37 +00:00

Add Allow Maintainer Edits (#509)

6543 deleted branch add_allow-maintainer-edits

2022-09-27 15:36:37 +00:00

Sign in to join this conversation.

No reviewers

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on

#606 Update PullRequest struct

gitea/go-sdk

Reference: gitea/tea#509