Add Allow Maintainer Edits #509

Merged
6543 merged 12 commits from 6543/tea:add_allow-maintainer-edits into main 2 months ago
6543 commented 3 months ago
Collaborator

close #508

![](https://gitea.com/attachments/4b557a92-365b-48a2-b264-0ffdec592033) close #508
6543 added this to the v0.10.0 milestone 3 months ago
6543 added the kind/enhancement label 3 months ago
6543 added 4 commits 3 months ago
6543 changed title from Add Allow Maintainer Edits to WIP: Add Allow Maintainer Edits 3 months ago
6543 reviewed 3 months ago
FormatTime(*pr.Created, false),
base,
head,
// TODO: pr.AllowMaintainerEdit,
6543 commented 3 months ago
Poster
Collaborator

just another sdk update ...

just another sdk update ...
6543 marked this conversation as resolved
noerw reviewed 3 months ago
return err
}
promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false}
noerw commented 3 months ago
Collaborator
-	promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false} 
+	promptC := &survey.Confirm{Message: "Allow Maintainers to push to the base branch", Default: false} 

Also maybe default to true?

```diff - promptC := &survey.Confirm{Message: "Allow Maintainers to push to pull base-branch", Default: false} + promptC := &survey.Confirm{Message: "Allow Maintainers to push to the base branch", Default: false} ``` Also maybe default to true?
6543 marked this conversation as resolved
6543 reviewed 3 months ago
}
if allowMaintainerEdits {
pr, _, err = client.EditPullRequest(ctx.Owner, ctx.Repo, pr.ID, gitea.EditPullRequestOption{
6543 commented 3 months ago
Poster
Collaborator

pr.Index

pr.Index
6543 marked this conversation as resolved
6543 added 2 commits 2 months ago
continuous-integration/drone/pr Build is failing Details
f64cdbef60
fix and more TODO
6543 added 1 commit 2 months ago
continuous-integration/drone/pr Build is passing Details
f2d3d5649f
fix
6543 added a new dependency 2 months ago
6543 changed title from WIP: Add Allow Maintainer Edits to Add Allow Maintainer Edits 2 months ago
6543 added 3 commits 2 months ago
6543 added 1 commit 2 months ago
continuous-integration/drone/pr Build is passing Details
7a339d227f
fancy print
6543 requested review from Maintainers 2 months ago
noerw reviewed 2 months ago
}
if pr.AllowMaintainerEdit {
out += "- Maintainers are allowed to edit"
noerw commented 2 months ago
Collaborator

isn't this missing a newline?

isn't this missing a newline?
6543 marked this conversation as resolved
noerw approved these changes 2 months ago
noerw left a comment
Collaborator

One nit, otherwise LGTM

One nit, otherwise LGTM
6543 added 1 commit 2 months ago
continuous-integration/drone/pr Build is passing Details
de56e7dd05
newline
strk approved these changes 2 months ago
strk left a comment
Collaborator

I'm approving, but is there no idea about automated testcases for the tea command ?

I'm approving, but is there no idea about automated testcases for the tea command ?
6543 commented 2 months ago
Poster
Collaborator

@strk sadly no :/

-> #504

@strk sadly no :/ -> #504
6543 merged commit 15457f1770 into main 2 months ago
6543 referenced this issue from a commit 2 months ago
6543 deleted branch add_allow-maintainer-edits 2 months ago

Reviewers

noerw approved these changes 2 months ago
strk approved these changes 2 months ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 15457f1770.
Sign in to join this conversation.
Loading…
There is no content yet.