gitea/tea
gitea/tea
56
129
Fork 64
Code Issues 97 Pull Requests 19 Actions Releases 16 Activity

add tea times command #54

Merged
lunny merged 20 commits from noerw/tea:50-cmd-times into master 2020-03-06 03:43:34 +00:00
Conversation 19 Commits 20 Files Changed 15 +2507 -29
noerw commented 2019-10-25 14:35:48 +00:00
Member
Copy Link

As proposed in #50

TODO

  • --from, --to flags as filters on TrackedTime.Created

  • vendor new dependency araddon/dateparse

    • help needed, don't know how. put it in the README maybe? run make vendor!

  • don't show internal IDs, but proper user facing names / IDs:

    For some reason the API returns internal IssueID & UserID, instead of IssueIndex & UserName.
    I feel like it shouldn't be the clients job to resolve each of these internal IDs, so we might need an API change here?

  • delete times / reset issue: missing functions in go-sdk, so I skipped that one

As proposed in #50 ### TODO - [x] `--from`, `--to` flags as filters on `TrackedTime.Created` - [x] vendor new dependency `araddon/dateparse` - ~~help needed, don't know how. put it in the README maybe?~~ run `make vendor`! - [x] don't show internal IDs, but proper user facing names / IDs: For some reason the API returns internal IssueID & UserID, instead of IssueIndex & UserName. I feel like it shouldn't be the clients job to resolve each of these internal IDs, so we might need an API change here? - [x] delete times / reset issue: missing functions in go-sdk, so I skipped that one
🎉 3
lunny added the
kind
feature
 label 2019-10-26 04:47:37 +00:00
6543 commented 2019-11-08 03:02:14 +00:00
Owner
Copy Link

I would wait for https://github.com/go-gitea/gitea/issues/8833 and it's stable upstream api

I would wait for https://github.com/go-gitea/gitea/issues/8833 and it's stable upstream api
6543 added the
status/blocked
 label 2019-11-08 03:03:31 +00:00
6543 commented 2019-12-02 05:32:58 +00:00
Owner
Copy Link

status update: https://github.com/go-gitea/gitea/pull/9200 WIP ...

status update: https://github.com/go-gitea/gitea/pull/9200 WIP ...
:gitea: 2
6543 commented 2019-12-17 01:47:02 +00:00
Owner
Copy Link

status update: 9200 is ready, need reviews

status update: 9200 is ready, need reviews
6543 commented 2019-12-17 16:39:11 +00:00
Owner
Copy Link

side notes:

  • can we check the gitea version? and if it is les than 1.11.0 print out that the instance is to old?
  • filter options for --from --to wil get into 1.12.x so if version is less priont out that version for this options is to less PR #9373

-> maby add general function(s) for this? as it could be used in other tea routines

side notes: * [ ] can we check the gitea version? and if it is les than 1.11.0 print out that the instance is to old? * [ ] filter options for --from --to wil get into 1.12.x so if version is less priont out that version for this options is to less [PR #9373](https://github.com/go-gitea/gitea/pull/9373) -> maby add general function(s) for this? as it could be used in other tea routines
6543 added a new dependency 2019-12-30 22:27:57 +00:00
gitea/go-sdk#198 - update TrackedTimes structs (#196)
6543 added
status/wip
 and removed
status/blocked
 labels 2019-12-31 04:14:04 +00:00
6543 commented 2019-12-31 04:14:31 +00:00
Owner
Copy Link

@noerw now nothing is blocking this PR anymore

@noerw now nothing is blocking this PR anymore
lunny commented 2019-12-31 04:15:45 +00:00
Owner
Copy Link

Is this still wip?

Is this still wip?
noerw commented 2019-12-31 10:39:52 +00:00
Author
Member
Copy Link

Yes,
if we're to add the gitea version check as proposed by @6543 in order to enable this feature, we're still blocked by #78 (since ServerVersion() is broken in the old vendored version of the go-sdk)

Yes, if we're to add the gitea version check as proposed by @6543 in order to enable this feature, we're still blocked by #78 (since `ServerVersion()` is broken in the old vendored version of the go-sdk)
6543 added a new dependency 2020-01-01 15:41:03 +00:00
#78 update dependencies
6543 added this to the v0.2.0 milestone 2020-01-01 16:27:41 +00:00
6543 removed a dependency 2020-01-04 01:48:08 +00:00
#78 update dependencies
6543 commented 2020-01-04 02:12:31 +00:00
Owner
Copy Link

@noerw new go-sdk merged

@noerw new go-sdk merged
noerw changed title from WIP: add `tea times` command to add `tea times` command 2020-01-05 21:57:34 +00:00
noerw commented 2020-01-05 22:09:29 +00:00
Author
Member
Copy Link

@6543 @lunny This is ready now:
Updated to latest master, version check is implemented, from/to filters are implemented client-side.

@6543 @lunny This is ready now: Updated to latest master, version check is implemented, from/to filters are implemented client-side.
techknowlogick reviewed 2020-01-05 22:11:28 +00:00
Dismissed
cmd/config.go Outdated
@ -35,6 +36,27 @@ type Login struct {
Insecure bool `yaml:"insecure"`
}
// Checks the logins server against a version constraint such as ">= 1.11.0+dev"
techknowlogick commented 2020-01-05 22:11:28 +00:00
Owner
Copy Link

Build is failing due to this comment, it should start with CheckServerVersionConstraint

Build is failing due to this comment, it should start with `CheckServerVersionConstraint`
6543 commented 2020-01-06 01:06:41 +00:00
Owner
Copy Link

@noerw would be nice if you wold make code refactor in seperate PR next time :)

  • easier to review
  • easier lookup with git blame
  • changelog generation is simpler too
@noerw would be nice if you wold make code refactor in seperate PR next time :) - easier to review - easier lookup with git blame - changelog generation is simpler too
6543 removed the
status/wip
 label 2020-01-06 01:21:16 +00:00
6543 started working 2020-01-06 01:24:20 +00:00
6543 stopped working 2020-01-06 01:34:29 +00:00
10min 9s
6543 added spent time 2020-01-06 01:35:12 +00:00
5min
6543 approved these changes 2020-01-06 02:23:05 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

plreace split PR next time!

plreace split PR next time!
noerw added spent time 2020-01-06 11:35:30 +00:00
5h
noerw commented 2020-01-06 12:00:27 +00:00
Author
Member
Copy Link

@6543 its there:

USAGE:
   tea times command [command options] [username | #issue]

But I agree this solution is messy (always need to quote '#54' to avoid a bash comment).
We could do a more explicit variant with --user and --issue flags.

@6543 its there: ``` USAGE: tea times command [command options] [username | #issue] ``` But I agree this solution is messy (always need to quote `'#54'` to avoid a bash comment). We could do a more explicit variant with `--user` and `--issue` flags.
noerw commented 2020-01-06 12:07:32 +00:00
Author
Member
Copy Link

Testing tea times '#54' on this issue reveals that I can only list my own times on this issue, 6543s do not show up.

Is that intended / desired behaviour?

Testing `tea times '#54'` on this issue reveals that I can only list my own times on this issue, 6543s do not show up. Is that intended / desired behaviour?
6543 commented 2020-01-06 12:07:55 +00:00
Owner
Copy Link

@noerw no leave it like that we have enouth --options

@noerw no leave it like that we have enouth --options
6543 commented 2020-01-06 12:08:39 +00:00
Owner
Copy Link

@noerw it is, since you are no repoAdmin

... ok UI show this ... maby we should export this too :/

@noerw it is, since you are no repoAdmin ... ok UI show this ... maby we should export this too :/
6543 commented 2020-01-07 15:08:20 +00:00
Owner
Copy Link

"This pull request has changes conflicting with the target branch."

@noerw I thin you have to rebase this PR ...

"This pull request has changes conflicting with the target branch." @noerw I thin you have to rebase this PR ...
6543 added a new dependency 2020-01-27 18:45:47 +00:00
gitea/go-sdk#235 - Changelog v0.11.0
6543 commented 2020-01-28 09:08:01 +00:00
Owner
Copy Link

@noerw can you update to the latest sdk version?

v0.11.0

it also support deleting issues:

  • Client.ResetIssueTime(owner, repo string, index int64)
  • Client.DeleteTime(owner, repo string, index, timeID int64)

added in gitea/go-sdk#210

@noerw can you update to the latest sdk version? **v0.11.0** it also support deleting issues: * `Client.ResetIssueTime(owner, repo string, index int64)` * `Client.DeleteTime(owner, repo string, index, timeID int64)` added in https://gitea.com/gitea/go-sdk/pulls/210
6543 requested changes 2020-01-28 09:08:48 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

update sdk to v0.11.0

update sdk to v0.11.0
noerw added spent time 2020-02-28 16:09:44 +00:00
1h
noerw added spent time 2020-02-28 16:10:11 +00:00
10min
noerw added spent time 2020-02-28 16:11:18 +00:00
10min
noerw deleted spent time 2020-02-28 16:11:39 +00:00
- 6h 20min
noerw added spent time 2020-02-28 16:12:07 +00:00
6h 20min
noerw commented 2020-02-28 16:22:36 +00:00
Author
Member
Copy Link

Ok, finally found some time to finalize this:

  • rebased feature branch onto master
  • now use CheckServerVersionConstraint from SDK v0.11
  • add delete & reset subcommands

@6543

Ok, finally found some time to finalize this: - rebased feature branch onto `master` - now use CheckServerVersionConstraint from SDK v0.11 - add `delete` & `reset` subcommands @6543
👍 1
lunny commented 2020-03-03 06:44:06 +00:00
Owner
Copy Link

CI failed but I think #98 will fix that.

CI failed but I think #98 will fix that.
6543 reviewed 2020-03-03 22:14:01 +00:00
Dismissed
cmd/labels.go Outdated
@ -33,2 +32,2 @@
Name: "save, s",
Usage: "Save all the labels as a file",
&cli.StringFlag{
Name: "save, s",
6543 commented 2020-03-03 22:14:01 +00:00
Owner
Copy Link

can you remove the s there?

can you remove the `s` there?
noerw commented 2020-03-05 09:06:11 +00:00
Author
Member
Copy Link

done

done
6543 requested changes 2020-03-03 22:17:36 +00:00
Dismissed
6543 left a comment
Owner
Copy Link

one nit

one nit
6543 added spent time 2020-03-03 22:18:12 +00:00
10min
6543 approved these changes 2020-03-05 23:39:54 +00:00
Dismissed
6543 commented 2020-03-05 23:53:34 +00:00
Owner
Copy Link

can you merge master in? or update this branch?

can you merge master in? or update this branch?
lunny approved these changes 2020-03-06 01:39:50 +00:00
Dismissed
lunny closed this pull request 2020-03-06 03:43:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
kind/breaking

   
kind/bug

   
kind/build

   
kind/dependency

   
kind/deployment

   
kind/docs
  
kind
enhancement

  
kind
feature

  
kind/proposal
  
kind
question

  
kind
refactor

  
kind/security

   
kind/testing

   
kind/translation

   
priority/critical

   
priority/high

   
priority/low

   
priority/medium

   
reviewed/duplicate

   
reviewed/invalid

   
reviewed/wontfix

   
skip-changelog

   
status/blocked

   
status/has-backport

   
status/has-pull

   
status/needs-backport

   
status/needs-feedback

   
status/needs-reviews

   
status/wip

   
upstream/gitea

   
upstream/sdk
No Label
kind/breaking
kind/bug
kind/build
kind/dependency
kind/deployment
kind/docs
kind
enhancement
kind
feature
kind/proposal
kind
question
kind
refactor
kind/security
kind/testing
kind/translation
priority/critical
priority/high
priority/low
priority/medium
reviewed/duplicate
reviewed/invalid
reviewed/wontfix
skip-changelog
status/blocked
status/has-backport
status/has-pull
status/needs-backport
status/needs-feedback
status/needs-reviews
status/wip
upstream/gitea
upstream/sdk
Milestone
Clear milestone
No items
No Milestone
v0.2.0
Assignees
Clear assignees
No Assignees
5 Participants
Notifications
Total Time Spent: 6 hours 45 minutes
6543
25 minutes 9 seconds
noerw
6 hours 20 minutes
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#198 update TrackedTimes structs (#196)
gitea/go-sdk
#235 Changelog v0.11.0
gitea/go-sdk
Reference: gitea/tea#54
No description provided.
Delete Branch "noerw/tea:50-cmd-times"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?