refactor: improve code quality and efficiency in various files #548

Merged
lunny merged 5 commits from appleboy/tea:lint into main 2023-04-30 03:43:27 +00:00
Member
  • Replace loadConfig() with _ = loadConfig()
  • Update file permissions from 0660 to 0o660
  • Simplify variable declarations
  • Replace golang.org/x/crypto/ssh/terminal with golang.org/x/term
  • Remove unused getCertPrincipals function
  • Replace time.Now().Sub() with time.Since()
  • Add test for ArgToIndex function

Signed-off-by: appleboy appleboy.tw@gmail.com

- Replace loadConfig() with _ = loadConfig() - Update file permissions from 0660 to 0o660 - Simplify variable declarations - Replace golang.org/x/crypto/ssh/terminal with golang.org/x/term - Remove unused getCertPrincipals function - Replace time.Now().Sub() with time.Since() - Add test for ArgToIndex function Signed-off-by: appleboy <appleboy.tw@gmail.com>
appleboy added 1 commit 2023-04-29 00:02:58 +00:00
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 1m40s
6f789aff56
refactor: improve code quality and efficiency in various files
- Replace loadConfig() with _ = loadConfig()
- Update file permissions from 0660 to 0o660
- Simplify variable declarations
- Replace golang.org/x/crypto/ssh/terminal with golang.org/x/term
- Remove unused getCertPrincipals function
- Replace time.Now().Sub() with time.Since()
- Add test for ArgToIndex function

Signed-off-by: appleboy <appleboy.tw@gmail.com>
appleboy added 1 commit 2023-04-29 00:03:16 +00:00
Some checks failed
check-and-test / check-and-test (pull_request) Failing after 2m9s
b78ae28c11
chore: improve functionality and testing across platforms
- Update golang.org/x/term dependency version

Signed-off-by: appleboy <appleboy.tw@gmail.com>
appleboy requested review from lunny 2023-04-29 00:11:53 +00:00
appleboy requested review from wolfogre 2023-04-29 00:11:59 +00:00
appleboy added 1 commit 2023-04-29 00:28:21 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 35s
358f1ae64e
test: improve test coverage and API compatibility
- Add a new test file `parse_test.go` in `modules/utils` directory

Signed-off-by: appleboy <appleboy.tw@gmail.com>
lunny approved these changes 2023-04-29 00:32:52 +00:00
appleboy added 1 commit 2023-04-29 01:37:00 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 32s
710d98eb8e
Merge branch 'main' into lint
lunny added 1 commit 2023-04-30 03:02:05 +00:00
All checks were successful
check-and-test / check-and-test (pull_request) Successful in 30s
bdc8fa97ef
Merge branch 'main' into lint
techknowlogick approved these changes 2023-04-30 03:03:50 +00:00
lunny merged commit b02263adb0 into main 2023-04-30 03:43:27 +00:00
Sign in to join this conversation.
No description provided.