fix: non-standard ssh port URL's repo can't be recognized #555

Merged
6543 merged 2 commits from ilbsmart/tea:main into main 2023-06-06 13:14:25 +00:00
Contributor

Resolve #452

Resolve #452
ilbsmart added 1 commit 2023-05-05 12:17:55 +00:00
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
16f3430174
fix: non-standard ssh port URL's repo can't be recognized
ilbsmart requested review from noerw 2023-05-07 01:24:50 +00:00
ilbsmart requested review from lunny 2023-05-07 01:25:13 +00:00
lunny reviewed 2023-05-07 04:36:21 +00:00
@ -224,3 +224,3 @@
}
} else if strings.EqualFold(p.Scheme, "ssh") {
if sshHost == p.Host {
if sshHost == p.Hostname() {
Owner

Should we also compare the pots?

Should we also compare the pots?
Author
Contributor

It should be, but since login info field "SSHOST" did't include ssh port, so if we need to compare the port, we need to delete login info and login again.

It should be, but since login info field "SSHOST" did't include ssh port, so if we need to compare the port, we need to delete login info and login again.
ilbsmart marked this conversation as resolved
ilbsmart added 1 commit 2023-05-07 10:52:32 +00:00
Some checks failed
check-and-test / check-and-test (pull_request) Has been cancelled
2aa5b47d3a
make SSHHOST include port, like a URL's host
ilbsmart force-pushed main from 2aa5b47d3a to ee27407835 2023-05-07 10:54:24 +00:00 Compare
lunny approved these changes 2023-05-09 08:00:11 +00:00
6543 approved these changes 2023-06-06 13:14:10 +00:00
6543 merged commit b2d845b8c7 into main 2023-06-06 13:14:25 +00:00
6543 added the
kind/bug
label 2023-06-06 13:14:34 +00:00
6543 added this to the v0.10.0 milestone 2023-06-06 13:14:41 +00:00
Sign in to join this conversation.
No description provided.