WIP: First draft of a 'tea pulls create' command #59

Closed
strk wants to merge 1 commits from strk/tea:pulls-create into main
strk commented 3 years ago
Collaborator

I'll need help to complete it

\cc @lunny

I'll need help to complete it \cc @lunny
strk changed title from First draft of a 'tea pulls create' command to WIP: First draft of a 'tea pulls create' command 3 years ago
lunny requested changes 3 years ago
Dismissed
cmd/pulls.go Outdated
Deadline *time.Time `json:"due_date"`
*/
pr, err := login.Client().CreatePullRequest(owner, repo, gitea.CreatePullRequestOption{
Owner

You should push the branch to head remote at first I think.

You should push the branch to head remote at first I think.
Poster
Collaborator

I don't understand this comment. I'm trying to mimick the hub behaviour, where you first push your branch to your fork and after you request a pull. If you have a clear idea of what I am missing could you send a pull request for my branch ?

PS: I did not receiv a notification for your comment, is this a bug that I'm not automatically subscribed when being the author of the PR ?

I don't understand this comment. I'm trying to mimick the `hub` behaviour, where you first push your branch to your fork and _after_ you request a pull. If you have a clear idea of what I am missing could you send a pull request for my branch ? PS: I did not receiv a notification for your comment, is this a bug that I'm not automatically subscribed when being the _author_ of the PR ?
Collaborator
@strk it is https://github.com/go-gitea/gitea/issues/7512
Collaborator

@lunny as tea is a cli tool to interact with gitea it should not do changes to local git ?

@lunny as tea is a cli tool to interact with gitea it should not do changes to local git ?
Collaborator

i a user like to have the latest version of a branch on gitea he can use git push -u myremote branchname?

i a user like to have the latest version of a branch on gitea he can use `git push -u myremote branchname`?
6543 marked this conversation as resolved
lunny added the kind/feature label 3 years ago
6543 added this to the v0.3.0 milestone 3 years ago
6543 added the status/wip label 3 years ago
Poster
Collaborator

@lunny I've just created #95 with:

/tea pulls create --base master --title test --head strk:pulls-create-test

Sounds good, doesn't it ?

@lunny I've just created #95 with: > /tea pulls create --base master --title test --head strk:pulls-create-test Sounds good, doesn't it ?
Owner

@strk But CI is failed, you may should run make fmt. And please change the title to remove the WIP if it's ready to review.

@strk But CI is failed, you may should run `make fmt`. And please change the title to remove the WIP if it's ready to review.
lunny removed the status/wip label 3 years ago
6543 modified the milestone from v0.3.0 to v0.4.0 2 years ago
Collaborator

PR #144 will continue it

PR #144 will continue it
6543 closed this pull request 2 years ago
6543 removed this from the v0.4.0 milestone 2 years ago
Some checks failed
continuous-integration/drone/pr Build is failing
Required
Details
Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Loading…
There is no content yet.