Improve makefile to enable goproxy when go get tools. #98

Merged
lunny merged 2 commits from lunny/tea:lunny/goproxy into master 2020-03-05 09:22:44 +00:00
Owner

To speed up the download dependent packages and avoid network problem from China to golang.org, this PR moved all tools download via go mod.

To speed up the download dependent packages and avoid network problem from China to golang.org, this PR moved all tools download via go mod.
lunny added the
kind/build
label 2020-03-03 06:43:05 +00:00
6543 approved these changes 2020-03-03 22:11:15 +00:00
Dismissed
6543 added this to the v0.2.0 milestone 2020-03-03 22:11:58 +00:00
zeripath approved these changes 2020-03-03 22:27:03 +00:00
Dismissed
jolheiser reviewed 2020-03-03 22:30:00 +00:00
Dismissed
jolheiser left a comment
Owner

The cd /tmp may fail on Windows systems. It works on mine, but I think Git Bash is responsible for intercepting and "correcting" the path in my case.

The `cd /tmp` may fail on Windows systems. It works on mine, but I think Git Bash is responsible for intercepting and "correcting" the path in my case.
jolheiser started working 2020-03-03 22:30:36 +00:00
jolheiser canceled time tracking 2020-03-03 22:30:41 +00:00
silverwind reviewed 2020-03-03 23:52:27 +00:00
Dismissed
@ -74,3 +74,3 @@
lint:
@hash revive > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
$(GO) get -u github.com/mgechev/revive; \
cd /tmp && $(GO) get -u github.com/mgechev/revive; \
Member

What's the cd /tmp for? To prevent writing go.mod?

What's the `cd /tmp` for? To prevent writing `go.mod`?
Author
Owner
@silverwind yes.
lunny closed this pull request 2020-03-05 09:22:44 +00:00
Sign in to join this conversation.
No description provided.