Improve makefile to enable goproxy when go get tools. #98

Merged
lunny merged 2 commits from lunny/tea:lunny/goproxy into master 2 years ago
lunny commented 2 years ago
Owner

To speed up the download dependent packages and avoid network problem from China to golang.org, this PR moved all tools download via go mod.

To speed up the download dependent packages and avoid network problem from China to golang.org, this PR moved all tools download via go mod.
lunny added the
kind/build
label 2 years ago
6543 approved these changes 2 years ago
Dismissed
6543 added this to the v0.2.0 milestone 2 years ago
zeripath approved these changes 2 years ago
Dismissed
jolheiser reviewed 2 years ago
Dismissed
jolheiser left a comment
Collaborator

The cd /tmp may fail on Windows systems. It works on mine, but I think Git Bash is responsible for intercepting and "correcting" the path in my case.

The `cd /tmp` may fail on Windows systems. It works on mine, but I think Git Bash is responsible for intercepting and "correcting" the path in my case.
jolheiser started working 2 years ago
jolheiser cancelled time tracking 2 years ago
silverwind reviewed 2 years ago
Dismissed
lint:
@hash revive > /dev/null 2>&1; if [ $$? -ne 0 ]; then \
$(GO) get -u github.com/mgechev/revive; \
cd /tmp && $(GO) get -u github.com/mgechev/revive; \
Collaborator

What's the cd /tmp for? To prevent writing go.mod?

What's the `cd /tmp` for? To prevent writing `go.mod`?
lunny commented 2 years ago
Poster
Owner
@silverwind yes.
lunny closed this pull request 2 years ago
continuous-integration/drone/pr Build is passing
The pull request has been merged as 5601c57059.
Sign in to join this conversation.
Loading…
There is no content yet.