switch to dart-sass #80

silverwind · 2019-12-07T21:46:49Z

silverwind commented

2019-12-07 21:46:49 +00:00

Using a forked version of gulp-sass until https://github.com/dlmanning/gulp-sass/pull/748 is resolved.

CSS output is around 20kB smaller because dart-sass apparently outputs less whitespace, but otherwise looks compatible.

Using a forked version of gulp-sass until https://github.com/dlmanning/gulp-sass/pull/748 is resolved. CSS output is around 20kB smaller because dart-sass apparently outputs less whitespace, but otherwise looks compatible.

techknowlogick approved these changes 2019-12-07 21:58:51 +00:00

Dismissed

jolheiser approved these changes 2019-12-07 22:00:08 +00:00

Dismissed

silverwind commented

2019-12-07 22:02:51 +00:00

Use of the fibers package will require Node.js 10 or greater, fyi.

Use of the `fibers` package will require Node.js 10 or greater, fyi.

silverwind commented

2019-12-07 22:08:11 +00:00

I removed fibers again as I noticed it brings native Node.js modules which should be avoided. It was a pure performance optimization, not neccesary at all. My build time went from ~1s to 1.5s without fibers which is still plenty fast.

I removed `fibers` again as I noticed it brings native Node.js modules which should be avoided. It was a pure performance optimization, not neccesary at all. My build time went from ~1s to 1.5s without `fibers` which is still plenty fast.

axifive approved these changes 2019-12-07 22:09:57 +00:00

Dismissed

techknowlogick referenced this issue from a commit

2019-12-07 22:10:32 +00:00

switch to dart-sass (#80)

techknowlogick closed this pull request

2019-12-07 22:10:32 +00:00

silverwind referenced this pull request

2019-12-07 23:00:00 +00:00

regenerate package-lock.json #81

silverwind deleted branch dart-sass

2019-12-07 23:01:13 +00:00