Add Japanese translation #91

shuuji3 · 2019-09-16T13:46:01Z

shuuji3 commented

2019-09-16 13:46:01 +00:00

Hello,
Gitea team ?

What

This PR adds Japanese translation for the website.

Why

There is a good Japanese translation for Gitea UI and there are many users because of the existence of translation. However, the website was not translated into Japanese yet.

I expect that this will attract more Japanese developers with Gitea. ?

Note

I did not change the link to docs page intentionally since the Japanese translation of docs does not exist yet.

I'd like to say that it is good if the PR #84 is reviewed too if possible as it is not merged for 6 months and this PR does the same thing as #84.

Thank you

Hello, Gitea team ? ## What This PR adds Japanese translation for the website. ## Why There is a good Japanese translation for Gitea UI and there are many users because of the existence of translation. However, the website was not translated into Japanese yet. I expect that this will attract more Japanese developers with Gitea. ? ## Note I did not change the link to docs page intentionally since the Japanese translation of docs does not exist yet. I'd like to say that it is good if the PR #84 is reviewed too if possible as it is not merged for 6 months and this PR does the same thing as #84. Thank you

lunny commented

2019-09-16 14:14:42 +00:00

That's because we have no maintainers who know Korean, so nobody could review that. That's also for Japanese. Any idea?

shuuji3 commented

2019-09-16 14:35:06 +00:00

Thanks for the quick reply. OK, I understood the situation.

Then how about splitting the review into two parts: checking the structure and checking the translation?

Maintainers do the former check such as syntax and code error check and another native speaker I'll find do the latter translation quality check. Translators found in crowdin might help me and the Korean translator. What do you think?

Thanks for the quick reply. OK, I understood the situation. Then how about splitting the review into two parts: checking the structure and checking the translation? Maintainers do the former check such as syntax and code error check and another native speaker I'll find do the latter translation quality check. Translators found [in crowdin](https://crowdin.com/project/gitea) might help me and the Korean translator. What do you think?

lunny commented

2019-09-17 01:25:08 +00:00

I think that's good if Translators on crowdin could help to review these PRs.

shuuji3 commented

2019-09-17 05:12:24 +00:00

I'll try and find someone who can review this PR on Crowdin.

shuuji3 changed title from ~~add-japanese-translation~~ to Add Japanese translation

2019-09-17 06:13:53 +00:00

Ghost approved these changes 2019-10-03 04:15:20 +00:00

Dismissed

Ghost left a comment

First-time contributor

LGTM

Blueberry approved these changes 2020-09-26 17:07:21 +00:00

Dismissed

Blueberry left a comment

Nice

shuuji3 force-pushed add-japanese-translation from 633596c5c2 to 9084f547ac

2020-09-27 04:00:48 +00:00

Compare

shuuji3 commented

2020-09-27 04:03:06 +00:00

@alexkoala @Blueberry Thank you for your LGTM! I've now resolved the conflict of this PR.

I opened a request for other reviewer one year ago here:
https://crowdin.com/project/gitea/discussions/14/0/home
But I have not got any response yet.?

@alexkoala @Blueberry Thank you for your LGTM! I've now resolved the conflict of this PR. I opened a request for other reviewer one year ago here: https://crowdin.com/project/gitea/discussions/14/0/home But I have not got any response yet.?

6543 commented

2020-09-27 11:53:28 +00:00

Sorry, cant understand Japanese :/

6543 approved these changes 2020-09-27 11:58:50 +00:00

Dismissed

6543 left a comment

got two lgtm's of (guess) 2 native jp speekers

so lgtm

got two lgtm's of (guess) 2 native jp speekers so lgtm

techknowlogick approved these changes 2020-09-27 16:26:37 +00:00

Dismissed

techknowlogick referenced this issue from a commit