#103 [UI] Replace hardcoded strings in the settings

Open
opened 1 week ago by 6543 · 3 comments
6543 commented 1 week ago

Replace hardcodet strings in fragments/SettingsFragment.java with strings who can be translated via strings.xml

    private static String[] langList = {"English", "French", "German", "Russian", "Arabic"};
    private static String[] timeList = {"Pretty", "Normal"};
    private static String[] codeBlockList = {"Green - Black", "White - Black", "Grey - Black", "White - Grey", "Dark - White"};
    private static String[] homeScreenList = {"My Repositories", "Starred Repositories", "Organizations", "Repositories", "Profile"};
Replace hardcodet strings in **fragments/SettingsFragment.java** with strings who can be translated via strings.xml ```java private static String[] langList = {"English", "French", "German", "Russian", "Arabic"}; private static String[] timeList = {"Pretty", "Normal"}; private static String[] codeBlockList = {"Green - Black", "White - Black", "Grey - Black", "White - Grey", "Dark - White"}; private static String[] homeScreenList = {"My Repositories", "Starred Repositories", "Organizations", "Repositories", "Profile"}; ```
6543 added the
Translation
label 1 week ago
6543 added the
Improvement
label 1 week ago
6543 changed title from replace hardcodet strings at settings to [UI] replace hardcodet strings at settings 1 week ago
mmarif commented 1 week ago
Owner

These strings are used as identifier to match the string in switch case for changing languages etc.

Translating them will make the app crash unless IDs are introduced. Let’s see what I can do about it.

These strings are used as identifier to match the string in switch case for changing languages etc. Translating them will make the app crash unless IDs are introduced. Let's see what I can do about it.
mmarif removed the
Translation
label 1 week ago
mmarif changed title from [UI] replace hardcodet strings at settings to [UI] Replace hardcoded strings in the settings 1 week ago
6543 commented 1 week ago
Poster

I noticed,it won’t be easy

I noticed,it won't be easy
mmarif commented 1 week ago
Owner

Yes, need some work.

But let’s keep this issue open for now and who knows can refactor in the future.

Yes, need some work. But let's keep this issue open for now and who knows can refactor in the future.
Sign in to join this conversation.
No Milestone
No Assignees
2 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.