[UI] Replace hardcoded strings in the settings #103

New Issue

Closed

opened 2020-06-03 15:54:16 +00:00 by 6543 · 4 comments

6543 commented

2020-06-03 15:54:16 +00:00

Member

Replace hardcodet strings in fragments/SettingsFragment.java with strings who can be translated via strings.xml

    private static String[] langList = {"English", "French", "German", "Russian", "Arabic"};
    private static String[] timeList = {"Pretty", "Normal"};
    private static String[] codeBlockList = {"Green - Black", "White - Black", "Grey - Black", "White - Grey", "Dark - White"};
    private static String[] homeScreenList = {"My Repositories", "Starred Repositories", "Organizations", "Repositories", "Profile"};

Replace hardcodet strings in **fragments/SettingsFragment.java** with strings who can be translated via strings.xml ```java private static String[] langList = {"English", "French", "German", "Russian", "Arabic"}; private static String[] timeList = {"Pretty", "Normal"}; private static String[] codeBlockList = {"Green - Black", "White - Black", "Grey - Black", "White - Grey", "Dark - White"}; private static String[] homeScreenList = {"My Repositories", "Starred Repositories", "Organizations", "Repositories", "Profile"}; ```

6543 added the

🚀 Improvement

label 2020-06-03 15:54:16 +00:00

mmarif commented

2020-06-03 15:54:56 +00:00

Owner

These strings are used as identifier to match the string in switch case for changing languages etc.

Translating them will make the app crash unless IDs are introduced. Let's see what I can do about it.

These strings are used as identifier to match the string in switch case for changing languages etc. Translating them will make the app crash unless IDs are introduced. Let's see what I can do about it.

6543 commented

2020-06-03 15:55:17 +00:00

Author

Member

I noticed,it won't be easy

mmarif commented

2020-06-03 15:55:37 +00:00

Owner

Yes, need some work.

But let's keep this issue open for now and who knows can refactor in the future.

Yes, need some work. But let's keep this issue open for now and who knows can refactor in the future.

mmarif commented

2020-10-15 09:52:45 +00:00

Owner

This commit has made it possible to add new strings dynamically and translate them also.

377040add6

This commit has made it possible to add new strings dynamically and translate them also. https://codeberg.org/gitnex/GitNex/commit/377040add6c36ecc9a652f1f37ad1584be105ae4